Commit c5aa72ac authored by Kevin Modzelewski's avatar Kevin Modzelewski

Turn off implicit-function check in release mode

I'm still hoping that we can keep this on in some way, because it continues to find issues.
So let's try keeping it on for debug builds.

I'm not sure if this is weakening the check enough (there may be other cases like scipy),
but it's sounding like we need to have this check turned off in our releases regardless,
such as issue #1344.
parent 75d73197
...@@ -373,7 +373,9 @@ class CCompiler: ...@@ -373,7 +373,9 @@ class CCompiler:
cc_args[:0] = before cc_args[:0] = before
if not any ('scipy' in s for s in pp_opts): if not any ('scipy' in s for s in pp_opts):
cc_args = cc_args + ["-Werror=implicit-function-declaration"] import sysconfig
if '-DNDEBUG' not in sysconfig.get_config_var('CFLAGS'):
cc_args = cc_args + ["-Werror=implicit-function-declaration"]
return cc_args return cc_args
def _fix_compile_args(self, output_dir, macros, include_dirs): def _fix_compile_args(self, output_dir, macros, include_dirs):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment