Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
cython
Commits
e7ffd0a2
Commit
e7ffd0a2
authored
Mar 16, 2014
by
Stefan Behnel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix compiler crash on "readonly" properties in "binding" mode
parent
78eb13f9
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
146 additions
and
5 deletions
+146
-5
CHANGES.rst
CHANGES.rst
+2
-0
Cython/Compiler/ParseTreeTransforms.py
Cython/Compiler/ParseTreeTransforms.py
+5
-5
tests/run/cdef_members_binding_properties.pyx
tests/run/cdef_members_binding_properties.pyx
+139
-0
No files found.
CHANGES.rst
View file @
e7ffd0a2
...
@@ -16,6 +16,8 @@ Features added
...
@@ -16,6 +16,8 @@ Features added
Bugs fixed
Bugs fixed
----------
----------
* Compiler crash on readonly properties in "binding" mode.
* Auto-encoding with ``c_string_encoding=ascii`` failed in Py3.3.
* Auto-encoding with ``c_string_encoding=ascii`` failed in Py3.3.
* Crash when subtyping freelist enabled Cython extension types with
* Crash when subtyping freelist enabled Cython extension types with
...
...
Cython/Compiler/ParseTreeTransforms.py
View file @
e7ffd0a2
...
@@ -1399,7 +1399,7 @@ property NAME:
...
@@ -1399,7 +1399,7 @@ property NAME:
return ATTR
return ATTR
def __set__(self, value):
def __set__(self, value):
ATTR = value
ATTR = value
"""
,
level
=
'c_class'
)
"""
,
level
=
'c_class'
,
pipeline
=
[
NormalizeTree
(
None
)]
)
basic_pyobject_property
=
TreeFragment
(
u"""
basic_pyobject_property
=
TreeFragment
(
u"""
property NAME:
property NAME:
def __get__(self):
def __get__(self):
...
@@ -1408,12 +1408,12 @@ property NAME:
...
@@ -1408,12 +1408,12 @@ property NAME:
ATTR = value
ATTR = value
def __del__(self):
def __del__(self):
ATTR = None
ATTR = None
"""
,
level
=
'c_class'
)
"""
,
level
=
'c_class'
,
pipeline
=
[
NormalizeTree
(
None
)]
)
basic_property_ro
=
TreeFragment
(
u"""
basic_property_ro
=
TreeFragment
(
u"""
property NAME:
property NAME:
def __get__(self):
def __get__(self):
return ATTR
return ATTR
"""
,
level
=
'c_class'
)
"""
,
level
=
'c_class'
,
pipeline
=
[
NormalizeTree
(
None
)]
)
struct_or_union_wrapper
=
TreeFragment
(
u"""
struct_or_union_wrapper
=
TreeFragment
(
u"""
cdef class NAME:
cdef class NAME:
...
@@ -1428,13 +1428,13 @@ cdef class NAME:
...
@@ -1428,13 +1428,13 @@ cdef class NAME:
return STR_FORMAT % MEMBER_TUPLE
return STR_FORMAT % MEMBER_TUPLE
def __repr__(self):
def __repr__(self):
return REPR_FORMAT % MEMBER_TUPLE
return REPR_FORMAT % MEMBER_TUPLE
"""
)
"""
,
pipeline
=
[
NormalizeTree
(
None
)]
)
init_assignment
=
TreeFragment
(
u"""
init_assignment
=
TreeFragment
(
u"""
if VALUE is not None:
if VALUE is not None:
ATTR = VALUE
ATTR = VALUE
count += 1
count += 1
"""
)
"""
,
pipeline
=
[
NormalizeTree
(
None
)]
)
fused_function
=
None
fused_function
=
None
in_lambda
=
0
in_lambda
=
0
...
...
tests/run/cdef_members_binding_properties.pyx
0 → 100644
View file @
e7ffd0a2
# cython: embedsignature=True, binding=True
# mode: run
# same test as "cdef_members_T517.pyx" but "binding=True"
__doc__
=
u"""
>>> a = A()
>>> a.h = 7
>>> a.i = 127
>>> a.l = 255
>>> a.q = 255
>>> a.f = 1.0/2.0
>>> a.d = 1/2.0 + 1/4.0
>>> a.g = 1/2.0 + 1/4.0 + 1/8.0
>>> a.Zf = 1+2j
>>> a.Zd = 3+4j
>>> a.Zg = 5+6j
>>> a.h, a.i, a.l
(7, 127, 255)
>>> a.ro_h, a.ro_i, a.ro_l
(7, 127, 255)
>>> a.f, a.d, a.g
(0.5, 0.75, 0.875)
>>> a.ro_f, a.ro_d, a.ro_g
(0.5, 0.75, 0.875)
>>> a.Zf, a.Zd, a.Zg
((1+2j), (3+4j), (5+6j))
>>> a.ro_Zf, a.ro_Zd, a.ro_Zg
((1+2j), (3+4j), (5+6j))
>>> b = B()
>>> b.a0 #doctest: +ELLIPSIS
Traceback (most recent call last):
AttributeError: ...
>>> b.b0 #doctest: +ELLIPSIS
Traceback (most recent call last):
AttributeError: ...
>>> b.c0 #doctest: +ELLIPSIS
Traceback (most recent call last):
AttributeError: ...
>>> isinstance(b.a1, type(None))
True
>>> isinstance(b.a2, type(None))
True
>>> isinstance(b.b1, list)
True
>>> isinstance(b.b2, list)
True
>>> isinstance(b.c1, A)
True
>>> isinstance(b.c2, A)
True
>>> b.a1 = a
>>> b.a1 is not b.a2
True
TYPE_FIXES_REQUIRED:
>>> try: b.b1 = 1
... except (TypeError, AttributeError): pass
>>> try: b.c1 = 1
... except (TypeError, AttributeError): pass
>>> try: b.a2 = None
... except (TypeError, AttributeError): pass
>>> try: b.b2 = []
... except (TypeError, AttributeError): pass
>>> try: b.c2 = A()
... except (TypeError, AttributeError): pass
"""
import
sys
if
sys
.
version_info
<
(
2
,
5
):
__doc__
=
(
__doc__
.
split
(
'TYPE_FIXES_REQUIRED'
)[
0
]
+
__doc__
.
split
(
'TYPE_FIXES_REQUIRED'
)[
1
].
replace
(
'
\
n
AttributeError: ...'
,
'
\
n
TypeError: ...'
))
cdef
class
A
:
cdef
public
short
h
cdef
public
int
i
cdef
public
long
l
cdef
public
long
long
q
cdef
public
float
f
cdef
public
double
d
cdef
public
long
double
g
cdef
public
float
complex
Zf
cdef
public
double
complex
Zd
cdef
public
long
double
complex
Zg
cdef
readonly
short
ro_h
cdef
readonly
int
ro_i
cdef
readonly
long
ro_l
cdef
readonly
long
long
ro_q
cdef
readonly
float
ro_f
cdef
readonly
double
ro_d
cdef
readonly
long
double
ro_g
cdef
readonly
float
complex
ro_Zf
cdef
readonly
double
complex
ro_Zd
cdef
readonly
long
double
complex
ro_Zg
def
__cinit__
(
self
):
self
.
ro_h
=
7
self
.
ro_i
=
127
self
.
ro_l
=
255
self
.
ro_q
=
255
self
.
ro_f
=
1.0
/
2.0
self
.
ro_d
=
1
/
2.0
+
1
/
4.0
self
.
ro_g
=
1
/
2.0
+
1
/
4.0
+
1
/
8.0
self
.
ro_Zf
=
1
+
2j
self
.
ro_Zd
=
3
+
4j
self
.
ro_Zg
=
5
+
6j
cdef
class
B
:
cdef
object
a0
cdef
public
object
a1
cdef
readonly
object
a2
cdef
list
b0
cdef
public
list
b1
cdef
readonly
list
b2
cdef
A
c0
cdef
public
A
c1
cdef
readonly
A
c2
def
__cinit__
(
self
):
self
.
b0
=
self
.
b1
=
self
.
b2
=
[]
self
.
c0
=
self
.
c1
=
self
.
c2
=
A
()
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment