Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
030bfd85
Commit
030bfd85
authored
Sep 15, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes milestone issuable assignee URL
Closes #33124
parent
93e189c4
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
1 deletion
+25
-1
app/views/shared/milestones/_issuable.html.haml
app/views/shared/milestones/_issuable.html.haml
+1
-1
changelogs/unreleased/milestone-avatar-issuable-link.yml
changelogs/unreleased/milestone-avatar-issuable-link.yml
+5
-0
spec/views/shared/milestones/_issuable.html.haml.rb
spec/views/shared/milestones/_issuable.html.haml.rb
+19
-0
No files found.
app/views/shared/milestones/_issuable.html.haml
View file @
030bfd85
...
...
@@ -26,6 +26,6 @@
%span
.assignee-icon
-
assignees
.
each
do
|
assignee
|
=
link_to
polymorphic_path
(
base_url
_args
,
{
milestone_title:
@milestone
.
title
,
assignee_id:
assignee
.
id
,
state:
'all'
}),
=
link_to
polymorphic_path
(
issuable_type
_args
,
{
milestone_title:
@milestone
.
title
,
assignee_id:
assignee
.
id
,
state:
'all'
}),
class:
'has-tooltip'
,
title:
"Assigned to
#{
assignee
.
name
}
"
,
data:
{
container:
'body'
}
do
-
image_tag
(
avatar_icon
(
assignee
,
16
),
class:
"avatar s16"
,
alt:
''
)
changelogs/unreleased/milestone-avatar-issuable-link.yml
0 → 100644
View file @
030bfd85
---
title
:
Fixed milestone issuable assignee link URL
merge_request
:
author
:
type
:
fixed
spec/views/shared/milestones/_issuable.html.haml.rb
0 → 100644
View file @
030bfd85
require
'spec_helper'
describe
'shared/milestones/_issuable.html.haml'
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:milestone
)
{
create
(
:milestone
,
project:
project
)
}
let
(
:issuable
)
{
create
(
:issue
,
project:
project
,
assignees:
[
user
])
}
before
do
assign
(
:project
,
project
)
assign
(
:milestone
,
milestone
)
end
it
'avatar links to issues page'
do
render
'shared/milestones/issuable'
,
issuable:
issuable
,
show_project_name:
true
expect
(
rendered
).
to
have_css
(
"a[href='
#{
project_issues_path
(
project
,
milestone_title:
milestone
.
title
,
assignee_id:
user
.
id
,
state:
'all'
)
}
']"
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment