Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
07f15f9a
Commit
07f15f9a
authored
Oct 16, 2018
by
Adriel Santiago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix prometheus graphs in firefox
parent
b0808af2
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
2 deletions
+8
-2
app/assets/javascripts/monitoring/components/graph.vue
app/assets/javascripts/monitoring/components/graph.vue
+3
-2
changelogs/unreleased/40372-prometheus-dashboard-broken-on-firefox.yml
...released/40372-prometheus-dashboard-broken-on-firefox.yml
+5
-0
No files found.
app/assets/javascripts/monitoring/components/graph.vue
View file @
07f15f9a
...
...
@@ -121,6 +121,7 @@ export default {
draw
()
{
const
breakpointSize
=
bp
.
getBreakpointSize
();
const
query
=
this
.
graphData
.
queries
[
0
];
const
svgWidth
=
this
.
$refs
.
baseSvg
.
getBoundingClientRect
().
width
;
this
.
margin
=
measurements
.
large
.
margin
;
if
(
this
.
smallGraph
||
breakpointSize
===
'
xs
'
||
breakpointSize
===
'
sm
'
)
{
this
.
graphHeight
=
300
;
...
...
@@ -130,13 +131,13 @@ export default {
this
.
unitOfDisplay
=
query
.
unit
||
''
;
this
.
yAxisLabel
=
this
.
graphData
.
y_label
||
'
Values
'
;
this
.
legendTitle
=
query
.
label
||
'
Average
'
;
this
.
graphWidth
=
this
.
$refs
.
baseSvg
.
client
Width
-
this
.
margin
.
left
-
this
.
margin
.
right
;
this
.
graphWidth
=
svg
Width
-
this
.
margin
.
left
-
this
.
margin
.
right
;
this
.
graphHeight
=
this
.
graphHeight
-
this
.
margin
.
top
-
this
.
margin
.
bottom
;
this
.
baseGraphHeight
=
this
.
graphHeight
-
50
;
this
.
baseGraphWidth
=
this
.
graphWidth
;
// pixel offsets inside the svg and outside are not 1:1
this
.
realPixelRatio
=
this
.
$refs
.
baseSvg
.
client
Width
/
this
.
baseGraphWidth
;
this
.
realPixelRatio
=
svg
Width
/
this
.
baseGraphWidth
;
this
.
renderAxesPaths
();
this
.
formatDeployments
();
...
...
changelogs/unreleased/40372-prometheus-dashboard-broken-on-firefox.yml
0 → 100644
View file @
07f15f9a
---
title
:
Fix prometheus graphs in firefox
merge_request
:
22400
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment