small cleanup changes based on feedback

app/models/user.rb

@@ -810,6 +810,10 @@ class User < ActiveRecord::Base
     avatar_path(args) || GravatarService.new.execute(email, size, scale, username: username)
   end
 
+  def primary_email_verified?
+    confirmed? && !temp_oauth_email?
+  end
+
   def all_emails
     all_emails = []
     all_emails << email unless temp_oauth_email?
@@ -817,15 +821,15 @@ class User < ActiveRecord::Base
     all_emails
   end
 
-  def all_verified_emails
+  def verified_emails
     verified_emails = []
-    verified_emails << email if confirmed? && !temp_oauth_email?
-    verified_emails.concat(emails.select {|e| e.confirmed?}.map(&:email))
+    verified_emails << email if primary_email_verified?
+    verified_emails.concat(emails.where.not(confirmed_at: nil).pluck(:email))
     verified_emails
   end
 
-  def verified_email?(email)
-    all_verified_emails.include?(email)
+  def verified_email?(check_email)
+    (email == check_email && primary_email_verified?) || verified_emails.include?(check_email)
   end
 
   def hook_attrs

app/views/devise/mailer/confirmation_instructions.html.haml

-- if @resource.is_a?(User)
-  = render partial: 'confirmation_instructions_account'
+= render partial: "confirmation_instructions_#{@resource.is_a?(User) ? 'account' : 'secondary'}"
\ No newline at end of file
-- else
-  = render partial: 'confirmation_instructions_secondary'

app/views/devise/mailer/confirmation_instructions.text.erb

-<% if @resource.is_a?(User) %>
-<%= render partial: 'confirmation_instructions_account' %>
+<%= render partial: "confirmation_instructions_#{@resource.is_a?(User) ? 'account' : 'secondary'}" %>
\ No newline at end of file
-<% else %>
-<%= render partial: 'confirmation_instructions_secondary' %>
-<% end %>

config/routes/user.rb

@@ -12,7 +12,7 @@ devise_scope :user do
 end
 
 # for secondary email confirmations
-devise_for   :emails, controllers: { confirmations: :confirmations }
+devise_for :emails, controllers: { confirmations: :confirmations }
 
 scope(constraints: { username: Gitlab::PathRegex.root_namespace_route_regex }) do
   scope(path: 'users/:username',

spec/models/user_spec.rb

@@ -1100,18 +1100,18 @@ describe User do
       email_confirmed   = create :email, user: user, confirmed_at: Time.now
       email_unconfirmed = create :email, user: user
       user.reload
-      expect(user.all_emails).to eq([user.email, email_unconfirmed.email, email_confirmed.email])
+      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
     end
   end
 
-  describe '#all_verified_emails' do
+  describe '#verified_emails' do
     let(:user) { create(:user) }
 
     it 'returns only confirmed emails' do
       email_confirmed   = create :email, user: user, confirmed_at: Time.now
       email_unconfirmed = create :email, user: user
       user.reload
-      expect(user.all_verified_emails).to eq([user.email, email_confirmed.email])
+      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
     end
   end