Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
20438213
Commit
20438213
authored
Jul 18, 2016
by
Kamil Trzcinski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use `capitalize` instead of `titleize` for manual actions
parent
640924e4
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
9 additions
and
9 deletions
+9
-9
app/views/projects/ci/pipelines/_pipeline.html.haml
app/views/projects/ci/pipelines/_pipeline.html.haml
+1
-1
app/views/projects/deployments/_actions.haml
app/views/projects/deployments/_actions.haml
+1
-1
app/views/projects/environments/show.html.haml
app/views/projects/environments/show.html.haml
+1
-1
spec/features/environments_spec.rb
spec/features/environments_spec.rb
+4
-4
spec/features/pipelines_spec.rb
spec/features/pipelines_spec.rb
+2
-2
No files found.
app/views/projects/ci/pipelines/_pipeline.html.haml
View file @
20438213
...
...
@@ -70,7 +70,7 @@
%li
=
link_to
play_namespace_project_build_path
(
@project
.
namespace
,
@project
,
build
),
method: :post
,
rel:
'nofollow'
do
=
icon
(
"play"
)
%span
=
build
.
name
.
title
ize
%span
=
build
.
name
.
capital
ize
-
if
artifacts
.
present?
.btn-group
%a
.dropdown-toggle.btn.btn-default.build-artifacts
{
type:
'button'
,
'data-toggle'
=>
'dropdown'
}
...
...
app/views/projects/deployments/_actions.haml
View file @
20438213
...
...
@@ -12,7 +12,7 @@
%li
=
link_to
[
:play
,
@project
.
namespace
.
becomes
(
Namespace
),
@project
,
action
],
method: :post
,
rel:
'nofollow'
do
=
icon
(
"play"
)
%span
=
action
.
name
.
title
ize
%span
=
action
.
name
.
capital
ize
-
if
defined?
(
allow_rollback
)
&&
allow_rollback
=
link_to
[
:retry
,
@project
.
namespace
.
becomes
(
Namespace
),
@project
,
deployment
.
deployable
],
method: :post
,
class:
'btn btn-build'
do
...
...
app/views/projects/environments/show.html.haml
View file @
20438213
...
...
@@ -5,7 +5,7 @@
%div
{
class:
container_class
}
.top-area
.col-md-9
%h3
.page-title
=
@environment
.
name
.
title
ize
%h3
.page-title
=
@environment
.
name
.
capital
ize
.col-md-3
.nav-controls
...
...
spec/features/environments_spec.rb
View file @
20438213
...
...
@@ -52,12 +52,12 @@ feature 'Environments', feature: true do
given
(
:manual
)
{
create
(
:ci_build
,
:manual
,
pipeline:
pipeline
,
name:
'deploy to production'
)
}
scenario
'does show a play button'
do
expect
(
page
).
to
have_link
(
manual
.
name
.
title
ize
)
expect
(
page
).
to
have_link
(
manual
.
name
.
capital
ize
)
end
scenario
'does allow to play manual action'
do
expect
(
manual
).
to
be_skipped
expect
{
click_link
(
manual
.
name
.
title
ize
)
}.
to
change
{
Ci
::
Pipeline
.
count
}.
by
(
0
)
expect
{
click_link
(
manual
.
name
.
capital
ize
)
}.
to
change
{
Ci
::
Pipeline
.
count
}.
by
(
0
)
expect
(
page
).
to
have_content
(
manual
.
name
)
expect
(
manual
.
reload
).
to
be_pending
end
...
...
@@ -113,12 +113,12 @@ feature 'Environments', feature: true do
given
(
:manual
)
{
create
(
:ci_build
,
:manual
,
pipeline:
pipeline
,
name:
'deploy to production'
)
}
scenario
'does show a play button'
do
expect
(
page
).
to
have_link
(
manual
.
name
.
title
ize
)
expect
(
page
).
to
have_link
(
manual
.
name
.
capital
ize
)
end
scenario
'does allow to play manual action'
do
expect
(
manual
).
to
be_skipped
expect
{
click_link
(
manual
.
name
.
title
ize
)
}.
to
change
{
Ci
::
Pipeline
.
count
}.
by
(
0
)
expect
{
click_link
(
manual
.
name
.
capital
ize
)
}.
to
change
{
Ci
::
Pipeline
.
count
}.
by
(
0
)
expect
(
page
).
to
have_content
(
manual
.
name
)
expect
(
manual
.
reload
).
to
be_pending
end
...
...
spec/features/pipelines_spec.rb
View file @
20438213
...
...
@@ -67,10 +67,10 @@ describe "Pipelines" do
before
{
visit
namespace_project_pipelines_path
(
project
.
namespace
,
project
)
}
it
{
expect
(
page
).
to
have_link
(
'Manual
B
uild'
)
}
it
{
expect
(
page
).
to
have_link
(
'Manual
b
uild'
)
}
context
'when playing'
do
before
{
click_link
(
'Manual
B
uild'
)
}
before
{
click_link
(
'Manual
b
uild'
)
}
it
{
expect
(
manual
.
reload
).
to
be_pending
}
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment