Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
3d3e043c
Commit
3d3e043c
authored
Sep 30, 2017
by
Gustav Ernberg
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unnecessary alt-texts from pipeline emails
parent
0781e956
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
10 deletions
+15
-10
app/views/notify/pipeline_failed_email.html.haml
app/views/notify/pipeline_failed_email.html.haml
+5
-5
app/views/notify/pipeline_success_email.html.haml
app/views/notify/pipeline_success_email.html.haml
+5
-5
changelogs/unreleased/issue-36484.yml
changelogs/unreleased/issue-36484.yml
+5
-0
No files found.
app/views/notify/pipeline_failed_email.html.haml
View file @
3d3e043c
...
@@ -31,7 +31,7 @@
...
@@ -31,7 +31,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-branch-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
"
Branch icon
"
}
/
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-branch-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%a
.muted
{
href:
commits_url
(
@pipeline
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
commits_url
(
@pipeline
),
style:
"color:#333333;text-decoration:none;"
}
=
@pipeline
.
ref
=
@pipeline
.
ref
...
@@ -42,7 +42,7 @@
...
@@ -42,7 +42,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-commit-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
"
Commit icon
"
}
/
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-commit-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%a
{
href:
commit_url
(
@pipeline
),
style:
"color:#3777b0;text-decoration:none;"
}
%a
{
href:
commit_url
(
@pipeline
),
style:
"color:#3777b0;text-decoration:none;"
}
=
@pipeline
.
short_sha
=
@pipeline
.
short_sha
...
@@ -60,7 +60,7 @@
...
@@ -60,7 +60,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
author
||
commit
.
author_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
author
||
commit
.
author_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
-
if
commit
.
author
-
if
commit
.
author
%a
.muted
{
href:
user_url
(
commit
.
author
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
commit
.
author
),
style:
"color:#333333;text-decoration:none;"
}
...
@@ -76,7 +76,7 @@
...
@@ -76,7 +76,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
committer
||
commit
.
committer_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
committer
||
commit
.
committer_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
-
if
commit
.
committer
-
if
commit
.
committer
%a
.muted
{
href:
user_url
(
commit
.
committer
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
commit
.
committer
),
style:
"color:#333333;text-decoration:none;"
}
...
@@ -100,7 +100,7 @@
...
@@ -100,7 +100,7 @@
triggered by
triggered by
-
if
@pipeline
.
user
-
if
@pipeline
.
user
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;padding-left:5px"
,
width:
"24"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;padding-left:5px"
,
width:
"24"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
@pipeline
.
user
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
@pipeline
.
user
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;font-weight:500;line-height:1.4;vertical-align:baseline;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;font-weight:500;line-height:1.4;vertical-align:baseline;"
}
%a
.muted
{
href:
user_url
(
@pipeline
.
user
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
@pipeline
.
user
),
style:
"color:#333333;text-decoration:none;"
}
=
@pipeline
.
user
.
name
=
@pipeline
.
user
.
name
...
...
app/views/notify/pipeline_success_email.html.haml
View file @
3d3e043c
...
@@ -31,7 +31,7 @@
...
@@ -31,7 +31,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-branch-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
"
Branch icon
"
}
/
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-branch-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%a
.muted
{
href:
commits_url
(
@pipeline
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
commits_url
(
@pipeline
),
style:
"color:#333333;text-decoration:none;"
}
=
@pipeline
.
ref
=
@pipeline
.
ref
...
@@ -42,7 +42,7 @@
...
@@ -42,7 +42,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-commit-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
"
Commit icon
"
}
/
%img
{
height:
"13"
,
src:
image_url
(
'mailers/ci_pipeline_notif_v1/icon-commit-gray.gif'
),
style:
"display:block;"
,
width:
"13"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%a
{
href:
commit_url
(
@pipeline
),
style:
"color:#3777b0;text-decoration:none;"
}
%a
{
href:
commit_url
(
@pipeline
),
style:
"color:#3777b0;text-decoration:none;"
}
=
@pipeline
.
short_sha
=
@pipeline
.
short_sha
...
@@ -60,7 +60,7 @@
...
@@ -60,7 +60,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
author
||
commit
.
author_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
author
||
commit
.
author_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
-
if
commit
.
author
-
if
commit
.
author
%a
.muted
{
href:
user_url
(
commit
.
author
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
commit
.
author
),
style:
"color:#333333;text-decoration:none;"
}
...
@@ -76,7 +76,7 @@
...
@@ -76,7 +76,7 @@
%tbody
%tbody
%tr
%tr
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
committer
||
commit
.
committer_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
commit
.
committer
||
commit
.
committer_email
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;"
}
-
if
commit
.
committer
-
if
commit
.
committer
%a
.muted
{
href:
user_url
(
commit
.
committer
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
commit
.
committer
),
style:
"color:#333333;text-decoration:none;"
}
...
@@ -100,7 +100,7 @@
...
@@ -100,7 +100,7 @@
triggered by
triggered by
-
if
@pipeline
.
user
-
if
@pipeline
.
user
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;padding-left:5px"
,
width:
"24"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;line-height:1.4;vertical-align:middle;padding-right:5px;padding-left:5px"
,
width:
"24"
}
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
@pipeline
.
user
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
"
Avatar
"
}
/
%img
.avatar
{
height:
"24"
,
src:
avatar_icon
(
@pipeline
.
user
,
24
,
only_path:
false
),
style:
"display:block;border-radius:12px;margin:-2px 0;"
,
width:
"24"
,
alt:
""
}
/
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;font-weight:500;line-height:1.4;vertical-align:baseline;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:15px;font-weight:500;line-height:1.4;vertical-align:baseline;"
}
%a
.muted
{
href:
user_url
(
@pipeline
.
user
),
style:
"color:#333333;text-decoration:none;"
}
%a
.muted
{
href:
user_url
(
@pipeline
.
user
),
style:
"color:#333333;text-decoration:none;"
}
=
@pipeline
.
user
.
name
=
@pipeline
.
user
.
name
...
...
changelogs/unreleased/issue-36484.yml
0 → 100644
View file @
3d3e043c
---
title
:
Remove unnecessary alt-texts from pipeline emails
merge_request
:
14602
author
:
gernberg
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
