Merge branch 'disable-issue-action-button-if-isSubmitting' into 'master'

Disable issue action button whilst submitting and test

See merge request gitlab-org/gitlab-ce!15211

app/assets/javascripts/notes/components/issue_comment_form.vue

@@ -357,7 +357,8 @@
                   @click="handleSave(true)"
                   v-if="canUpdateIssue"
                   :class="actionButtonClassNames"
-                  class="btn btn-comment btn-comment-and-close">
+                  :disabled="isSubmitting"
+                  class="btn btn-comment btn-comment-and-close js-action-button">
                   {{issueActionButtonTitle}}
                 </button>
                 <button

spec/javascripts/notes/components/issue_comment_form_spec.js

@@ -55,6 +55,25 @@ describe('issue_comment_form component', () => {
 
         expect(vm.toggleIssueState).toHaveBeenCalled();
       });
+
+      it('should disable action button whilst submitting', (done) => {
+        const saveNotePromise = Promise.resolve();
+        vm.note = 'hello world';
+        spyOn(vm, 'saveNote').and.returnValue(saveNotePromise);
+        spyOn(vm, 'stopPolling');
+
+        const actionButton = vm.$el.querySelector('.js-action-button');
+
+        vm.handleSave();
+
+        Vue.nextTick()
+          .then(() => expect(actionButton.disabled).toBeTruthy())
+          .then(saveNotePromise)
+          .then(Vue.nextTick)
+          .then(() => expect(actionButton.disabled).toBeFalsy())
+          .then(done)
+          .catch(done.fail);
+      });
     });
 
     describe('textarea', () => {