Merge branch 'gt-align-issue-status-and-confidential-icon' into 'master'

Align issue status label and confidential icon

Closes #53943

See merge request gitlab-org/gitlab-ce!23046

app/assets/stylesheets/framework/issue_box.scss

@@ -22,7 +22,7 @@
   margin-right: 10px;
   color: $white-light;
   font-size: $gl-font-size;
-  line-height: 25px;
+  line-height: $gl-line-height-24;
 
   &.status-box-closed,
   &.status-box-mr-closed {

app/assets/stylesheets/framework/variables.scss

@@ -271,6 +271,7 @@ $context-header-height: 60px;
 $breadcrumb-min-height: 48px;
 $project-title-row-height: 24px;
 $gl-line-height: 16px;
+$gl-line-height-24: 24px;
 
 /*
 * Common component specific colors

app/assets/stylesheets/pages/issuable.scss

@@ -6,19 +6,16 @@
 .issuable-warning-icon {
   background-color: $orange-100;
   border-radius: $border-radius-default;
-  margin: 0 $btn-side-margin 0 0;
   width: $issuable-warning-size;
   height: $issuable-warning-size;
   text-align: center;
+  margin-right: $issuable-warning-icon-margin;
+  line-height: $gl-line-height-24;
 
   .icon {
     fill: $orange-600;
     vertical-align: text-bottom;
   }
-
-  &:first-of-type {
-    margin-right: $issuable-warning-icon-margin;
-  }
 }
 
 .limit-container-width {
@@ -689,7 +686,6 @@
   flex: 1;
   display: inline-block;
   font-size: 14px;
-  line-height: 24px;
   align-self: center;
   overflow: hidden;
   text-overflow: ellipsis;

changelogs/unreleased/gt-align-issue-status-and-confidential-icon.yml

+---
+title: Align issue status label and confidential icon.
+merge_request: 23046
+author: George Tsiolis
+type: fixed