Removed disabled rules from the user_callout_spec.js

Also changed the cookie sets to true and false values to make
it consistent with the rest of the javascript.

Fixed some haml and a missing new line

app/assets/javascripts/user_callout.js

-/* eslint-disable arrow-parens, class-methods-use-this, no-param-reassign */
+/* eslint-disable class-methods-use-this */
 /* global Cookies */
 
 const userCalloutElementName = '.user-callout';
@@ -11,21 +11,20 @@ class UserCallout {
   constructor() {
     this.isCalloutDismissed = Cookies.get(USER_CALLOUT_COOKIE);
     this.init();
-    this.isUserCalloutDismissed();
+    this.toggleUserCallout();
   }
 
   init() {
     $(document)
-      .on('click', closeButton, () => this.closeAndDismissCallout())
-      .on('click', userCalloutBtn, () => this.closeAndDismissCallout());
+      .on('click', closeButton, () => this.dismissCallout())
+      .on('click', userCalloutBtn, () => this.dismissCallout());
   }
 
-  closeAndDismissCallout() {
-    $(userCalloutElementName).hide();
-    Cookies.set(USER_CALLOUT_COOKIE, '1');
+  dismissCallout() {
+    Cookies.set(USER_CALLOUT_COOKIE, 'true');
   }
 
-  isUserCalloutDismissed() {
+  toggleUserCallout() {
     if (!this.isCalloutDismissed) {
       $(userCalloutElementName).show();
     }

app/views/users/show.html.haml

@@ -99,7 +99,6 @@
     
   %div{ class: container_class }
     = render partial: 'shared/user_callout'
-  %div{ class: container_class }
     .tab-content
       #activity.tab-pane
         .row-content-block.calender-block.white.second-block.hidden-xs

spec/javascripts/user_callout_spec.js

-/* esint-disable space-before-function-paren, arrow-body-style */
 const UserCallout = require('~/user_callout');
 
 const USER_CALLOUT_COOKIE = 'user_callout_dismissed';
@@ -14,7 +13,7 @@ describe('UserCallout', function () {
     this.closeButton = $('.close-user-callout');
     this.userCalloutContainer = $('.user-callout');
     this.userCalloutBtn = $('.user-callout-btn');
-    Cookie.set(USER_CALLOUT_COOKIE, 0);
+    Cookie.set(USER_CALLOUT_COOKIE, 'false');
   });
 
   it('shows when cookie is set to false', () => {
@@ -24,13 +23,11 @@ describe('UserCallout', function () {
 
   it('hides when user clicks on the dismiss-icon', () => {
     this.closeButton.click();
-    expect(this.userCalloutContainer.is(':visible')).toBe(false);
-    expect(Cookie.get(USER_CALLOUT_COOKIE)).toBe('1');
+    expect(Cookie.get(USER_CALLOUT_COOKIE)).toBe('true');
   });
 
   it('hides when user clicks on the "check it out" button', () => {
     this.userCalloutBtn.click();
-    expect(this.userCalloutContainer.is(':visible')).toBe(false);
-    expect(Cookie.get(USER_CALLOUT_COOKIE)).toBe('1');
+    expect(Cookie.get(USER_CALLOUT_COOKIE)).toBe('true');
   });
 });