Commit 6f040230 authored by Filipa Lacerda's avatar Filipa Lacerda

Changes after review

parent 1848ddf6
...@@ -225,13 +225,6 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -225,13 +225,6 @@ A forEach will cause side effects, it will be mutating the array being iterated.
### Vue.js ### Vue.js
#### Basic Rules #### Basic Rules
1. Only include one Vue.js component per file.
1. Export components as plain objects:
```javascript
export default {
template: `<h1>I'm a component</h1>
}
```
1. The service has it's own file 1. The service has it's own file
1. The store has it's own file 1. The store has it's own file
1. Use a function in the bundle file to instantiate the Vue component: 1. Use a function in the bundle file to instantiate the Vue component:
...@@ -274,22 +267,13 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -274,22 +267,13 @@ A forEach will cause side effects, it will be mutating the array being iterated.
#### Naming #### Naming
1. **Extensions**: Use `.vue` extension for Vue components. 1. **Extensions**: Use `.vue` extension for Vue components.
1. **Reference Naming**: Use PascalCase for Vue components and camelCase for their instances: 1. **Reference Naming**: Use camelCase for their instances:
```javascript ```javascript
// bad
import cardBoard from 'cardBoard';
// good // good
import CardBoard from 'cardBoard' import cardBoard from 'cardBoard'
// bad
components: { components: {
CardBoard: CardBoard cardBoard:
};
// good
components: {
cardBoard: CardBoard
}; };
``` ```
...@@ -495,6 +479,16 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -495,6 +479,16 @@ A forEach will cause side effects, it will be mutating the array being iterated.
1. Tooltips: When using a tooltip, include the tooltip mixin 1. Tooltips: When using a tooltip, include the tooltip mixin
1. Don't change `data-original-title`. 1. Don't change `data-original-title`.
```javascript
// bad
<span data-original-title="tooltip text">Foo</span>
// good
<span title="tooltip text">Foo</span>
$('span').tooltip('fixTitle');
```
## SCSS ## SCSS
- [SCSS](style_guide_scss.md) - [SCSS](style_guide_scss.md)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment