Refactor NotificationService#pipeline_finished to use skip_current_user

instead of passing nil for current_user

Refactor NotificationService#pipeline_finished to use skip_current_user
instead of passing nil for current_user
7cd260b1 · Richard Macklin · 0e2c96e7 · 7cd260b1
Commit 7cd260b1 authored Feb 03, 2017 by Richard Macklin
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

app/services/notification_service.rb app/services/notification_service.rb +3 -2

No files found.
--- a/app/services/notification_service.rb
+++ b/app/services/notification_service.rb
@@ -327,8 +327,9 @@ class NotificationService
    recipients ||= build_recipients(
      pipeline,
      pipeline.project,
-      nil, # The acting user, who won't be added to recipients
+      pipeline.user,
-      action: pipeline.status).map(&:notification_email)
+      action: pipeline.status,
+      skip_current_user: false).map(&:notification_email)
    if recipients.any?
      mailer.public_send(email_template, pipeline, recipients).deliver_later