Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
7f395e86
Commit
7f395e86
authored
6 years ago
by
George Tsiolis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename block scope local variable in table pagination spec
parent
4acc4b56
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
11 deletions
+16
-11
changelogs/unreleased/rename-local-variable.yml
changelogs/unreleased/rename-local-variable.yml
+5
-0
spec/javascripts/vue_shared/components/table_pagination_spec.js
...avascripts/vue_shared/components/table_pagination_spec.js
+11
-11
No files found.
changelogs/unreleased/rename-local-variable.yml
0 → 100644
View file @
7f395e86
---
title
:
Rename block scope local variable in table pagination spec
merge_request
:
21969
author
:
George Tsiolis
type
:
other
This diff is collapsed.
Click to expand it.
spec/javascripts/vue_shared/components/table_pagination_spec.js
View file @
7f395e86
...
@@ -5,13 +5,13 @@ describe('Pagination component', () => {
...
@@ -5,13 +5,13 @@ describe('Pagination component', () => {
let
component
;
let
component
;
let
PaginationComponent
;
let
PaginationComponent
;
let
spy
;
let
spy
;
let
mountComponet
;
let
mountCompone
n
t
;
beforeEach
(()
=>
{
beforeEach
(()
=>
{
spy
=
jasmine
.
createSpy
(
'
spy
'
);
spy
=
jasmine
.
createSpy
(
'
spy
'
);
PaginationComponent
=
Vue
.
extend
(
paginationComp
);
PaginationComponent
=
Vue
.
extend
(
paginationComp
);
mountComponet
=
function
(
props
)
{
mountCompone
n
t
=
function
(
props
)
{
return
new
PaginationComponent
({
return
new
PaginationComponent
({
propsData
:
props
,
propsData
:
props
,
}).
$mount
();
}).
$mount
();
...
@@ -20,7 +20,7 @@ describe('Pagination component', () => {
...
@@ -20,7 +20,7 @@ describe('Pagination component', () => {
describe
(
'
render
'
,
()
=>
{
describe
(
'
render
'
,
()
=>
{
it
(
'
should not render anything
'
,
()
=>
{
it
(
'
should not render anything
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
1
,
nextPage
:
1
,
page
:
1
,
page
:
1
,
...
@@ -37,7 +37,7 @@ describe('Pagination component', () => {
...
@@ -37,7 +37,7 @@ describe('Pagination component', () => {
describe
(
'
prev button
'
,
()
=>
{
describe
(
'
prev button
'
,
()
=>
{
it
(
'
should be disabled and non clickable
'
,
()
=>
{
it
(
'
should be disabled and non clickable
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
2
,
nextPage
:
2
,
page
:
1
,
page
:
1
,
...
@@ -59,7 +59,7 @@ describe('Pagination component', () => {
...
@@ -59,7 +59,7 @@ describe('Pagination component', () => {
});
});
it
(
'
should be enabled and clickable
'
,
()
=>
{
it
(
'
should be enabled and clickable
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
3
,
nextPage
:
3
,
page
:
2
,
page
:
2
,
...
@@ -78,7 +78,7 @@ describe('Pagination component', () => {
...
@@ -78,7 +78,7 @@ describe('Pagination component', () => {
describe
(
'
first button
'
,
()
=>
{
describe
(
'
first button
'
,
()
=>
{
it
(
'
should call the change callback with the first page
'
,
()
=>
{
it
(
'
should call the change callback with the first page
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
3
,
nextPage
:
3
,
page
:
2
,
page
:
2
,
...
@@ -102,7 +102,7 @@ describe('Pagination component', () => {
...
@@ -102,7 +102,7 @@ describe('Pagination component', () => {
describe
(
'
last button
'
,
()
=>
{
describe
(
'
last button
'
,
()
=>
{
it
(
'
should call the change callback with the last page
'
,
()
=>
{
it
(
'
should call the change callback with the last page
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
3
,
nextPage
:
3
,
page
:
2
,
page
:
2
,
...
@@ -126,7 +126,7 @@ describe('Pagination component', () => {
...
@@ -126,7 +126,7 @@ describe('Pagination component', () => {
describe
(
'
next button
'
,
()
=>
{
describe
(
'
next button
'
,
()
=>
{
it
(
'
should be disabled and non clickable
'
,
()
=>
{
it
(
'
should be disabled and non clickable
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
5
,
nextPage
:
5
,
page
:
5
,
page
:
5
,
...
@@ -148,7 +148,7 @@ describe('Pagination component', () => {
...
@@ -148,7 +148,7 @@ describe('Pagination component', () => {
});
});
it
(
'
should be enabled and clickable
'
,
()
=>
{
it
(
'
should be enabled and clickable
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
4
,
nextPage
:
4
,
page
:
3
,
page
:
3
,
...
@@ -168,7 +168,7 @@ describe('Pagination component', () => {
...
@@ -168,7 +168,7 @@ describe('Pagination component', () => {
describe
(
'
numbered buttons
'
,
()
=>
{
describe
(
'
numbered buttons
'
,
()
=>
{
it
(
'
should render 5 pages
'
,
()
=>
{
it
(
'
should render 5 pages
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
4
,
nextPage
:
4
,
page
:
3
,
page
:
3
,
...
@@ -185,7 +185,7 @@ describe('Pagination component', () => {
...
@@ -185,7 +185,7 @@ describe('Pagination component', () => {
});
});
it
(
'
should render the spread operator
'
,
()
=>
{
it
(
'
should render the spread operator
'
,
()
=>
{
component
=
mountComponet
({
component
=
mountCompone
n
t
({
pageInfo
:
{
pageInfo
:
{
nextPage
:
4
,
nextPage
:
4
,
page
:
3
,
page
:
3
,
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment