Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
88e3d76d
Commit
88e3d76d
authored
Sep 10, 2018
by
Luke Bennett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update code_review.md to include a recommendation for assigning maintainers from different teams
Improve recommended maintainer docs
parent
53fceedc
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
doc/development/code_review.md
doc/development/code_review.md
+3
-2
No files found.
doc/development/code_review.md
View file @
88e3d76d
...
@@ -27,8 +27,9 @@ There are a few rules to get your merge request accepted:
...
@@ -27,8 +27,9 @@ There are a few rules to get your merge request accepted:
ask or assign any
[
reviewers
][
projects
]
for a first review.
ask or assign any
[
reviewers
][
projects
]
for a first review.
1.
If you need some guidance (e.g. it's your first merge request), feel free
1.
If you need some guidance (e.g. it's your first merge request), feel free
to ask one of the
[
Merge request coaches
][
team
]
.
to ask one of the
[
Merge request coaches
][
team
]
.
1.
The reviewer will assign the merge request to a maintainer once the
1.
It is recommended that you assign a maintainer that is from a different team than your own.
reviewer is satisfied with the state of the merge request.
This ensures that all code across GitLab is consistent and can be easily understood by all contributors.
1.
Keep in mind that maintainers are also going to perform a final code review.
1.
Keep in mind that maintainers are also going to perform a final code review.
The ideal scenario is that the reviewer has already addressed any concerns
The ideal scenario is that the reviewer has already addressed any concerns
the maintainer would have found, and the maintainer only has to perform the
the maintainer would have found, and the maintainer only has to perform the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment