Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
89aeed18
Commit
89aeed18
authored
Jan 26, 2016
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feature and fix for 500 on group missing
parent
eb7f6690
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
0 deletions
+10
-0
app/controllers/groups_controller.rb
app/controllers/groups_controller.rb
+1
-0
features/explore/groups.feature
features/explore/groups.feature
+5
-0
features/steps/explore/groups.rb
features/steps/explore/groups.rb
+4
-0
No files found.
app/controllers/groups_controller.rb
View file @
89aeed18
...
@@ -81,6 +81,7 @@ class GroupsController < Groups::ApplicationController
...
@@ -81,6 +81,7 @@ class GroupsController < Groups::ApplicationController
def
group
def
group
@group
||=
Group
.
find_by
(
path:
params
[
:id
])
@group
||=
Group
.
find_by
(
path:
params
[
:id
])
render_404
unless
@group
end
end
def
load_projects
def
load_projects
...
...
features/explore/groups.feature
View file @
89aeed18
...
@@ -3,6 +3,11 @@ Feature: Explore Groups
...
@@ -3,6 +3,11 @@ Feature: Explore Groups
Background
:
Background
:
Given
group
"TestGroup"
has private project
"Enterprise"
Given
group
"TestGroup"
has private project
"Enterprise"
Scenario
:
I
should not see a group if it does not exist
When
I sign in as a user
And
I visit group
"NonExistentGroup"
page
Then
page status code should be 404
Scenario
:
I
should see group with private and internal projects as user
Scenario
:
I
should see group with private and internal projects as user
Given
group
"TestGroup"
has internal project
"Internal"
Given
group
"TestGroup"
has internal project
"Internal"
When
I sign in as a user
When
I sign in as a user
...
...
features/steps/explore/groups.rb
View file @
89aeed18
...
@@ -26,6 +26,10 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps
...
@@ -26,6 +26,10 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps
visit
group_path
(
Group
.
find_by
(
name:
"TestGroup"
))
visit
group_path
(
Group
.
find_by
(
name:
"TestGroup"
))
end
end
step
'I visit group "NonExistentGroup" page'
do
visit
group_path
(
-
1
)
end
step
'I visit group "TestGroup" issues page'
do
step
'I visit group "TestGroup" issues page'
do
visit
issues_group_path
(
Group
.
find_by
(
name:
"TestGroup"
))
visit
issues_group_path
(
Group
.
find_by
(
name:
"TestGroup"
))
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment