Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
89ecba5e
Commit
89ecba5e
authored
Nov 04, 2015
by
Tomasz Maczukin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update forks visibility_level after parent project visibility_level change
parent
3bc012db
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
40 additions
and
14 deletions
+40
-14
app/models/project.rb
app/models/project.rb
+5
-1
app/services/projects/update_service.rb
app/services/projects/update_service.rb
+35
-13
No files found.
app/models/project.rb
View file @
89ecba5e
...
@@ -731,7 +731,11 @@ class Project < ActiveRecord::Base
...
@@ -731,7 +731,11 @@ class Project < ActiveRecord::Base
end
end
def
forks_count
def
forks_count
ForkedProjectLink
.
where
(
forked_from_project_id:
self
.
id
).
count
forks
.
count
end
def
forks
ForkedProjectLink
.
where
(
forked_from_project_id:
self
.
id
)
end
end
def
find_label
(
name
)
def
find_label
(
name
)
...
...
app/services/projects/update_service.rb
View file @
89ecba5e
...
@@ -3,7 +3,8 @@ module Projects
...
@@ -3,7 +3,8 @@ module Projects
def
execute
def
execute
# check that user is allowed to set specified visibility_level
# check that user is allowed to set specified visibility_level
new_visibility
=
params
[
:visibility_level
]
new_visibility
=
params
[
:visibility_level
]
if
new_visibility
&&
new_visibility
.
to_i
!=
project
.
visibility_level
if
new_visibility
if
new_visibility
.
to_i
!=
project
.
visibility_level
unless
can?
(
current_user
,
:change_visibility_level
,
project
)
&&
unless
can?
(
current_user
,
:change_visibility_level
,
project
)
&&
Gitlab
::
VisibilityLevel
.
allowed_for?
(
current_user
,
new_visibility
)
Gitlab
::
VisibilityLevel
.
allowed_for?
(
current_user
,
new_visibility
)
deny_visibility_level
(
project
,
new_visibility
)
deny_visibility_level
(
project
,
new_visibility
)
...
@@ -11,13 +12,8 @@ module Projects
...
@@ -11,13 +12,8 @@ module Projects
end
end
end
end
unless
project
.
visibility_level_allowed?
(
new_visibility
)
return
false
unless
visibility_level_allowed?
(
new_visibility
)
level_name
=
Gitlab
::
VisibilityLevel
.
level_name
(
new_visibility
)
update_forks_visibility_level
(
new_visibility
)
project
.
errors
.
add
(
:visibility_level
,
"
#{
level_name
}
could not be set as visibility level of this project - parent project settings are more restrictive"
)
return
false
end
end
new_branch
=
params
[
:default_branch
]
new_branch
=
params
[
:default_branch
]
...
@@ -32,5 +28,31 @@ module Projects
...
@@ -32,5 +28,31 @@ module Projects
end
end
end
end
end
end
private
def
visibility_level_allowed?
(
level
)
return
true
if
project
.
visibility_level_allowed?
(
level
)
level_name
=
Gitlab
::
VisibilityLevel
.
level_name
(
level
)
project
.
errors
.
add
(
:visibility_level
,
"
#{
level_name
}
could not be set as visibility level of this project - parent project settings are more restrictive"
)
false
end
def
update_forks_visibility_level
(
new_level
)
project
.
forks
.
each
do
|
forked_link
|
forked_project
=
forked_link
.
forked_to_project
fork_level
=
forked_project
.
visibility_level
if
fork_level
>
new_level
.
to_i
forked_project
.
visibility_level
=
new_level
.
to_i
forked_project
.
save!
end
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment