Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8a0e3144
Commit
8a0e3144
authored
Nov 02, 2017
by
Pawel Chojnacki
Committed by
Stan Hu
Nov 02, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove Filesystem check metrics that use too much CPU to handle requests
parent
95f9f053
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
13 deletions
+6
-13
app/services/metrics_service.rb
app/services/metrics_service.rb
+1
-2
changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml
...ogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml
+5
-0
spec/controllers/metrics_controller_spec.rb
spec/controllers/metrics_controller_spec.rb
+0
-11
No files found.
app/services/metrics_service.rb
View file @
8a0e3144
...
...
@@ -6,8 +6,7 @@ class MetricsService
Gitlab
::
HealthChecks
::
Redis
::
RedisCheck
,
Gitlab
::
HealthChecks
::
Redis
::
CacheCheck
,
Gitlab
::
HealthChecks
::
Redis
::
QueuesCheck
,
Gitlab
::
HealthChecks
::
Redis
::
SharedStateCheck
,
Gitlab
::
HealthChecks
::
FsShardsCheck
Gitlab
::
HealthChecks
::
Redis
::
SharedStateCheck
].
freeze
def
prometheus_metrics_text
...
...
changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml
0 → 100644
View file @
8a0e3144
---
title
:
Remove Filesystem check metrics that use too much CPU to handle requests
merge_request
:
author
:
type
:
performance
spec/controllers/metrics_controller_spec.rb
View file @
8a0e3144
...
...
@@ -59,17 +59,6 @@ describe MetricsController do
expect
(
response
.
body
).
to
match
(
/^redis_shared_state_ping_latency_seconds [0-9\.]+$/
)
end
it
'returns file system check metrics'
do
get
:index
expect
(
response
.
body
).
to
match
(
/^filesystem_access_latency_seconds{shard="default"} [0-9\.]+$/
)
expect
(
response
.
body
).
to
match
(
/^filesystem_accessible{shard="default"} 1$/
)
expect
(
response
.
body
).
to
match
(
/^filesystem_write_latency_seconds{shard="default"} [0-9\.]+$/
)
expect
(
response
.
body
).
to
match
(
/^filesystem_writable{shard="default"} 1$/
)
expect
(
response
.
body
).
to
match
(
/^filesystem_read_latency_seconds{shard="default"} [0-9\.]+$/
)
expect
(
response
.
body
).
to
match
(
/^filesystem_readable{shard="default"} 1$/
)
end
context
'prometheus metrics are disabled'
do
before
do
allow
(
Gitlab
::
Metrics
).
to
receive
(
:prometheus_metrics_enabled?
).
and_return
(
false
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment