Merge branch 'sh-fix-grape-logging-status-code' into 'master'

Fix api_json.log not always reporting the right HTTP status code

See merge request gitlab-org/gitlab-ce!19028

changelogs/unreleased/sh-fix-grape-logging-status-code.yml

+---
+title: Fix api_json.log not always reporting the right HTTP status code
+merge_request:
+author:
+type: fixed

lib/api/api.rb

@@ -8,7 +8,8 @@ module API
     PROJECT_ENDPOINT_REQUIREMENTS = { id: NO_SLASH_URL_PART_REGEX }.freeze
     COMMIT_ENDPOINT_REQUIREMENTS = PROJECT_ENDPOINT_REQUIREMENTS.merge(sha: NO_SLASH_URL_PART_REGEX).freeze
 
-    use GrapeLogging::Middleware::RequestLogger,
+    insert_before Grape::Middleware::Error,
+                  GrapeLogging::Middleware::RequestLogger,
                   logger: Logger.new(LOG_FILENAME),
                   formatter: Gitlab::GrapeLogging::Formatters::LogrageWithTimestamp.new,
                   include: [