Commit b7d74401 authored by Grzegorz Bizon's avatar Grzegorz Bizon

Fix Rubocop offenses in commit status/build specs

parent c4d5b231
...@@ -767,20 +767,18 @@ describe Ci::Build, :models do ...@@ -767,20 +767,18 @@ describe Ci::Build, :models do
end end
end end
end end
context 'when build does not have script or before script' do
end
end end
describe '#has_tags?' do describe '#has_tags?' do
context 'when build has tags' do context 'when build has tags' do
subject { create(:ci_build, tag_list: ['tag']) } subject { create(:ci_build, tag_list: ['tag']) }
it { is_expected.to have_tags } it { is_expected.to have_tags }
end end
context 'when build does not have tags' do context 'when build does not have tags' do
subject { create(:ci_build, tag_list: []) } subject { create(:ci_build, tag_list: []) }
it { is_expected.not_to have_tags } it { is_expected.not_to have_tags }
end end
end end
......
...@@ -199,14 +199,14 @@ describe CommitStatus, :models do ...@@ -199,14 +199,14 @@ describe CommitStatus, :models do
subject { described_class.failed_but_allowed.order(:id) } subject { described_class.failed_but_allowed.order(:id) }
let(:statuses) do let(:statuses) do
[create_status(allow_failure: true, status: 'success'), [create_status(allow_failure: true, status: 'success'),
create_status(allow_failure: true, status: 'failed'), create_status(allow_failure: true, status: 'failed'),
create_status(allow_failure: false, status: 'success'), create_status(allow_failure: false, status: 'success'),
create_status(allow_failure: false, status: 'failed'), create_status(allow_failure: false, status: 'failed'),
create_status(allow_failure: true, status: 'canceled'), create_status(allow_failure: true, status: 'canceled'),
create_status(allow_failure: false, status: 'canceled'), create_status(allow_failure: false, status: 'canceled'),
create_status(allow_failure: true, status: 'manual'), create_status(allow_failure: true, status: 'manual'),
create_status(allow_failure: false, status: 'manual')] create_status(allow_failure: false, status: 'manual')]
end end
it 'returns statuses without what we want to ignore' do it 'returns statuses without what we want to ignore' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment