Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
b7d74401
Commit
b7d74401
authored
Mar 06, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rubocop offenses in commit status/build specs
parent
c4d5b231
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
12 deletions
+10
-12
spec/models/ci/build_spec.rb
spec/models/ci/build_spec.rb
+2
-4
spec/models/commit_status_spec.rb
spec/models/commit_status_spec.rb
+8
-8
No files found.
spec/models/ci/build_spec.rb
View file @
b7d74401
...
@@ -767,20 +767,18 @@ describe Ci::Build, :models do
...
@@ -767,20 +767,18 @@ describe Ci::Build, :models do
end
end
end
end
end
end
context
'when build does not have script or before script'
do
end
end
end
describe
'#has_tags?'
do
describe
'#has_tags?'
do
context
'when build has tags'
do
context
'when build has tags'
do
subject
{
create
(
:ci_build
,
tag_list:
[
'tag'
])
}
subject
{
create
(
:ci_build
,
tag_list:
[
'tag'
])
}
it
{
is_expected
.
to
have_tags
}
it
{
is_expected
.
to
have_tags
}
end
end
context
'when build does not have tags'
do
context
'when build does not have tags'
do
subject
{
create
(
:ci_build
,
tag_list:
[])
}
subject
{
create
(
:ci_build
,
tag_list:
[])
}
it
{
is_expected
.
not_to
have_tags
}
it
{
is_expected
.
not_to
have_tags
}
end
end
end
end
...
...
spec/models/commit_status_spec.rb
View file @
b7d74401
...
@@ -199,14 +199,14 @@ describe CommitStatus, :models do
...
@@ -199,14 +199,14 @@ describe CommitStatus, :models do
subject
{
described_class
.
failed_but_allowed
.
order
(
:id
)
}
subject
{
described_class
.
failed_but_allowed
.
order
(
:id
)
}
let
(
:statuses
)
do
let
(
:statuses
)
do
[
create_status
(
allow_failure:
true
,
status:
'success'
),
[
create_status
(
allow_failure:
true
,
status:
'success'
),
create_status
(
allow_failure:
true
,
status:
'failed'
),
create_status
(
allow_failure:
true
,
status:
'failed'
),
create_status
(
allow_failure:
false
,
status:
'success'
),
create_status
(
allow_failure:
false
,
status:
'success'
),
create_status
(
allow_failure:
false
,
status:
'failed'
),
create_status
(
allow_failure:
false
,
status:
'failed'
),
create_status
(
allow_failure:
true
,
status:
'canceled'
),
create_status
(
allow_failure:
true
,
status:
'canceled'
),
create_status
(
allow_failure:
false
,
status:
'canceled'
),
create_status
(
allow_failure:
false
,
status:
'canceled'
),
create_status
(
allow_failure:
true
,
status:
'manual'
),
create_status
(
allow_failure:
true
,
status:
'manual'
),
create_status
(
allow_failure:
false
,
status:
'manual'
)]
create_status
(
allow_failure:
false
,
status:
'manual'
)]
end
end
it
'returns statuses without what we want to ignore'
do
it
'returns statuses without what we want to ignore'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment