Merge branch 'filtered-search-visual-tokens-improvements' into 'master'

Filtered Search Visual Tokens code improvements

See merge request !9781

app/assets/javascripts/filtered_search/dropdown_utils.js

@@ -79,6 +79,7 @@
       return dataValue !== null;
     }
 
+    // Determines the full search query (visual tokens + input)
     static getSearchQuery() {
       const tokensContainer = document.querySelector('.tokens-container');
       const values = [];

spec/features/issues/filtered_search/filter_issues_spec.rb

@@ -112,7 +112,7 @@ describe 'Filter issues', js: true, feature: true do
     end
 
     context 'author with other filters' do
-      search_term = 'issue'
+      let(:search_term) { 'issue' }
 
       it 'filters issues by searched author and text' do
         input_filtered_search("author:@#{user.username} #{search_term}")
@@ -536,7 +536,7 @@ describe 'Filter issues', js: true, feature: true do
     end
 
     context 'milestone with other filters' do
-      search_term = 'bug'
+      let(:search_term) { 'bug' }
 
       it 'filters issues by searched milestone and text' do
         input_filtered_search("milestone:%#{milestone.title} #{search_term}")

spec/features/merge_requests/filter_by_labels_spec.rb

@@ -70,7 +70,7 @@ feature 'Issue filtering by Labels', feature: true, js: true do
 
   context 'filter by label enhancement and bug in issues list' do
     before do
-      input_filtered_search('label:~bug label:~enhancement ')
+      input_filtered_search('label:~bug label:~enhancement')
     end
 
     it 'applies the filters' do