Merge branch 'refactor-jobs-show-haml' into 'master'

Add dispatcher imports for job details bundle

See merge request gitlab-org/gitlab-ce!17157

app/assets/javascripts/jobs/job_details_bundle.js

@@ -3,7 +3,7 @@ import JobMediator from './job_details_mediator';
 import jobHeader from './components/header.vue';
 import detailsBlock from './components/sidebar_details_block.vue';
 
-document.addEventListener('DOMContentLoaded', () => {
+export default () => {
   const dataset = document.getElementById('js-job-details-vue').dataset;
   const mediator = new JobMediator({ endpoint: dataset.endpoint });
 
@@ -55,4 +55,4 @@ document.addEventListener('DOMContentLoaded', () => {
       });
     },
   });
-});
+};

app/assets/javascripts/pages/projects/jobs/show/index.js

+import initJobDetails from '~/jobs/job_details_bundle';
+
+document.addEventListener('DOMContentLoaded', initJobDetails);

app/views/projects/jobs/show.html.haml

@@ -112,7 +112,3 @@
 .js-build-options{ data: javascript_build_options }
 
 #js-job-details-vue{ data: { endpoint: project_job_path(@project, @build, format: :json) } }
-
-- content_for :page_specific_javascripts do
-  = webpack_bundle_tag('common_vue')
-  = webpack_bundle_tag('job_details')

config/webpack.config.js

@@ -64,7 +64,6 @@ var config = {
     filtered_search:      './filtered_search/filtered_search_bundle.js',
     help:                 './help/help.js',
     issue_show:           './issue_show/index.js',
-    job_details:          './jobs/job_details_bundle.js',
     locale:               './locale/index.js',
     main:                 './main.js',
     merge_conflicts:      './merge_conflicts/merge_conflicts_bundle.js',
@@ -254,7 +253,6 @@ var config = {
         'filtered_search',
         'groups',
         'issue_show',
-        'job_details',
         'merge_conflicts',
         'monitoring',
         'notebook_viewer',