Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
ef14bf17
Commit
ef14bf17
authored
Dec 07, 2017
by
Clement Ho
Committed by
Jacob Schatz
Dec 07, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add documentation about using US-English
parent
4824c0ff
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
0 deletions
+2
-0
CONTRIBUTING.md
CONTRIBUTING.md
+2
-0
No files found.
CONTRIBUTING.md
View file @
ef14bf17
...
@@ -598,6 +598,7 @@ merge request:
...
@@ -598,6 +598,7 @@ merge request:
present time and never use past tense (has been/was). For example instead
present time and never use past tense (has been/was). For example instead
of _prohibited this user from being saved due to the following errors:_ the
of _prohibited this user from being saved due to the following errors:_ the
text should be _sorry, we could not create your account because:_
text should be _sorry, we could not create your account because:_
1.
Code should be written in
[
US English
][
us-english
]
This is also the style used by linting tools such as
This is also the style used by linting tools such as
[
RuboCop
](
https://github.com/bbatsov/rubocop
)
,
[
RuboCop
](
https://github.com/bbatsov/rubocop
)
,
...
@@ -663,6 +664,7 @@ available at [http://contributor-covenant.org/version/1/1/0/](http://contributor
...
@@ -663,6 +664,7 @@ available at [http://contributor-covenant.org/version/1/1/0/](http://contributor
[
GitLab Inc engineering workflow
]:
https://about.gitlab.com/handbook/engineering/workflow/#labelling-issues
[
GitLab Inc engineering workflow
]:
https://about.gitlab.com/handbook/engineering/workflow/#labelling-issues
[
polling-etag
]:
https://docs.gitlab.com/ce/development/polling.html
[
polling-etag
]:
https://docs.gitlab.com/ce/development/polling.html
[
testing
]:
doc/development/testing_guide/index.md
[
testing
]:
doc/development/testing_guide/index.md
[
us-english
]:
https://en.wikipedia.org/wiki/American_English
[
^1
]:
Please
note that specs other than JavaScript specs are considered backend
[
^1
]:
Please
note that specs other than JavaScript specs are considered backend
code.
code.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment