- 07 Sep, 2016 40 commits
-
-
Mike Greiling authored
-
Mike Greiling authored
-
Mike Greiling authored
-
Fatih Acet authored
Replace animateEmoji timeout with eventListener ## What does this MR do? Replaces the end animation timeout for awards_handler.js with an eventListener that listens for the animationEnd event ## Are there points in the code the reviewer needs to double check? Check for any side effects ## Why was this MR needed? Improve code quality so that it is easier to understand ## What are the relevant issue numbers? Closes #20679 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5690
-
Rémy Coutable authored
Pass dependencies to CI configuration nodes ## What does this MR do? This MR makes it possible to pass dependencies to CI configuration nodes. ## What are the relevant issue numbers? See #15060 ## Does this MR meet the acceptance criteria? - Tests - [x] Added for this feature/bug - [x] All builds are passing See merge request !6009
-
Rémy Coutable authored
Fix merge conflict size limit ## What does this MR do? The merge conflict size limit was set to 100 KB, but the docs (and the test repo, which the feature specs use) say 200 KB! ## Are there points in the code the reviewer needs to double check? Don't think so. ## Why was this MR needed? Derp. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !6052
-
Rémy Coutable authored
Escape search terms before passing to Regexp ## What does this MR do? Use `Regexp.escape` to escape the search terms before passing them to `Regexp.new`. ## Why was this MR needed? - evaluated regular expressions in search terms lead to unexpected result - unbalanced parentheses in search term lead to server error ## TODO - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added ## What are the relevant issue numbers? fixes #14360 See merge request !6241
-
Rémy Coutable authored
Use PipelinesFinder in Pipelines API ## What does this MR do? Sort output for the API endpoint, and uses the PipelinesFinder there. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21566 See merge request !6094
-
Fatih Acet authored
Fix styling of shortcuts modal ## What does this MR do? Fixes some weird height issue in the shortcuts modal. ## Screenshots (if relevant) ### Before ![Screen_Shot_2016-09-07_at_15.13.09](/uploads/5c4d7716e355794c8aa9764e0fa53f4e/Screen_Shot_2016-09-07_at_15.13.09.png) ### After ![Screen_Shot_2016-09-07_at_15.12.57](/uploads/6f5c145963b4b89910be44b6b254e117/Screen_Shot_2016-09-07_at_15.12.57.png) See merge request !6244
-
Fatih Acet authored
Add issues filters reset btn ## What does this MR do? Adds a button to the issues filter to reset all filters. I also lightly refactored a nearby method. ## Are there points in the code the reviewer needs to double check? At the moment, the user can click the reset button even when no filters have been set. I didn't really like how it looked flashing the link on and off depending on whether a user had added a filter. I prefer having it there all the time, so the user is aware of it. But it wouldn't be difficult to hide if no filters have been set, if that's preferred. ## Why was this MR needed? So users can reset filters when they're filtering issues. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/14016 ## Screenshots (if relevant) ![reset-filters](/uploads/562916158ce7b0179794e19f88f5c2e3/reset-filters.png) ## Does this MR meet the acceptance criteria? - [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [X] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [X] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [X] Branch has no merge conflicts with `master` (if you do - rebase it please) - [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5330
-
Sean McGivern authored
-
Rémy Coutable authored
Fix: Switch sample values for $CI_SERVER_REVISION and $CI_SERVER_VERSION. See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html. ## What does this MR do? There is a sample in this document showing the possible values of the predefined CI variables. Those of **CI_SERVER_REVISION** and **CI_SERVER_VERSION** were mixed up. I fixed that. See merge request !6243
-
Phil Hughes authored
-
Bryce Johnson authored
-
Z.J. van de Weg authored
-
Bryce Johnson authored
-
winniehell authored
-
winniehell authored
-
Rémy Coutable authored
API for CI Lint ## What does this MR do? Add API for CI Lint. Can check if `.gitlab-ci.yml` content is valid. ## What are the relevant issue numbers? Closes #15571 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] API support added - [x] Documentation - Tests - [x] Added for this feature/bug - [x] All builds are passing cc @ubudzisz @grzesiek @yorickpeterse See merge request !5953
-
Rémy Coutable authored
Issue #21440: Small fix to curl example for adding member to project ## What does this MR do? Two lines changed in docs to move the user_id field out of the url and onto the query string ## Why was this MR needed? Issue #21440 reported under Issues. The documentation example for adding members to a project had a slight problem. ## What are the relevant issue numbers? Closes #21440. See merge request !6236
-
Patrick Thaele authored
-
Rémy Coutable authored
Gitlab -> GitLab ## What does this MR do? Fix GitLab capitalization See merge request !6235
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-
Katarzyna Kobierska authored
-