Because it is sometimes never used.

https://gitlab.com/gitlab-org/gitlab-ce/commit/57e3e942de1adef2c8621905370f07d7da7870c4

I changed it to a separate condition rather than depending on the order of the case-when statements to prevent this mistake again.

And refactor to self-document a little better.

No external behavior change.

This allows `GitHttpController` to set the HTTP status based on the type of error. Alternatively, we could have added an attribute to GitAccessStatus, but this pattern seemed appropriate.

This already works due to previous refactoring.

Changes to `GitHttpClientController`’s authentication logic caused this behavior change.

The old 401 Unauthorized statuses didn’t cause any harm, but they weren’t quite as accurate as the new behavior.

* The spec has 7 failures at this point
* Specify rendered error messages
* Render the GitAccess message rather than “Access denied”
* Render the Not Found message provided by GitAccess, instead of a custom one
* Expect GitAccess to check the config for whether Git-over-HTTP pull or push is disabled, rather than doing it in the controller
* Add more thorough testing for authentication
* Dried up a lot of tests
* Fixed some broken tests

Port fix-realtime-edited-text-for-issues 9-2-stable fix to master.

See merge request !11478

Add slugified project path to CI environment variables

Closes #31061

See merge request !11838

Initial implementation for real time job view

Closes #31397

See merge request !11651

Forbid Sidekiq scheduling in transactions

Closes #27233

See merge request !9376

ConvDev Index

Closes #30469

See merge request !11377

Improve user experience around slash commands in instant comments

Closes #32464

See merge request !11612

Add `$CI_ENVIRONMENT_URL` as a job variable

Closes #25680

See merge request !11695

Fix LFS timeouts when trying to save large files

Closes #33218

See merge request !11866

The following was happening:

1. Workhorse stores an LFS file in /var/opt/gitlab/gitlab-rails/shared/lfs-objects
2. CarrierWave then renames the file to a temporary directory (e.g. /opt/gitlab/embedded/service/gitlab-rails/tmp)
3. CarrierWave then renames the file to its final location (e.g. /var/opt/gitlab/gitlab-rails/shared/lfs-objects)

When the LFS upload path was on a different filesystem than the Rails
installation, step 2 could take a longer than 10 seconds, at which point Workhorse
would time out with "badgateway: failed after 10s: context canceled".

This change makes the work path in the same root as the LFS storage path, preventing moves
across filesystems.

Closes #33218

Merge branch '32992-consider-using-zopfli-over-standard-gzip-compression-for-webpack-assets' into 'master'

Use zopfli for better asset compression and disable compression in CI

Closes #32992

See merge request !11798

Resolve "Documentation of `.gitlab-ci.yml` states incorrect example for variables"

Closes #30337

See merge request !11895

32118 Make New environment empty state btn lowercase

Closes #32118

See merge request !11350

Document go1.8.3 as dependency

See merge request !11245

Expose import_status in Projects API

Closes #19646

See merge request !11851

Allow manual bypass of auto_sign_in_with_provider

Closes #3786

See merge request !11884

32832 Remove overflow from comment form for confidential issues and vertically a…

Closes #32832 and #32926

See merge request !11867

Allow users to be hard-deleted from the API

See merge request !11853

Fixed typo: craeted -> created

See merge request !11886