Reply nicely in case of wrong status.

master/bt5/vifib_slapos_rest_api_v1_test/TestTemplateItem/testVifibSlaposRestAPIV1.py

@@ -282,6 +282,33 @@ class TestInstanceRequest(VifibSlaposRestAPIV1Mixin):
       self.json_response)
     self.assertPersonRequestSimulatorEmpty()
 
+  def test_incorrect_status(self):
+    kwargs = {
+      'parameter': {
+        'Custom1': 'one string',
+        'Custom2': 'one float',
+        'Custom3': ['abc', 'def']},
+      'title': 'My unique instance',
+      'software_release': 'http://example.com/example.cfg',
+      'status': 'badstatus',
+      'sla': {
+        'computer_id': 'COMP-0'},
+      'software_type': 'type_provided_by_the_software',
+      'slave': True}
+    self.connection.request(method='POST',
+      url='/'.join([self.api_path, 'instance']),
+      body=json.dumps(kwargs),
+      headers={'REMOTE_USER': self.customer_reference})
+    self.prepareResponse()
+    self.assertBasicResponse()
+    self.assertResponseCode(400)
+    self.assertResponseJson()
+    self.assertEqual({
+        "status": "Status shall be one of: started, stopped, destroyed.",
+        },
+      self.json_response)
+    self.assertPersonRequestSimulatorEmpty()
+
   def test_correct(self):
     kwargs = {
       'parameter': {

master/bt5/vifib_slapos_rest_api_v1_test/bt/revision

-55
+56
\ No newline at end of file

master/product/Vifib/Tool/VifibRestApiV1Tool.py

@@ -318,6 +318,11 @@ class InstancePublisher(GenericPublisher):
       ):
       request_dict[k_i] = self.jbody[k_j]
 
+    if request_dict['state'] not in ['started', 'stopped', 'destroyed']:
+      self.REQUEST.response.setStatus(400)
+      self.REQUEST.response.setBody(jsonify(
+        {'status': 'Status shall be one of: started, stopped, destroyed.'}))
+      return self.REQUEST.response
     try:
       self.restrictedTraverse(self.person_url
         ).requestSoftwareInstance(**request_dict)