ZODB Components: erp5_banking_core: Fix...

ZODB Components: erp5_banking_core: Fix testERP5Banking{AccountingCancellation,BankAccountInventory,CheckDeposit} failures.

BankingOperation monkey patches several ERP5 basic classes to add getBaobab* methods.
With ERP5Banking Product on FS, BankingOperation was imported at Zope startup when
loading Products and monkey patches were applied.

bt5/erp5_banking_core/DocumentTemplateItem/portal_components/document.erp5.BankingOperation.py

@@ -28,20 +28,10 @@
 from AccessControl import ClassSecurityInfo
 from Products.ERP5Type import Permissions, PropertySheet
 from Products.ERP5.Document.Delivery import Delivery
-from Products.ERP5.Document.InventoryLine import InventoryLine
-from Products.ERP5.Document.Movement import Movement
-from Products.ERP5.Document.Container import Container
 from Products.ERP5.Document.AccountingTransaction import AccountingTransaction
-from AccessControl.PermissionRole import PermissionRole
 from Products.ERP5Type.Utils import convertToMixedCase, convertToUpperCase
 from erp5.component.module.BaobabMixin import BaobabMixin
 
-# Import classes to monkey-patch
-# XXX All patches must be moved in a Business Template !!
-from Products.ERP5.Document.Currency import Currency
-from Products.ERP5.Document.DeliveryCell import DeliveryCell
-
-
 class BankingOperation(BaobabMixin, AccountingTransaction):
 
   # CMF Type Definition
@@ -102,161 +92,3 @@ class BankingOperation(BaobabMixin, AccountingTransaction):
     if self.getPortalType()=="Account Transfer":
       self.setReference("posted")
     return self._setPosted(value)
-### Dynamic patch
-Delivery.getBaobabSourceUid = lambda x: x.getSourceUid()
-Delivery.getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabDestinationUid = lambda x: x.getDestinationUid()
-Delivery.getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
-Delivery.getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
-Delivery.getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
-Delivery.getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
-Delivery.getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
-Delivery.getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
-Delivery.getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
-Delivery.getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
-
-Delivery.getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
-Delivery.getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)
-
-### Overload Movement
-Movement.getBaobabSourceUid = lambda x: x.getSourceUid()
-Movement.getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabDestinationUid = lambda x: x.getDestinationUid()
-Movement.getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
-Movement.getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
-Movement.getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
-Movement.getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
-Movement.getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
-Movement.getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
-Movement.getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
-Movement.getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
-
-Movement.getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
-Movement.getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)
-
-### Acquire Baobab source / destination uids from parent line
-DeliveryCell.getBaobabSourceUid = lambda x: x.getSourceUid()
-DeliveryCell.getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabDestinationUid = lambda x: x.getDestinationUid()
-DeliveryCell.getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
-DeliveryCell.getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
-DeliveryCell.getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
-DeliveryCell.getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
-DeliveryCell.getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
-DeliveryCell.getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
-DeliveryCell.getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
-DeliveryCell.getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
-
-DeliveryCell.getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
-DeliveryCell.getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)
-
-
-
-### Dynamic patch
-Container.getBaobabSourceUid = lambda x: x.getSourceUid()
-Container.getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabDestinationUid = lambda x: x.getDestinationUid()
-Container.getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
-Container.getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
-Container.getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
-Container.getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
-Container.getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
-Container.getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
-Container.getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
-Container.getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
-
-Container.getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
-Container.getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)
-
-
-### Dynamic patch
-InventoryLine.getBaobabSourceUid = lambda x: x.getSourceUid()
-InventoryLine.getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabDestinationUid = lambda x: x.getDestinationUid()
-InventoryLine.getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
-InventoryLine.getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
-InventoryLine.getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
-InventoryLine.getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
-InventoryLine.getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
-InventoryLine.getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
-InventoryLine.getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
-InventoryLine.getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
-
-InventoryLine.getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
-InventoryLine.getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)
-

product/ERP5/Document/Container.py

@@ -28,6 +28,7 @@
 ##############################################################################
 
 from AccessControl import ClassSecurityInfo
+from AccessControl.PermissionRole import PermissionRole
 
 from Products.ERP5Type import Permissions, PropertySheet
 from Products.ERP5Type.XMLObject import XMLObject
@@ -197,3 +198,33 @@ class Container(Movement, XMLObject):
       if len(item_uid_list): return item_uid_list
       return (self.getUid(),)
 
+    # XXX: Dirty but required for erp5_banking_core
+    getBaobabSourceUid = lambda x: x.getSourceUid()
+    getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationUid = lambda x: x.getDestinationUid()
+    getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
+    getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
+    getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
+    getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
+    getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
+    getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
+    getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
+    getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
+    getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)

product/ERP5/Document/Delivery.py

@@ -34,6 +34,7 @@ from AccessControl import ClassSecurityInfo
 from AccessControl.SecurityManagement import getSecurityManager, \
     setSecurityManager, newSecurityManager
 from AccessControl.User import nobody
+from AccessControl.PermissionRole import PermissionRole
 from Products.ERP5Type import Permissions, PropertySheet, interfaces
 from Products.ERP5Type.Accessor.Constant import PropertyGetter as ConstantGetter
 from Products.ERP5Type.XMLObject import XMLObject
@@ -853,3 +854,34 @@ class Delivery(XMLObject, ImmobilisationDelivery, SimulableMixin,
           if tester.explain(simulation_movement) not in (None, []):
             divergent_tester_list.append((tester, simulation_movement))
       return divergent_tester_list
+
+    # XXX: Dirty but required for erp5_banking_core
+    getBaobabSourceUid = lambda x: x.getSourceUid()
+    getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationUid = lambda x: x.getDestinationUid()
+    getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
+    getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
+    getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
+    getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
+    getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
+    getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
+    getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
+    getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
+    getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)

product/ERP5/Document/DeliveryCell.py

@@ -31,6 +31,7 @@
 import zope.interface
 
 from AccessControl import ClassSecurityInfo
+from AccessControl.PermissionRole import PermissionRole
 
 from Products.ERP5Type import Permissions, PropertySheet, interfaces
 
@@ -186,3 +187,35 @@ class DeliveryCell(MappedValue, Movement, ImmobilisationMovement):
                                'getQuantityUnit')
     def getQuantityUnit(self, checked_permission=None):
       return self.getParentValue().getQuantityUnit(checked_permission=checked_permission)
+
+    # XXX: Dirty but required for erp5_banking_core
+    ### Acquire Baobab source / destination uids from parent line
+    getBaobabSourceUid = lambda x: x.getSourceUid()
+    getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationUid = lambda x: x.getDestinationUid()
+    getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
+    getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
+    getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
+    getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
+    getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
+    getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
+    getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
+    getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
+    getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)

product/ERP5/Document/InventoryLine.py

@@ -27,6 +27,7 @@
 ##############################################################################
 
 from AccessControl import ClassSecurityInfo
+from AccessControl.PermissionRole import PermissionRole
 from Acquisition import aq_base
 
 from Products.ERP5Type import Permissions, PropertySheet
@@ -113,3 +114,34 @@ class InventoryLine(DeliveryLine):
         Take into account efficiency in converted target quantity
       """
       return Movement.getInventoriatedQuantity(self)
+
+    # XXX: Dirty but required for erp5_banking_core
+    getBaobabSourceUid = lambda x: x.getSourceUid()
+    getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationUid = lambda x: x.getDestinationUid()
+    getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
+    getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
+    getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
+    getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
+    getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
+    getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
+    getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
+    getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
+
+    getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
+    getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)

product/ERP5/Document/Movement.py

@@ -30,6 +30,7 @@
 import zope.interface
 from warnings import warn
 from AccessControl import ClassSecurityInfo
+from AccessControl.PermissionRole import PermissionRole
 
 from Products.ERP5Type import Permissions, PropertySheet, interfaces
 from Products.ERP5Type.Base import Base
@@ -999,3 +1000,33 @@ class Movement(XMLObject, Amount, CompositionMixin, AmountGeneratorMixin):
     """
     return (self, )
 
+  # XXX: Dirty but required for erp5_banking_core
+  getBaobabSourceUid = lambda x: x.getSourceUid()
+  getBaobabSourceUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabDestinationUid = lambda x: x.getDestinationUid()
+  getBaobabDestinationUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabSourceSectionUid = lambda x: x.getSourceSectionUid()
+  getBaobabSourceSectionUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabDestinationSectionUid = lambda x: x.getDestinationSectionUid()
+  getBaobabDestinationSectionUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabSourcePaymentUid = lambda x: x.getSourcePaymentUid()
+  getBaobabSourcePaymentUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabDestinationPaymentUid = lambda x: x.getDestinationPaymentUid()
+  getBaobabDestinationPaymentUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabSourceFunctionUid = lambda x: x.getSourceFunctionUid()
+  getBaobabSourceFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabDestinationFunctionUid = lambda x: x.getDestinationFunctionUid()
+  getBaobabDestinationFunctionUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabSourceProjectUid = lambda x: x.getSourceProjectUid()
+  getBaobabSourceProjectUid__roles__ = PermissionRole(Permissions.View)
+
+  getBaobabDestinationProjectUid = lambda x: x.getDestinationProjectUid()
+  getBaobabDestinationProjectUid__roles__ = PermissionRole(Permissions.View)