Commit da03f209 authored by Nicolas Delaby's avatar Nicolas Delaby

Simplification of boolean evaluation: bool({}) == False

Fix default values for some dictionaries.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@40513 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 6c781b72
...@@ -169,21 +169,21 @@ class ImageFieldWidget(Widget.TextWidget): ...@@ -169,21 +169,21 @@ class ImageFieldWidget(Widget.TextWidget):
if (image_object.getWidth(), image_object.getHeight()) not in \ if (image_object.getWidth(), image_object.getHeight()) not in \
((-1, -1), (0,0)): ((-1, -1), (0,0)):
width, height = image_object._getAspectRatioSize(width, height) width, height = image_object._getAspectRatioSize(width, height)
if draw_frame_node.attrib.get('{%s}width' % SVG_URI, {}) != {} and \ if draw_frame_node.attrib.get('{%s}width' % SVG_URI) and \
draw_frame_node.attrib.get('{%s}height' % SVG_URI, {}) != {}: draw_frame_node.attrib.get('{%s}height' % SVG_URI):
# if a size already exist from attr_dict, try to resize the image to # if a size already exist from attr_dict, try to resize the image to
# fit this size (image should not be biger than size from attr_dict) # fit this size (image should not be biger than size from attr_dict)
# devide the value by 20 to have cm instead of px # devide the value by 20 to have cm instead of px
width, height = self._getPictureSize(width/20., height/20., width, height = self._getPictureSize(width/20., height/20.,
target_width=draw_frame_node.attrib.get('{%s}width' % SVG_URI, {}), target_width=draw_frame_node.attrib.get('{%s}width' % SVG_URI, ''),
target_height=draw_frame_node.attrib.get('{%s}height' % SVG_URI, {})) target_height=draw_frame_node.attrib.get('{%s}height' % SVG_URI, ''))
draw_frame_node.set('{%s}width' % SVG_URI, str(width)) draw_frame_node.set('{%s}width' % SVG_URI, str(width))
draw_frame_node.set('{%s}height' % SVG_URI, str(height)) draw_frame_node.set('{%s}height' % SVG_URI, str(height))
image_tag_name = '{%s}%s' % (DRAW_URI, 'image') image_tag_name = '{%s}%s' % (DRAW_URI, 'image')
image_node = Element(image_tag_name, nsmap=NSMAP) image_node = Element(image_tag_name, nsmap=NSMAP)
image_node.attrib.update(attr_dict.get(image_tag_name, {}).pop()) image_node.attrib.update(attr_dict.get(image_tag_name, []).pop())
image_node.set('{%s}href' % XLINK_URI, picture_path) image_node.set('{%s}href' % XLINK_URI, picture_path)
draw_frame_node.append(image_node) draw_frame_node.append(image_node)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment