Workflow.py: check script before execute script.

product/ERP5Workflow/Document/Workflow.py

@@ -615,13 +615,15 @@ class Workflow(IdAsReferenceMixin("", "prefix"), XMLObject):
     before_script_success = 1
     if tdef is not None and tdef.getBeforeScriptId():
       script_id = tdef.getBeforeScriptId()
-      if script_id:
       script = self._getOb(script_id, None)
+      if script:
         # Pass lots of info to the script in a single parameter.
         if script.getTypeInfo().getId() == 'Workflow Script':
           kwargs = form_kw
           sci = StateChangeInfo(
               document, self, former_status, tdef, old_sdef, new_sdef, kwargs)
+        else:
+          raise NotImplementedError ('Unsupported Script %s for state %s'%(script_id, old_sdef.getReference()))
         try:
           script(sci)  # May throw an exception.
         except ValidationFailed, validation_exc:
@@ -710,14 +712,14 @@ class Workflow(IdAsReferenceMixin("", "prefix"), XMLObject):
     # Execute the "after" script.
     if tdef is not None:
       script_id = getattr(tdef, 'getAfterScriptId')()
-      if script_id is not None:
+      script = self._getOb(script_id, None)
+      if script:
         kwargs = form_kw
         # Script can be either script or workflow method
         if script_id in old_sdef.getDestinationIdList() and \
             self._getOb(script_id).trigger_type == TRIGGER_WORKFLOW_METHOD:
           getattr(document, convertToMixedCase(self._getOb(script_id).getReference()))()
         else:
-          script = self._getOb(script_id)
           # Pass lots of info to the script in a single parameter.
           if script.getTypeInfo().getId() == 'Workflow Script':
             sci = StateChangeInfo(