[Fix] promises could be changed after reject/resolve

browser/rsvp.js

@@ -372,7 +372,8 @@ define("rsvp/promise",
     var noop = function() {};
 
     var Promise = function(resolver) {
-      var promise = this;
+      var promise = this,
+      resolved = false;
 
       if (typeof resolver !== 'function') {
         throw new TypeError('You must pass a resolver function as the sole argument to the promise constructor');
@@ -383,15 +384,15 @@ define("rsvp/promise",
       }
 
       var resolvePromise = function(value) {
+        if (resolved) { return; }
+        resolved = true;
         resolve(promise, value);
-        resolvePromise = noop;
-        rejectPromise = noop;
       };
 
       var rejectPromise = function(value) {
+        if (resolved) { return; }
+        resolved = true;
         reject(promise, value);
-        resolvePromise = noop;
-        rejectPromise = noop;
       };
 
       this.on('promise:resolved', function(event) {

browser/rsvp/promise.amd.js

@@ -8,7 +8,8 @@ define(
     var noop = function() {};
 
     var Promise = function(resolver) {
-      var promise = this;
+      var promise = this,
+      resolved = false;
 
       if (typeof resolver !== 'function') {
         throw new TypeError('You must pass a resolver function as the sole argument to the promise constructor');
@@ -19,15 +20,15 @@ define(
       }
 
       var resolvePromise = function(value) {
+        if (resolved) { return; }
+        resolved = true;
         resolve(promise, value);
-        resolvePromise = noop;
-        rejectPromise = noop;
       };
 
       var rejectPromise = function(value) {
+        if (resolved) { return; }
+        resolved = true;
         reject(promise, value);
-        resolvePromise = noop;
-        rejectPromise = noop;
       };
 
       this.on('promise:resolved', function(event) {

lib/rsvp/promise.js

 import { config } from "rsvp/config";
 import { EventTarget } from "rsvp/events";
 
-var noop = function() {};
-
 var Promise = function(resolver) {
-  var promise = this;
+  var promise = this,
+  resolved = false;
 
   if (typeof resolver !== 'function') {
     throw new TypeError('You must pass a resolver function as the sole argument to the promise constructor');
@@ -15,15 +14,15 @@ var Promise = function(resolver) {
   }
 
   var resolvePromise = function(value) {
+    if (resolved) { return; }
+    resolved = true;
     resolve(promise, value);
-    resolvePromise = noop;
-    rejectPromise = noop;
   };
 
   var rejectPromise = function(value) {
+    if (resolved) { return; }
+    resolved = true;
     reject(promise, value);
-    resolvePromise = noop;
-    rejectPromise = noop;
   };
 
   this.on('promise:resolved', function(event) {

tests/extension-tests.js

@@ -705,12 +705,21 @@ describe("RSVP extensions", function() {
             assert(calledResolved === 0, 'never resolved');
             assert(calledRejected === 1, 'rejected only once');
             assert(error === expectedError, 'rejected promise with x');
-            done();
           });
 
           rejector(expectedError);
           rejector(expectedError);
-          resolver();
+
+          rejector('foo');
+
+          resolver('bar');
+          resolver('baz');
+
+          setTimeout(function(){
+            assert(calledRejected === 1, 'only rejected once');
+            assert(calledResolved === 0, 'never resolved');
+            done();
+          }, 50);
         });
 
         describe("2.3.4 If calling then throws an exception e", function(){