softwaretype recipe: all falsy parameter values are ignored.

23136175 · Cédric de Saint Martin · b5f22b33 · 23136175
Commit 23136175 authored Feb 19, 2013 by Cédric de Saint Martin
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 4 deletions

slapos/recipe/softwaretype.py slapos/recipe/softwaretype.py +8 -4

No files found.
--- a/slapos/recipe/softwaretype.py
+++ b/slapos/recipe/softwaretype.py
@@ -114,10 +114,14 @@ class Recipe:
    if not buildout.has_section('slap-parameter'):
      buildout.add_section('slap-parameter')
    for parameter, value in self.parameter_dict.items():
-      if isinstance(value, str):
+      # All parameters evaluating to False are... False, and shouldn't
-        buildout.set('slap-parameter', parameter, value)
+      # convey any information.
-      else:
+      # Here, all those parameters are set to empty string.
-        buildout.set('slap-parameter', parameter, json.dumps(value))
+      if value:
+        if isinstance(value, str):
+          buildout.set('slap-parameter', parameter, value)
+        else:
+          buildout.set('slap-parameter', parameter, json.dumps(value))
    buildout.add_section('slap-network-information')
    buildout.set('slap-network-information', 'local-ipv4',