From 257974be47006581892b077e589b63d6d95bf23d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Perrin?= <jerome@nexedi.com> Date: Thu, 13 Jan 2022 12:11:51 +0900 Subject: [PATCH] calendar: address pylint warnings also rewrite a sorted to use key instead of cmp --- .../Orgnaisation_generatePlanningDomain.py | 10 +++------- ...eaveRequestReportListboxUntranslatableColumnList.py | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/Orgnaisation_generatePlanningDomain.py b/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/Orgnaisation_generatePlanningDomain.py index 7ee1cd8140..fe6884ec89 100644 --- a/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/Orgnaisation_generatePlanningDomain.py +++ b/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/Orgnaisation_generatePlanningDomain.py @@ -7,19 +7,15 @@ if object_path is None: # Sometimes the object_path not comes with the request, when you edit for example. object_path = request.get('URL1').split('/')[-1] -def sorted(seq, comparator): - new_seq = seq[::] - new_seq.sort(comparator) - return new_seq def display_method(doc): return doc.getTitle() domain_list = [] organisation = context.organisation_module.restrictedTraverse(object_path) -for person in sorted(organisation.getSubordinationRelatedValueList( - portal_type='Person', checked_permission='View'), - lambda a, b: cmp(display_method(a), display_method(b))): +for person in sorted( + organisation.getSubordinationRelatedValueList(portal_type='Person', checked_permission='View'), + key=display_method): domain = parent.generateTempDomain(id=person.getId()) domain.edit(title = display_method(person), membership_criterion_base_category = ('source', 'destination'), diff --git a/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/PersonModule_getLeaveRequestReportListboxUntranslatableColumnList.py b/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/PersonModule_getLeaveRequestReportListboxUntranslatableColumnList.py index fc31134d88..ff4d92fe95 100644 --- a/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/PersonModule_getLeaveRequestReportListboxUntranslatableColumnList.py +++ b/bt5/erp5_calendar/SkinTemplateItem/portal_skins/erp5_calendar/PersonModule_getLeaveRequestReportListboxUntranslatableColumnList.py @@ -1,4 +1,3 @@ -from Products.PythonScripts.standard import Object request = container.REQUEST portal = context.getPortalObject() stool = portal.portal_simulation -- 2.30.9