ERP5Workflow: fix automatic_update value on some configuration workflows

+ raise explicitly when history has empty transition
(this happens when there automatic_update is not true)

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_actor.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_client_id.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_comment.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_configuration_save_url.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_displayed.xml

@@ -36,6 +36,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_error_message.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_time.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_ebusiness_lotse/PathTemplateItem/workflow_module/ebusiness_lotse_configuration_workflow/variable_transition.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_actor.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_client_id.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_comment.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_configuration_save_url.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_displayed.xml

@@ -36,6 +36,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_error_message.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_time.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_run_my_doc/PathTemplateItem/workflow_module/run_my_doc_configuration_workflow/variable_transition.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_actor.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_client_id.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_comment.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_configuration_save_url.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_displayed.xml

@@ -36,6 +36,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_error_message.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_consulting_workflow/variable_transition.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_actor.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_client_id.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_comment.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_configuration_save_url.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_displayed.xml

@@ -36,6 +36,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_error_message.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_time.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_configurator_standard/PathTemplateItem/workflow_module/erp5_standard_workflow/variable_transition.xml

@@ -34,6 +34,10 @@
               <tuple/>
             </value>
         </item>
+        <item>
+            <key> <string>automatic_update</string> </key>
+            <value> <int>1</int> </value>
+        </item>
       </dictionary>
     </pickle>
   </record>

bt5/erp5_upgrader/bt/test_dependency_list

 erp5_full_text_mroonga_catalog
 erp5_base
 erp5_upgrader_test
+erp5_workflow

product/ERP5Configurator/Document/BusinessConfiguration.py

@@ -241,16 +241,20 @@ class BusinessConfiguration(Item):
     """ Render previous form using workflow history. """
     workflow_history = self.getCurrentStateValue().getWorkflowHistory(self, remove_undo=1)
     workflow_history.reverse()
-    for wh in workflow_history:
+    for history_line in workflow_history:
       ## go one step back
       current_state = self.getCurrentStateValue()
       current_state.undoTransition(self)
-      transition = self.unrestrictedTraverse(wh['transition'])
-      conf_save = self.unrestrictedTraverse(wh['configuration_save_url'])
+      if not history_line['transition']:
+        raise ValueError("Empty URL for transition in workflow history.")
+      transition = self.unrestrictedTraverse(history_line['transition'])
+      configuration_save = self.unrestrictedTraverse(
+        history_line['configuration_save_url']
+      )
       ## check if this transition can be shown to user ...
       if transition._checkPermission(self) and \
          transition.getTransitionFormId() is not None:
-        return  self._displayNextForm(context=conf_save, transition=transition)
+        return  self._displayNextForm(context=configuration_save, transition=transition)
 
   security.declarePrivate('_validateNextForm')
   def _validateNextForm(self, **kw):