Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
iv
gitlab-ce
Commits
a7dcf690
Commit
a7dcf690
authored
Aug 15, 2014
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix discussion style for timeline
Signed-off-by:
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
parent
207d798d
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
29 additions
and
28 deletions
+29
-28
app/assets/stylesheets/generic/timeline.scss
app/assets/stylesheets/generic/timeline.scss
+11
-0
app/assets/stylesheets/sections/notes.scss
app/assets/stylesheets/sections/notes.scss
+5
-17
app/views/projects/notes/_diff_notes_with_reply.html.haml
app/views/projects/notes/_diff_notes_with_reply.html.haml
+1
-1
app/views/projects/notes/_discussion.html.haml
app/views/projects/notes/_discussion.html.haml
+12
-7
app/views/projects/notes/discussions/_active.html.haml
app/views/projects/notes/discussions/_active.html.haml
+0
-1
app/views/projects/notes/discussions/_commit.html.haml
app/views/projects/notes/discussions/_commit.html.haml
+0
-1
app/views/projects/notes/discussions/_outdated.html.haml
app/views/projects/notes/discussions/_outdated.html.haml
+0
-1
No files found.
app/assets/stylesheets/generic/timeline.scss
View file @
a7dcf690
...
@@ -21,6 +21,13 @@
...
@@ -21,6 +21,13 @@
clear
:
both
;
clear
:
both
;
&
:target
{
.timeline-entry-inner
.timeline-content
{
-webkit-animation
:target-note
2s
linear
;
background
:
$hover
;
}
}
.timeline-entry-inner
{
.timeline-entry-inner
{
position
:
relative
;
position
:
relative
;
margin-left
:
-20px
;
margin-left
:
-20px
;
...
@@ -37,6 +44,10 @@
...
@@ -37,6 +44,10 @@
float
:
left
;
float
:
left
;
@include
border-radius
(
4px
);
@include
border-radius
(
4px
);
@include
box-shadow
(
0
0
0
3px
#EEE
);
@include
box-shadow
(
0
0
0
3px
#EEE
);
.avatar
{
margin
:
0
;
}
}
}
.timeline-content
{
.timeline-content
{
...
...
app/assets/stylesheets/sections/notes.scss
View file @
a7dcf690
...
@@ -17,7 +17,6 @@ ul.notes {
...
@@ -17,7 +17,6 @@ ul.notes {
.discussion-header
,
.discussion-header
,
.note-header
{
.note-header
{
@extend
.cgray
;
@extend
.cgray
;
padding-top
:
5px
;
padding-bottom
:
15px
;
padding-bottom
:
15px
;
.avatar
{
.avatar
{
...
@@ -43,25 +42,15 @@ ul.notes {
...
@@ -43,25 +42,15 @@ ul.notes {
}
}
.discussion
{
.discussion
{
padding
:
10px
0
;
overflow
:
hidden
;
overflow
:
hidden
;
display
:
block
;
display
:
block
;
position
:relative
;
position
:relative
;
border-bottom
:
1px
solid
#EEE
;
.discussion-body
{
margin-left
:
50px
;
}
}
}
.note
{
.note
{
display
:
block
;
display
:
block
;
position
:relative
;
position
:relative
;
p
{
color
:
$style_color
;
}
p
{
color
:
$style_color
;
}
.avatar
{
margin
:
0
;
}
.attachment
{
.attachment
{
font-size
:
14px
;
font-size
:
14px
;
}
}
...
@@ -76,11 +65,6 @@ ul.notes {
...
@@ -76,11 +65,6 @@ ul.notes {
border-bottom
:
none
;
border-bottom
:
none
;
}
}
}
}
.note
:target
{
-webkit-animation
:target-note
2s
linear
;
background
:
#fffff0
;
}
}
}
.diff-file
.notes_holder
{
.diff-file
.notes_holder
{
...
@@ -95,7 +79,7 @@ ul.notes {
...
@@ -95,7 +79,7 @@ ul.notes {
&
.notes_line
{
&
.notes_line
{
text-align
:
center
;
text-align
:
center
;
padding
:
10px
0
;
padding
:
10px
0
;
background
:
#
eee
;
background
:
#
FFF
;
}
}
&
.notes_line2
{
&
.notes_line2
{
text-align
:
center
;
text-align
:
center
;
...
@@ -358,3 +342,7 @@ ul.notes {
...
@@ -358,3 +342,7 @@ ul.notes {
border-top
:
1px
solid
#DDD
;
border-top
:
1px
solid
#DDD
;
}
}
}
}
.discussion-notes-count
{
font-size
:
16px
;
}
app/views/projects/notes/_diff_notes_with_reply.html.haml
View file @
a7dcf690
...
@@ -3,7 +3,7 @@
...
@@ -3,7 +3,7 @@
-
if
!
defined?
(
line
)
||
line
==
note
.
diff_line
-
if
!
defined?
(
line
)
||
line
==
note
.
diff_line
%tr
.notes_holder
%tr
.notes_holder
%td
.notes_line
{
colspan:
2
}
%td
.notes_line
{
colspan:
2
}
%span
.
btn.disabled
%span
.
discussion-notes-count
%i
.icon-comment
%i
.icon-comment
=
notes
.
count
=
notes
.
count
%td
.notes_content
%td
.notes_content
...
...
app/views/projects/notes/_discussion.html.haml
View file @
a7dcf690
-
note
=
discussion_notes
.
first
-
note
=
discussion_notes
.
first
-
if
note
.
for_merge_request?
.timeline-entry
-
if
note
.
outdated?
.timeline-entry-inner
=
render
"projects/notes/discussions/outdated"
,
discussion_notes:
discussion_notes
.timeline-icon
-
else
=
image_tag
avatar_icon
(
note
.
author_email
),
class:
"avatar s32"
=
render
"projects/notes/discussions/active"
,
discussion_notes:
discussion_notes
.timeline-content
-
else
-
if
note
.
for_merge_request?
=
render
"projects/notes/discussions/commit"
,
discussion_notes:
discussion_notes
-
if
note
.
outdated?
=
render
"projects/notes/discussions/outdated"
,
discussion_notes:
discussion_notes
-
else
=
render
"projects/notes/discussions/active"
,
discussion_notes:
discussion_notes
-
else
=
render
"projects/notes/discussions/commit"
,
discussion_notes:
discussion_notes
app/views/projects/notes/discussions/_active.html.haml
View file @
a7dcf690
...
@@ -5,7 +5,6 @@
...
@@ -5,7 +5,6 @@
=
link_to
"#"
,
class:
"js-toggle-button"
do
=
link_to
"#"
,
class:
"js-toggle-button"
do
%i
.icon-chevron-up
%i
.icon-chevron-up
Show/hide discussion
Show/hide discussion
=
image_tag
avatar_icon
(
note
.
author_email
),
class:
"avatar s32"
%div
%div
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
started a discussion
started a discussion
...
...
app/views/projects/notes/discussions/_commit.html.haml
View file @
a7dcf690
...
@@ -5,7 +5,6 @@
...
@@ -5,7 +5,6 @@
=
link_to
"#"
,
class:
"js-toggle-button"
do
=
link_to
"#"
,
class:
"js-toggle-button"
do
%i
.icon-chevron-up
%i
.icon-chevron-up
Show/hide discussion
Show/hide discussion
=
image_tag
avatar_icon
(
note
.
author_email
),
class:
"avatar s32"
%div
%div
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
started a discussion on commit
started a discussion on commit
...
...
app/views/projects/notes/discussions/_outdated.html.haml
View file @
a7dcf690
...
@@ -5,7 +5,6 @@
...
@@ -5,7 +5,6 @@
=
link_to
"#"
,
class:
"js-toggle-button"
do
=
link_to
"#"
,
class:
"js-toggle-button"
do
%i
.icon-chevron-down
%i
.icon-chevron-down
Show/hide discussion
Show/hide discussion
=
image_tag
avatar_icon
(
note
.
author_email
),
class:
"avatar s32"
%div
%div
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
=
link_to_member
(
@project
,
note
.
author
,
avatar:
false
)
started a discussion on the
started a discussion on the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment