Merge branch 'dz-nicer-sidebar' into 'master'

Improves left static sidebar behaviour

List of changes:

* removed bottom 50px space that is no longer necessary with pin button at the top
* increased side padding so sidebar links are closer to counters
* use fixed weight pin icon so it correctly aligned with counters


cc @annabeldunstone @jschatz1 

See merge request !5251

app/assets/stylesheets/framework/sidebar.scss

@@ -55,10 +55,6 @@
   overflow-y: auto;
   overflow-x: hidden;
 
-  @media (min-width: $sidebar-breakpoint) {
-    bottom: 50px;
-  }
-
   &.navbar-collapse {
     padding: 0 !important;
   }
@@ -76,7 +72,7 @@
     }
 
     a {
-      padding: 7px 16px;
+      padding: 7px $gl-sidebar-padding;
       font-size: $gl-font-size;
       line-height: 24px;
       display: block;
@@ -143,7 +139,7 @@
 }
 
 .nav-header-btn {
-  padding: 10px 16px;
+  padding: 10px $gl-sidebar-padding;
   color: inherit;
   transition-duration: .3s;
   position: absolute;

app/assets/stylesheets/framework/variables.scss

@@ -64,6 +64,7 @@ $gl-btn-padding: 10px;
 $gl-input-padding: 10px;
 $gl-vert-padding: 6px;
 $gl-padding-top: 10px;
+$gl-sidebar-padding: 22px;
 
 /*
  * Misc

app/views/layouts/_page.html.haml

@@ -6,7 +6,7 @@
         = icon('bars')
       = link_to '#', class: "nav-header-btn pin-nav-btn has-tooltip #{'is-active' if pinned_nav?} js-nav-pin", title: pinned_nav? ? "Unpin navigation" : "Pin Navigation", data: {placement: 'right', container: 'body'} do
         %span.sr-only Toggle navigation pinning
-        = icon('thumb-tack')
+        = icon('fw thumb-tack')
 
     - if defined?(sidebar) && sidebar
       = render "layouts/nav/#{sidebar}"