- 04 May, 2016 17 commits
-
-
Rémy Coutable authored
Update patch_versions.md with explicit --with statement for db gem group ## What does this MR do? Updates `patch_versions.md`'s instructions on installing gems to explicitly install either the postgres or mysql groups. ## Are there points in the code the reviewer needs to double check? No, but thank you for your time. ## Why was this MR needed? I performed the steps listed in `patch_versions.md` and ran the command for updating postgres gems. Bundler told me at the end that it had not installed the postgres gem group, which caused the next step, migrating the DB, to fail for obvious reasons. Changing the command to `--with postgres` made it install the postgres gem group, and db:migrate then passed. ## What are the relevant issue numbers? None ## Screenshots (if relevant) N/A See merge request !3955
-
Douwe Maan authored
# Conflicts: # Gemfile.lock
-
Douwe Maan authored
feature proposal issue template in contributing guide This adds a feature proposal template to the contribution guidelines for internal and external use. Fixes #15448 cc @markpundsack @stanhu @dzaporozhets See merge request !3967
-
Rémy Coutable authored
Enable LstripRstrip cop This requires no code changes since it doesn't actually change anything in the codebase, just preventative. See merge request !3959
-
Yorick Peterse authored
Instrument methods used in email diffs See merge request !4038
-
Rémy Coutable authored
Remove unnecessary method call in events view Since `User#to_param` already returns `User#username`, we don't need to pass in the user's username. Changing this also helps us obey LoD. See merge request !3996
-
Douwe Maan authored
Initialize wikis on legacy projects during check Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/4173 Helps https://gitlab.com/gitlab-org/gitlab-ce/issues/15423 See merge request !3931
-
Rémy Coutable authored
Revert "Remove the Devise Async gem." This reverts commit 1cc614f2. It was causing the ActiveJob integration to fail, so unfortunately we'll have to add the gem again. Resolves #17250. See merge request !4027
-
Douwe Maan authored
Improve uniqueness of field names on the signup form Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15075 See merge request !3826
-
Sean McGivern authored
Make all of the nested constant instrumentation for core app code work the same way, add mailer instrumentation, and add instrumentation to the premailer gem.
-
Yorick Peterse authored
Fixed username links in the performance guide See merge request !4036
-
Yorick Peterse authored
These would end up being rendered as: <a href="...">@yorickpeterse</a> <a href="...">@yorickpeterse</a> [ci skip]
-
Rémy Coutable authored
Fix a spec that was failing due to !3483 Spec were skipped in this MR so that tests started to fail in master instead of in this MR! /cc @connorshea @rspeicher See merge request !4033
-
Rémy Coutable authored
Spec were skipped in this MR so that tests started to fail in master instead of in this MR! Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Achilleas Pipinellis authored
Made it clearer that issue_id means iid, not id. See merge request !4030
-
Aral Balkan authored
-
Robert Speicher authored
Use sign out path only if not empty Fixes: https://github.com/gitlabhq/gitlabhq/issues/10066 See merge request !3989
-
- 03 May, 2016 15 commits
-
-
Robert Speicher authored
Update rspec-rails from 3.3.3 to 3.4.2. This allows the removal of the monkey patch from this commit: 47ff1c56 It'll also make it slightly easier to upgrade to 3.5.0 later. Changelog: https://github.com/rspec/rspec-rails/blob/master/Changelog.md#340--2015-11-11 See merge request !3999
-
Robert Speicher authored
Link to GitLab code review guide in contributing guidelines I noticed that the contributing guidelines still link to the thoughtbot code review guidelines even though we already have our own. [ci skip] See merge request !4018
-
Connor Shea authored
This reverts commit 1cc614f2. It was causing the ActiveJob integration to fail, so unfortunately we'll have to add the gem again.
-
Artem Sidorenko authored
-
Robert Speicher authored
Improve the Two-factor Authentication sign-in text [ci skip] Resolves #14543. See merge request !3483
-
connorshea authored
Resolves #14543.
-
Achilleas Pipinellis authored
Add clear instructions on installing the pg_trgm extension Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/17191 See merge request !4025
-
Achilleas Pipinellis authored
[ci skip]
-
Achilleas Pipinellis authored
Added performance guidelines Fixes #15254 #14277 See merge request !3303
-
Achilleas Pipinellis authored
[ci skip]
-
Yorick Peterse authored
Updated CHANGELOG for 8.7.2 See merge request !4021
-
Robert Speicher authored
[ci skip]
-
Yorick Peterse authored
[ci skip]
-
Karlo Soriano authored
I noticed that the contributing guidelines still link to the thoughtbot code review guidelines even though we already have our own. [ci skip]
-
Robert Speicher authored
[ci skip]
-
- 02 May, 2016 8 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
Support e-mail notifications for comments on project snippets While working with project snippets recently, I noticed that notifications would not be sent out for comments on notes. This MR fixes this. Note: I'm not completely sure why `ProjectSnippets#participants` returns an empty array if you don't include the concern that is already in `Snippets` but didn't dig into it any more. Closes #2334 See merge request !3987
-
Stan Hu authored
Closes #2334
-
Robert Speicher authored
Fix error when trying to create a wiki page Closes #15527, #15569, #15623, #15630, #15637, #15653, #15870, #16558, #16875, #16987, #17016, https://github.com/gitlabhq/gitlabhq/issues/10317. See merge request !3924
-
Robert Speicher authored
Fix "remember me" sign in option Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/4006 Prior to this change, 'remember me' was effectively always on because the `_gitlab_session` cookie was always made persistent. With this change it becomes possible again to have `_gitlab_session`be a session cookie when 'remember me' is unchecked. See merge request !4004
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Speicher authored
Remove duplicate entry in the CHANGELOG [ci skip] See merge request !4002
-
Jacob Vosmaer authored
-