https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13200997

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13198105

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13198953

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13199055

So we no longer join anything, just find the latest pipeline
and load builds from there to avoid mixing builds.

Thanks Kamil for the help and tests.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195683
and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195692

another_artifacts was no longer used and then there's no point to
put let in outer scope anymore.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195672

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195632

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195632

this should properly test that it's really getting the
builds from the latest successful pipelines and latest
successful builds.

also added a test for checking this.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173599

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173653

rubocop was complaining

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13176921

Also we give undesired builds another artifacts so that we could tell
if returned artifacts was we actual expected.

Merge remote-tracking branch 'upstream/artifacts-from-ref-and-build-name-api-kamil' into artifacts-from-ref-and-build-name-api

* upstream/artifacts-from-ref-and-build-name-api-kamil:
  Make minimal changes to specs

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173313

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13176885

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173842

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173871

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173404

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173445

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173429

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173368
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173370

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173345

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173336

let! is not very flexible but I guess it's fine since this is not in
top-level anyway.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173304

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173284

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13170854

* master: (23 commits)
  Add CHANGELOG entry [ci skip]
  CHANGELOG item
  Added redirect_to_referer to login link on issues
  Simplify entities for branches and tags API
  Added Rake task for tracking deployments
  Return the number of marked todos
  Use local_assigns
  Use `humanize`
  Improve code design
  Remove unused create_pipeline_service_spec.rb
  Add notice implementation
  Make manual actions to work with master code
  Use `capitalize` instead of `titleize` for manual actions
  Mark builds with manual actions as skipped
  Fix rubocop offenses
  Update build fixtures to include manual actions
  Improve manual actions code and add model, service and feature tests
  Rename playable_actions to manual_actions
  Add implementation of manual actions
  Position commit icons closer to branch name/tag/sha; add min-width to pipeline actions cell
  ...