trial balance bug

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_getTrialBalanceReportSectionList.py

@@ -41,7 +41,8 @@ request.set('precision', precision)
 node_uid = []
 gap_uid_list = []
 for gap in request.get('gap_list', ()):
-  gap_uid_list.append(portal.portal_categories.gap.restrictedTraverse(gap).getUid())
+  if gap:
+    gap_uid_list.append(portal.portal_categories.gap.restrictedTraverse(gap).getUid())
 if gap_uid_list:
   node_uid = [x.uid for x in portal.portal_catalog(
                                    portal_type='Account',

bt5/erp5_accounting/TestTemplateItem/portal_components/test.erp5.testAccountingReports.py

@@ -3467,6 +3467,34 @@ class TestAccountingReports(AccountingTestCase, ERP5ReportTestCase):
         credit=300, final_debit_balance=2100, final_credit_balance=300,
         final_balance_if_debit=1800, final_balance_if_credit=0)
 
+  def testTrialBalanceGAPFilterEmptyItemSelected(self):
+    # Test of GAP filter on trial balance, when empty item is selected in gap_list
+    # this should not apply filter.
+    self.createAccountStatementDataSet()
+
+    # set request variables and render
+    request_form = self.portal.REQUEST.form
+    request_form['from_date'] = DateTime(2006, 1, 1)
+    request_form['at_date'] = DateTime(2006, 2, 2)
+    request_form['section_category'] = 'group/demo_group'
+    request_form['section_category_strict'] = False
+    request_form['simulation_state'] = ['delivered']
+    request_form['show_empty_accounts'] = 0
+    request_form['expand_accounts'] = 1
+    # the field has an empty item
+    request_form['gap_list'] = ['']
+    request_form['per_account_class_summary'] = 0
+    request_form['group_analytic'] = []
+    request_form['show_detailed_balance_columns'] = 1
+
+    report_section_list = self.getReportSectionList(
+                                    self.portal.accounting_module,
+                                    'AccountModule_viewTrialBalanceReport')
+    self.assertEqual(1, len(report_section_list))
+    line_list = self.getListBoxLineList(report_section_list[0])
+    data_line_list = [l for l in line_list if l.isDataLine()]
+
+    self.assertEqual(6, len(data_line_list))
 
   def testTrialBalanceAccountClassSummary(self):
     # Test of trial balance with per "account class" summary