Commit 084dde9e authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'dz-revert-revert' into 'master'

Revert "Revert "Change "Group#web_url" to return "/groups/twitter" rather than "/twitter".""

Looks like I accidently reverted https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7035 although I did not want to . This MR reverts my revert.

See merge request !7127
parents b3210df3 3be445c5
...@@ -68,7 +68,7 @@ class Group < Namespace ...@@ -68,7 +68,7 @@ class Group < Namespace
end end
def web_url def web_url
Gitlab::Routing.url_helpers.group_url(self) Gitlab::Routing.url_helpers.group_canonical_url(self)
end end
def human_name def human_name
......
...@@ -12,7 +12,8 @@ constraints(GroupUrlConstrainer.new) do ...@@ -12,7 +12,8 @@ constraints(GroupUrlConstrainer.new) do
end end
end end
resources :groups, constraints: { id: /[a-zA-Z.0-9_\-]+(?<!\.atom)/ } do scope constraints: { id: /[a-zA-Z.0-9_\-]+(?<!\.atom)/ } do
resources :groups, except: [:show] do
member do member do
get :issues get :issues
get :merge_requests get :merge_requests
...@@ -31,4 +32,6 @@ resources :groups, constraints: { id: /[a-zA-Z.0-9_\-]+(?<!\.atom)/ } do ...@@ -31,4 +32,6 @@ resources :groups, constraints: { id: /[a-zA-Z.0-9_\-]+(?<!\.atom)/ } do
resources :labels, except: [:show], constraints: { id: /\d+/ } resources :labels, except: [:show], constraints: { id: /\d+/ }
end end
end
get 'groups/:id' => 'groups#show', as: :group_canonical
end end
...@@ -265,4 +265,10 @@ describe Group, models: true do ...@@ -265,4 +265,10 @@ describe Group, models: true do
members members
end end
describe '#web_url' do
it 'returns the canonical URL' do
expect(group.web_url).to include("groups/#{group.name}")
end
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment