Be more lenient on build coverage value updates and fix specs

1c24c79a · Leandro Camargo · 441a9bee · 1c24c79a · 1c24c79a
Commit 1c24c79a authored Jan 25, 2017 by Leandro Camargo
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

app/models/ci/build.rb app/models/ci/build.rb +1 -1

spec/lib/gitlab/import_export/safe_model_attributes.yml spec/lib/gitlab/import_export/safe_model_attributes.yml +1 -0

No files found.
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -276,7 +276,7 @@ module Ci

    def update_coverage
      coverage = extract_coverage(trace, coverage_regex)
-      update_attributes(coverage: coverage) if coverage.is_a?(Numeric)
+      update_attributes(coverage: coverage) if coverage.present?
    end

    def extract_coverage(text, regex)

--- a/spec/lib/gitlab/import_export/safe_model_attributes.yml
+++ b/spec/lib/gitlab/import_export/safe_model_attributes.yml
@@ -222,6 +222,7 @@ CommitStatus:
 - queued_at
 - token
 - lock_version
+- coverage_regex
 Ci::Variable:
 - id
 - project_id