Commit 279ffe7b authored by Stan Hu's avatar Stan Hu

Merge branch 'sh-optimize-label-finder' into 'master'

Reduce overhead of LabelFinder by avoiding #presence call

Some users experienced 502 timeouts when viewing group labels.
Labels#open_issues_count and Label#open_merge_requests_count were
taking a long time to load because they were loading every ActiveRecord
of the user-accessible projects into memory. This change modifies so
that only the IDs are loaded into memory.

Closes #23684

See merge request !7094
parents 9c7b371a ed47f4a3
...@@ -22,6 +22,7 @@ Please view this file on the master branch, on stable branches it's out of date. ...@@ -22,6 +22,7 @@ Please view this file on the master branch, on stable branches it's out of date.
- Fix reply-by-email not working due to queue name mismatch - Fix reply-by-email not working due to queue name mismatch
- Fixed hidden pipeline graph on commit and MR page !6895 - Fixed hidden pipeline graph on commit and MR page !6895
- Expire and build repository cache after project import - Expire and build repository cache after project import
- Reduce overhead of LabelFinder by avoiding #presence call !7094
- Fix 404 for group pages when GitLab setup uses relative url - Fix 404 for group pages when GitLab setup uses relative url
- Simpler arguments passed to named_route on toggle_award_url helper method - Simpler arguments passed to named_route on toggle_award_url helper method
- Fix unauthorized users dragging on issue boards - Fix unauthorized users dragging on issue boards
......
...@@ -50,7 +50,7 @@ class LabelsFinder < UnionFinder ...@@ -50,7 +50,7 @@ class LabelsFinder < UnionFinder
end end
def projects_ids def projects_ids
params[:project_ids].presence params[:project_ids]
end end
def title def title
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment