Added resolvable discussion frontend

app/assets/javascripts/comment_type_toggle.js

+import DropLab from '@gitlab-org/droplab';
+import InputSetter from '@gitlab-org/droplab/dist/plugins/InputSetter';
+
+class CommentTypeToggle {
+  constructor(trigger, list, input, button, secondaryButton) {
+    this.trigger = trigger;
+    this.list = list;
+    this.input = input;
+    this.button = button;
+    this.secondaryButton = secondaryButton;
+  }
+
+  initDroplab() {
+    this.droplab = new DropLab();
+    this.droplab.init(this.trigger, this.list, [InputSetter], {
+      InputSetter: [{
+        input: this.input,
+        valueAttribute: 'data-value',
+      },
+      {
+        input: this.button,
+        valueAttribute: 'data-button-text',
+      },
+      {
+        input: this.secondaryButton,
+        valueAttribute: 'data-secondary-button-text',
+      }],
+    });
+  }
+}
+
+export default CommentTypeToggle;

app/assets/javascripts/gl_form.js

@@ -3,6 +3,8 @@
 /* global DropzoneInput */
 /* global autosize */
 
+import CommentTypeToggle from './comment_type_toggle';
+
 window.gl = window.gl || {};
 
 function GLForm(form) {
@@ -41,6 +43,20 @@ GLForm.prototype.setupForm = function() {
   this.form.find('.js-note-discard').hide();
   this.form.show();
   if (this.isAutosizeable) this.setupAutosize();
+
+  this.initCommentTypeToggle();
+};
+
+GLForm.prototype.initCommentTypeToggle = function () {
+  this.commentTypeToggle = new CommentTypeToggle(
+    this.form[0].querySelector('.js-comment-type-dropdown .dropdown-toggle'),
+    this.form[0].querySelector('.js-comment-type-dropdown .dropdown-menu'),
+    document.getElementById('note_type'),
+    this.form[0].querySelector('.js-comment-type-dropdown .js-comment-submit-button'),
+    document.querySelector('.js-note-target-close'),
+  );
+
+  this.commentTypeToggle.initDroplab();
 };
 
 GLForm.prototype.setupAutosize = function () {

app/assets/javascripts/notes.js

@@ -452,7 +452,7 @@ require('./task_list');
       form.addClass("js-main-target-form");
       form.find("#note_line_code").remove();
       form.find("#note_position").remove();
-      form.find("#note_type").remove();
+      form.find("#note_type").val('');
       form.find("#in_reply_to_discussion_id").remove();
       form.find('.js-comment-resolve-button').closest('comment-and-resolve-btn').remove();
       return this.parentTimeline = form.parents('.timeline');

app/assets/stylesheets/pages/note_form.scss

@@ -310,3 +310,58 @@
     margin-bottom: 10px;
   }
 }
+
+.comment-type-dropdown {
+  .dropdown-toggle .fa {
+    color: $white-light;
+    padding-right: 2px;
+    margin-top: 2px;
+    pointer-events: none;
+  }
+
+  .dropdown-menu {
+    top: initial;
+    bottom: 40px;
+    width: 297px;
+  }
+
+  .description {
+    display: inline-block;
+    white-space: normal;
+    margin-left: 8px;
+    padding-right: 33px;
+  }
+
+  li {
+    white-space: nowrap;
+    border-radius: 0;
+    cursor: pointer;
+    padding-top: 6px;
+
+    &:hover,
+    &:focus {
+      background-color: $dropdown-hover-color;
+      color: $white-light;
+    }
+
+    &.droplab-item-selected i {
+      visibility: visible;
+    }
+
+    i {
+      visibility: hidden;
+    }
+  }
+
+  i {
+    display: inline-block;
+    vertical-align: top;
+    padding-top: 2px;
+  }
+
+  .divider {
+    margin: 0 8px;
+    padding: 0;
+    border-top: $gray-darkest;
+  }
+}

app/views/projects/notes/_form.html.haml

@@ -28,10 +28,23 @@
     .error-alert
 
   .note-form-actions.clearfix
-    = f.submit 'Comment', class: "btn btn-nr btn-create append-right-10 comment-btn js-comment-button"
-
-    - if @note.can_be_discussion_note?
-      = submit_tag 'Start discussion', name: 'new_discussion', class: "btn btn-nr append-right-10 btn-inverted js-note-new-discussion"
+    .btn-group.append-right-10.comment-type-dropdown.js-comment-type-dropdown
+      = f.submit 'Comment', class: "btn btn-nr btn-create comment-btn js-comment-button js-comment-submit-button"
+      - if @note.can_be_discussion_note?
+        = button_tag type: 'button', class: 'btn btn-nr dropdown-toggle comment-btn js-comment-button js-note-new-discussion', data: { 'dropdown-trigger' => '#resolvable-comment-menu' } do
+          = icon('caret-down')
+        %ul#resolvable-comment-menu.dropdown-menu{ data: { dropdown: true } }
+          %li#comment{ data: { value: '', 'button-text' => 'Comment', 'secondary-button-text' => 'Comment & close merge request' }, class: 'droplab-item-selected' }
+            = icon('check')
+            .description
+              %strong Comment
+              %p Add a general comment to this merge request.
+          %li.divider
+          %li#discussion{ data: { value: 'DiscussionNote', 'button-text' => 'Start discussion', 'secondary-button-text' => 'Start discussion & close merge request' } }
+            = icon('check')
+            .description
+              %strong Start discussion
+              %p Discuss a specific suggestion or question that needs to be resolved.
 
     = yield(:note_actions)
 

spec/javascripts/comment_type_toggle_spec.js

+import CommentTypeToggle from '~/comment_type_toggle';
+import DropLab from '@gitlab-org/droplab';
+import InputSetter from '@gitlab-org/droplab/dist/plugins/InputSetter';
+
+describe('CommentTypeToggle', function () {
+  describe('class constructor', function () {
+    beforeEach(function () {
+      this.trigger = {};
+      this.list = {};
+      this.input = {};
+      this.button = {};
+
+      this.commentTypeToggle = new CommentTypeToggle(
+        this.trigger,
+        this.list,
+        this.input,
+        this.button,
+      );
+    });
+
+    it('should set .trigger', function () {
+      expect(this.commentTypeToggle.trigger).toBe(this.trigger);
+    });
+
+    it('should set .list', function () {
+      expect(this.commentTypeToggle.list).toBe(this.list);
+    });
+
+    it('should set .input', function () {
+      expect(this.commentTypeToggle.input).toBe(this.input);
+    });
+
+    it('should set .button', function () {
+      expect(this.commentTypeToggle.button).toBe(this.button);
+    });
+  });
+
+  describe('initDroplab', function () {
+    beforeEach(function () {
+      this.commentTypeToggle = {
+        trigger: {},
+        list: {},
+        input: {},
+        button: {},
+      };
+
+      this.droplab = jasmine.createSpyObj('droplab', ['addHook']);
+
+      spyOn(window, 'DropLab').and.returnValue(this.droplab);
+
+      this.initDroplab = CommentTypeToggle.prototype.initDroplab.call(this.commentTypeToggle);
+    });
+
+    it('should instantiate a DropLab instance', function () {
+      expect(window.DropLab).toHaveBeenCalled();
+    });
+
+    it('should set .droplab', function () {
+      expect(this.commentTypeToggle.droplab).toBe(this.droplab);
+    });
+
+    it('should call DropLab.prototype.addHook', function () {
+      expect(this.droplab.addHook).toHaveBeenCalledWith(
+        this.commentTypeToggle.trigger,
+        this.commentTypeToggle.list,
+        [InputSetter],
+        {
+          InputSetter: [{
+            input: this.commentTypeToggle.input,
+            valueAttribute: 'data-value',
+          }, {
+            input: this.commentTypeToggle.button,
+            valueAttribute: 'data-button-text',
+          }],
+        },
+      );
+    });
+  });
+});