Commit 639cfdc2 authored by Phil Hughes's avatar Phil Hughes

Merge branch '36906_Reordering_issues_to_the_bottom' into 'master'

Fixing re-ordering of an issue when dragging it to the bottom a long issue list in the board

Closes #36906

See merge request gitlab-org/gitlab-ce!16250
parents d2d634a9 9452fd2b
...@@ -187,7 +187,7 @@ export default { ...@@ -187,7 +187,7 @@ export default {
<li <li
class="board-list-count text-center" class="board-list-count text-center"
v-if="showCount" v-if="showCount"
data-id="-1"> data-issue-id="-1">
<loading-icon <loading-icon
v-show="list.loadingMore" v-show="list.loadingMore"
......
---
title: "Issue board: fix for dragging an issue to the very bottom in long lists"
merge_request: 16250
author: David Kuri
type: fixed
\ No newline at end of file
...@@ -154,6 +154,18 @@ describe('Board list component', () => { ...@@ -154,6 +154,18 @@ describe('Board list component', () => {
}); });
}); });
it('sets data attribute with invalid id', (done) => {
component.showCount = true;
Vue.nextTick(() => {
expect(
component.$el.querySelector('.board-list-count').getAttribute('data-issue-id'),
).toBe('-1');
done();
});
});
it('shows how many more issues to load', (done) => { it('shows how many more issues to load', (done) => {
component.showCount = true; component.showCount = true;
component.list.issuesSize = 20; component.list.issuesSize = 20;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment