Commit 63dbcd24 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '42206-permit-password-for-git-param' into 'master'

Resolve "Password authentication enabled for Git over HTTP(S) can not be disabled via UI"

Closes #42206

See merge request gitlab-org/gitlab-ce!16577
parents 5fb13c81 6dcba97c
...@@ -201,6 +201,7 @@ module ApplicationSettingsHelper ...@@ -201,6 +201,7 @@ module ApplicationSettingsHelper
:metrics_sample_interval, :metrics_sample_interval,
:metrics_timeout, :metrics_timeout,
:password_authentication_enabled_for_web, :password_authentication_enabled_for_web,
:password_authentication_enabled_for_git,
:performance_bar_allowed_group_id, :performance_bar_allowed_group_id,
:performance_bar_enabled, :performance_bar_enabled,
:plantuml_enabled, :plantuml_enabled,
......
---
title: Permits 'password_authentication_enabled_for_git' parameter for ApplicationSettingsController
merge_request:
author:
type: fixed
...@@ -51,6 +51,13 @@ describe Admin::ApplicationSettingsController do ...@@ -51,6 +51,13 @@ describe Admin::ApplicationSettingsController do
sign_in(admin) sign_in(admin)
end end
it 'updates the password_authentication_enabled_for_git setting' do
put :update, application_setting: { password_authentication_enabled_for_git: "0" }
expect(response).to redirect_to(admin_application_settings_path)
expect(ApplicationSetting.current.password_authentication_enabled_for_git).to eq(false)
end
it 'updates the default_project_visibility for string value' do it 'updates the default_project_visibility for string value' do
put :update, application_setting: { default_project_visibility: "20" } put :update, application_setting: { default_project_visibility: "20" }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment