Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
65747107
Commit
65747107
authored
Aug 11, 2016
by
Douwe Maan
Committed by
Fatih Acet
Aug 12, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix bug where merge widget wouldn't show up after resolving conflicts
parent
c1514624
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
2 deletions
+8
-2
app/views/projects/merge_requests/widget/_open.html.haml
app/views/projects/merge_requests/widget/_open.html.haml
+8
-2
No files found.
app/views/projects/merge_requests/widget/_open.html.haml
View file @
65747107
.mr-state-widget
.mr-state-widget
=
render
'projects/merge_requests/widget/heading'
=
render
'projects/merge_requests/widget/heading'
.mr-widget-body
.mr-widget-body
-# After conflicts are resolved, the user is redirected back to the MR page.
-# There is a short window before background workers run and GitLab processes
-# the new push and commits, during which it will think the conflicts still exist.
-# We send this param to get the widget to treat the MR as having no more conflicts.
-
resolved_conflicts
=
params
[
:resolved_conflicts
]
-
if
@project
.
archived?
-
if
@project
.
archived?
=
render
'projects/merge_requests/widget/open/archived'
=
render
'projects/merge_requests/widget/open/archived'
-
elsif
@merge_request
.
commits
.
blank?
-
elsif
@merge_request
.
commits
.
blank?
...
@@ -9,7 +15,7 @@
...
@@ -9,7 +15,7 @@
=
render
'projects/merge_requests/widget/open/missing_branch'
=
render
'projects/merge_requests/widget/open/missing_branch'
-
elsif
@merge_request
.
unchecked?
-
elsif
@merge_request
.
unchecked?
=
render
'projects/merge_requests/widget/open/check'
=
render
'projects/merge_requests/widget/open/check'
-
elsif
@merge_request
.
cannot_be_merged?
&&
!
params
[
:resolved_conflicts
]
-
elsif
@merge_request
.
cannot_be_merged?
&&
!
resolved_conflicts
=
render
'projects/merge_requests/widget/open/conflicts'
=
render
'projects/merge_requests/widget/open/conflicts'
-
elsif
@merge_request
.
work_in_progress?
-
elsif
@merge_request
.
work_in_progress?
=
render
'projects/merge_requests/widget/open/wip'
=
render
'projects/merge_requests/widget/open/wip'
...
@@ -19,7 +25,7 @@
...
@@ -19,7 +25,7 @@
=
render
'projects/merge_requests/widget/open/not_allowed'
=
render
'projects/merge_requests/widget/open/not_allowed'
-
elsif
!
@merge_request
.
mergeable_ci_state?
&&
@pipeline
&&
@pipeline
.
failed?
-
elsif
!
@merge_request
.
mergeable_ci_state?
&&
@pipeline
&&
@pipeline
.
failed?
=
render
'projects/merge_requests/widget/open/build_failed'
=
render
'projects/merge_requests/widget/open/build_failed'
-
elsif
@merge_request
.
can_be_merged?
-
elsif
@merge_request
.
can_be_merged?
||
resolved_conflicts
=
render
'projects/merge_requests/widget/open/accept'
=
render
'projects/merge_requests/widget/open/accept'
-
if
mr_closes_issues
.
present?
-
if
mr_closes_issues
.
present?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment