Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
68e9372a
Commit
68e9372a
authored
Sep 05, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'master' into breadcrumbs-improvements
parents
df35410a
d0f5b3c2
Changes
39
Show whitespace changes
Inline
Side-by-side
Showing
39 changed files
with
360 additions
and
155 deletions
+360
-155
.gitlab-ci.yml
.gitlab-ci.yml
+1
-1
README.md
README.md
+1
-0
app/assets/javascripts/project.js
app/assets/javascripts/project.js
+0
-4
app/assets/javascripts/project_select.js
app/assets/javascripts/project_select.js
+0
-42
app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.js
...s/vue_merge_request_widget/components/mr_widget_header.js
+6
-4
app/assets/stylesheets/framework/selects.scss
app/assets/stylesheets/framework/selects.scss
+1
-0
app/controllers/concerns/issuable_collections.rb
app/controllers/concerns/issuable_collections.rb
+28
-0
app/controllers/projects/issues_controller.rb
app/controllers/projects/issues_controller.rb
+2
-3
app/controllers/projects/merge_requests_controller.rb
app/controllers/projects/merge_requests_controller.rb
+2
-3
app/finders/issuable_finder.rb
app/finders/issuable_finder.rb
+4
-0
app/helpers/issuables_helper.rb
app/helpers/issuables_helper.rb
+2
-1
app/views/layouts/nav/_new_dashboard.html.haml
app/views/layouts/nav/_new_dashboard.html.haml
+2
-2
app/views/layouts/project.html.haml
app/views/layouts/project.html.haml
+0
-8
app/views/projects/issues/_issues.html.haml
app/views/projects/issues/_issues.html.haml
+1
-1
app/views/projects/merge_requests/_merge_requests.html.haml
app/views/projects/merge_requests/_merge_requests.html.haml
+1
-1
changelogs/unreleased/35010-remove-goto-project-from-breadcrumb.yml
.../unreleased/35010-remove-goto-project-from-breadcrumb.yml
+5
-0
changelogs/unreleased/36821-fix-new-nav-wrapping-caret-and-increasing-height.yml
...6821-fix-new-nav-wrapping-caret-and-increasing-height.yml
+5
-0
changelogs/unreleased/37331-button-MR-widget.yml
changelogs/unreleased/37331-button-MR-widget.yml
+5
-0
changelogs/unreleased/feature-dependency-status-badge.yml
changelogs/unreleased/feature-dependency-status-badge.yml
+5
-0
changelogs/unreleased/mr-index-page-performance.yml
changelogs/unreleased/mr-index-page-performance.yml
+5
-0
doc/user/permissions.md
doc/user/permissions.md
+22
-23
lib/gitlab/issuables_count_for_state.rb
lib/gitlab/issuables_count_for_state.rb
+50
-0
lib/tasks/gettext.rake
lib/tasks/gettext.rake
+2
-1
spec/controllers/concerns/issuable_collections_spec.rb
spec/controllers/concerns/issuable_collections_spec.rb
+82
-0
spec/finders/issues_finder_spec.rb
spec/finders/issues_finder_spec.rb
+16
-2
spec/finders/merge_requests_finder_spec.rb
spec/finders/merge_requests_finder_spec.rb
+14
-0
spec/javascripts/projects_dropdown/service/projects_service_spec.js
...cripts/projects_dropdown/service/projects_service_spec.js
+3
-11
spec/lib/gitlab/issuables_count_for_state_spec.rb
spec/lib/gitlab/issuables_count_for_state_spec.rb
+37
-0
vendor/gitignore/Global/JetBrains.gitignore
vendor/gitignore/Global/JetBrains.gitignore
+1
-1
vendor/gitignore/Haskell.gitignore
vendor/gitignore/Haskell.gitignore
+1
-0
vendor/gitignore/Prestashop.gitignore
vendor/gitignore/Prestashop.gitignore
+3
-1
vendor/gitignore/Smalltalk.gitignore
vendor/gitignore/Smalltalk.gitignore
+4
-0
vendor/gitignore/Symfony.gitignore
vendor/gitignore/Symfony.gitignore
+3
-0
vendor/gitignore/VisualStudio.gitignore
vendor/gitignore/VisualStudio.gitignore
+1
-1
vendor/gitlab-ci-yml/Go.gitlab-ci.yml
vendor/gitlab-ci-yml/Go.gitlab-ci.yml
+15
-17
vendor/gitlab-ci-yml/Gradle.gitlab-ci.yml
vendor/gitlab-ci-yml/Gradle.gitlab-ci.yml
+19
-24
vendor/gitlab-ci-yml/Laravel.gitlab-ci.yml
vendor/gitlab-ci-yml/Laravel.gitlab-ci.yml
+4
-0
vendor/gitlab-ci-yml/PHP.gitlab-ci.yml
vendor/gitlab-ci-yml/PHP.gitlab-ci.yml
+3
-0
vendor/gitlab-ci-yml/Ruby.gitlab-ci.yml
vendor/gitlab-ci-yml/Ruby.gitlab-ci.yml
+4
-4
No files found.
.gitlab-ci.yml
View file @
68e9372a
...
...
@@ -212,7 +212,6 @@ update-tests-metadata:
flaky-examples-check
:
<<
:
*dedicated-runner
<<
:
*except-docs
image
:
ruby:2.3-alpine
services
:
[]
before_script
:
[]
...
...
@@ -227,6 +226,7 @@ flaky-examples-check:
-
branches
except
:
-
master
-
/(^docs[\/-].*|.*-docs$)/
artifacts
:
expire_in
:
30d
paths
:
...
...
README.md
View file @
68e9372a
...
...
@@ -2,6 +2,7 @@
[
![Build status
](
https://gitlab.com/gitlab-org/gitlab-ce/badges/master/build.svg
)
](https://gitlab.com/gitlab-org/gitlab-ce/commits/master)
[
![Overall test coverage
](
https://gitlab.com/gitlab-org/gitlab-ce/badges/master/coverage.svg
)
](https://gitlab.com/gitlab-org/gitlab-ce/pipelines)
[
![Dependency Status
](
https://gemnasium.com/gitlabhq/gitlabhq.svg
)
](https://gemnasium.com/gitlabhq/gitlabhq)
[
![Code Climate
](
https://codeclimate.com/github/gitlabhq/gitlabhq.svg
)
](https://codeclimate.com/github/gitlabhq/gitlabhq)
[
![Core Infrastructure Initiative Best Practices
](
https://bestpractices.coreinfrastructure.org/projects/42/badge
)
](https://bestpractices.coreinfrastructure.org/projects/42)
[
![Gitter
](
https://badges.gitter.im/gitlabhq/gitlabhq.svg
)
](https://gitter.im/gitlabhq/gitlabhq?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
...
...
app/assets/javascripts/project.js
View file @
68e9372a
...
...
@@ -53,10 +53,6 @@ import Cookies from 'js-cookie';
return
_this
.
changeProject
(
$
(
e
.
currentTarget
).
val
());
};
})(
this
));
return
$
(
'
.js-projects-dropdown-toggle
'
).
on
(
'
click
'
,
function
(
e
)
{
e
.
preventDefault
();
return
$
(
'
.js-projects-dropdown
'
).
select2
(
'
open
'
);
});
};
Project
.
prototype
.
changeProject
=
function
(
url
)
{
...
...
app/assets/javascripts/project_select.js
View file @
68e9372a
...
...
@@ -5,48 +5,6 @@ import ProjectSelectComboButton from './project_select_combo_button';
(
function
()
{
this
.
ProjectSelect
=
(
function
()
{
function
ProjectSelect
()
{
$
(
'
.js-projects-dropdown-toggle
'
).
each
(
function
(
i
,
dropdown
)
{
var
$dropdown
;
$dropdown
=
$
(
dropdown
);
return
$dropdown
.
glDropdown
({
filterable
:
true
,
filterRemote
:
true
,
search
:
{
fields
:
[
'
name_with_namespace
'
]
},
data
:
function
(
term
,
callback
)
{
var
finalCallback
,
projectsCallback
;
var
orderBy
=
$dropdown
.
data
(
'
order-by
'
);
finalCallback
=
function
(
projects
)
{
return
callback
(
projects
);
};
if
(
this
.
includeGroups
)
{
projectsCallback
=
function
(
projects
)
{
var
groupsCallback
;
groupsCallback
=
function
(
groups
)
{
var
data
;
data
=
groups
.
concat
(
projects
);
return
finalCallback
(
data
);
};
return
Api
.
groups
(
term
,
{},
groupsCallback
);
};
}
else
{
projectsCallback
=
finalCallback
;
}
if
(
this
.
groupId
)
{
return
Api
.
groupProjects
(
this
.
groupId
,
term
,
projectsCallback
);
}
else
{
return
Api
.
projects
(
term
,
{
order_by
:
orderBy
},
projectsCallback
);
}
},
url
:
function
(
project
)
{
return
project
.
web_url
;
},
text
:
function
(
project
)
{
return
project
.
name_with_namespace
;
}
});
});
$
(
'
.ajax-project-select
'
).
each
(
function
(
i
,
select
)
{
var
placeholder
;
this
.
groupId
=
$
(
select
).
data
(
'
group-id
'
);
...
...
app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.js
View file @
68e9372a
...
...
@@ -75,18 +75,20 @@ export default {
class="btn btn-small inline">
Check out branch
</a>
<span class="dropdown
inline
prepend-left-10">
<span class="dropdown prepend-left-10">
<a
class="btn btn-
xs
dropdown-toggle"
class="btn btn-
small inline
dropdown-toggle"
data-toggle="dropdown"
aria-label="Download as"
role="button">
<i
class="fa fa-download"
aria-hidden="true" />
aria-hidden="true">
</i>
<i
class="fa fa-caret-down"
aria-hidden="true" />
aria-hidden="true">
</i>
</a>
<ul class="dropdown-menu dropdown-menu-align-right">
<li>
...
...
app/assets/stylesheets/framework/selects.scss
View file @
68e9372a
...
...
@@ -267,6 +267,7 @@
// TODO: change global style
.ajax-project-dropdown
,
.ajax-users-dropdown
,
body
[
data-page
=
"projects:edit"
]
#select2-drop
,
body
[
data-page
=
"projects:new"
]
#select2-drop
,
body
[
data-page
=
"projects:merge_requests:edit"
]
#select2-drop
,
...
...
app/controllers/concerns/issuable_collections.rb
View file @
68e9372a
...
...
@@ -36,6 +36,34 @@ module IssuableCollections
@merge_requests_finder
||=
issuable_finder_for
(
MergeRequestsFinder
)
end
def
redirect_out_of_range
(
relation
,
total_pages
)
return
false
if
total_pages
.
zero?
out_of_range
=
relation
.
current_page
>
total_pages
if
out_of_range
redirect_to
(
url_for
(
params
.
merge
(
page:
total_pages
,
only_path:
true
)))
end
out_of_range
end
def
issues_page_count
(
relation
)
page_count_for_relation
(
relation
,
issues_finder
.
row_count
)
end
def
merge_requests_page_count
(
relation
)
page_count_for_relation
(
relation
,
merge_requests_finder
.
row_count
)
end
def
page_count_for_relation
(
relation
,
row_count
)
limit
=
relation
.
limit_value
.
to_f
return
1
if
limit
.
zero?
(
row_count
.
to_f
/
limit
).
ceil
end
def
issuable_finder_for
(
finder_class
)
finder_class
.
new
(
current_user
,
filter_params
)
end
...
...
app/controllers/projects/issues_controller.rb
View file @
68e9372a
...
...
@@ -27,10 +27,9 @@ class Projects::IssuesController < Projects::ApplicationController
@issues
=
issues_collection
@issues
=
@issues
.
page
(
params
[
:page
])
@issuable_meta_data
=
issuable_meta_data
(
@issues
,
@collection_type
)
@total_pages
=
issues_page_count
(
@issues
)
if
@issues
.
out_of_range?
&&
@issues
.
total_pages
!=
0
return
redirect_to
url_for
(
params
.
merge
(
page:
@issues
.
total_pages
,
only_path:
true
))
end
return
if
redirect_out_of_range
(
@issues
,
@total_pages
)
if
params
[
:label_name
].
present?
@labels
=
LabelsFinder
.
new
(
current_user
,
project_id:
@project
.
id
,
title:
params
[
:label_name
]).
execute
...
...
app/controllers/projects/merge_requests_controller.rb
View file @
68e9372a
...
...
@@ -18,10 +18,9 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
@merge_requests
=
@merge_requests
.
page
(
params
[
:page
])
@merge_requests
=
@merge_requests
.
preload
(
merge_request_diff: :merge_request
)
@issuable_meta_data
=
issuable_meta_data
(
@merge_requests
,
@collection_type
)
@total_pages
=
merge_requests_page_count
(
@merge_requests
)
if
@merge_requests
.
out_of_range?
&&
@merge_requests
.
total_pages
!=
0
return
redirect_to
url_for
(
params
.
merge
(
page:
@merge_requests
.
total_pages
,
only_path:
true
))
end
return
if
redirect_out_of_range
(
@merge_requests
,
@total_pages
)
if
params
[
:label_name
].
present?
labels_params
=
{
project_id:
@project
.
id
,
title:
params
[
:label_name
]
}
...
...
app/finders/issuable_finder.rb
View file @
68e9372a
...
...
@@ -61,6 +61,10 @@ class IssuableFinder
execute
.
find_by
(
*
params
)
end
def
row_count
Gitlab
::
IssuablesCountForState
.
new
(
self
).
for_state_or_opened
(
params
[
:state
])
end
# We often get counts for each state by running a query per state, and
# counting those results. This is typically slower than running one query
# (even if that query is slower than any of the individual state queries) and
...
...
app/helpers/issuables_helper.rb
View file @
68e9372a
...
...
@@ -249,7 +249,8 @@ module IssuablesHelper
def
issuables_count_for_state
(
issuable_type
,
state
)
finder
=
public_send
(
"
#{
issuable_type
}
_finder"
)
# rubocop:disable GitlabSecurity/PublicSend
finder
.
count_by_state
[
state
]
Gitlab
::
IssuablesCountForState
.
new
(
finder
)[
state
]
end
def
close_issuable_url
(
issuable
)
...
...
app/views/layouts/nav/_new_dashboard.html.haml
View file @
68e9372a
...
...
@@ -10,7 +10,7 @@
=
link_to
dashboard_groups_path
,
class:
'dashboard-shortcuts-groups'
,
title:
'Groups'
do
Groups
=
nav_link
(
path:
'dashboard#activity'
,
html_options:
{
class:
"hidden-xs hidden-sm"
})
do
=
nav_link
(
path:
'dashboard#activity'
,
html_options:
{
class:
"hidden-xs hidden-sm
hidden-md
"
})
do
=
link_to
activity_dashboard_path
,
class:
'dashboard-shortcuts-activity'
,
title:
'Activity'
do
Activity
...
...
@@ -20,7 +20,7 @@
=
icon
(
"chevron-down"
,
class:
"dropdown-chevron"
)
.dropdown-menu
%ul
=
nav_link
(
path:
'dashboard#activity'
,
html_options:
{
class:
"visible-xs visible-sm"
})
do
=
nav_link
(
path:
'dashboard#activity'
,
html_options:
{
class:
"visible-xs visible-sm
visible-md
"
})
do
=
link_to
activity_dashboard_path
,
title:
'Activity'
do
Activity
...
...
app/views/layouts/project.html.haml
View file @
68e9372a
...
...
@@ -14,12 +14,4 @@
:javascript
window
.
uploads_path
=
"
#{
project_uploads_path
(
project
)
}
"
;
-
content_for
:header_content
do
.js-dropdown-menu-projects
.dropdown-menu.dropdown-select.dropdown-menu-projects
=
dropdown_title
(
"Go to a project"
)
=
dropdown_filter
(
"Search your projects"
)
=
dropdown_content
=
dropdown_loading
=
render
template:
"layouts/application"
app/views/projects/issues/_issues.html.haml
View file @
68e9372a
...
...
@@ -4,4 +4,4 @@
=
render
'shared/empty_states/issues'
-
if
@issues
.
present?
=
paginate
@issues
,
theme:
"gitlab"
=
paginate
@issues
,
theme:
"gitlab"
,
total_pages:
@total_pages
app/views/projects/merge_requests/_merge_requests.html.haml
View file @
68e9372a
...
...
@@ -5,4 +5,4 @@
=
render
'shared/empty_states/merge_requests'
-
if
@merge_requests
.
present?
=
paginate
@merge_requests
,
theme:
"gitlab"
=
paginate
@merge_requests
,
theme:
"gitlab"
,
total_pages:
@total_pages
changelogs/unreleased/35010-remove-goto-project-from-breadcrumb.yml
0 → 100644
View file @
68e9372a
---
title
:
Remove project select dropdown from breadcrumb
merge_request
:
14010
author
:
type
:
changed
changelogs/unreleased/36821-fix-new-nav-wrapping-caret-and-increasing-height.yml
0 → 100644
View file @
68e9372a
---
title
:
Fix new navigation wrapping and causing height to grow
merge_request
:
author
:
type
:
fixed
changelogs/unreleased/37331-button-MR-widget.yml
0 → 100644
View file @
68e9372a
---
title
:
Fix buttons with different height in merge request widget
merge_request
:
author
:
type
:
fixed
changelogs/unreleased/feature-dependency-status-badge.yml
0 → 100644
View file @
68e9372a
---
title
:
Add badge for dependency status
merge_request
:
13588
author
:
Markus Koller
type
:
other
changelogs/unreleased/mr-index-page-performance.yml
0 → 100644
View file @
68e9372a
---
title
:
Re-use issue/MR counts for the pagination system
merge_request
:
author
:
type
:
other
doc/user/permissions.md
View file @
68e9372a
...
...
@@ -21,16 +21,16 @@ The following table depicts the various user permission levels in a project.
| Action | Guest | Reporter | Developer | Master | Owner |
|---------------------------------------|---------|------------|-------------|----------|--------|
| Create new issue | ✓
| ✓ | ✓ | ✓ | ✓ |
| Create confidential issue | ✓
| ✓ | ✓ | ✓ | ✓ |
| View confidential issues | (✓) [^
1
] | ✓ | ✓ | ✓ | ✓ |
| Leave comments | ✓
| ✓ | ✓ | ✓ | ✓ |
| See a list of jobs | ✓ [^
2
] | ✓ | ✓ | ✓ | ✓ |
| See a job log | ✓ [^
2
] | ✓ | ✓ | ✓ | ✓ |
| Download and browse job artifacts | ✓ [^
2
] | ✓ | ✓ | ✓ | ✓ |
| View wiki pages | ✓
| ✓ | ✓ | ✓ | ✓ |
| Pull project code |
| ✓ | ✓ | ✓ | ✓ |
| Download project |
| ✓ | ✓ | ✓ | ✓ |
| Create new issue | ✓
[^1]
| ✓ | ✓ | ✓ | ✓ |
| Create confidential issue | ✓
[^1]
| ✓ | ✓ | ✓ | ✓ |
| View confidential issues | (✓) [^
2
] | ✓ | ✓ | ✓ | ✓ |
| Leave comments | ✓
[^1]
| ✓ | ✓ | ✓ | ✓ |
| See a list of jobs | ✓ [^
3
] | ✓ | ✓ | ✓ | ✓ |
| See a job log | ✓ [^
3
] | ✓ | ✓ | ✓ | ✓ |
| Download and browse job artifacts | ✓ [^
3
] | ✓ | ✓ | ✓ | ✓ |
| View wiki pages | ✓
[^1]
| ✓ | ✓ | ✓ | ✓ |
| Pull project code |
[^1]
| ✓ | ✓ | ✓ | ✓ |
| Download project |
[^1]
| ✓ | ✓ | ✓ | ✓ |
| Create code snippets | | ✓ | ✓ | ✓ | ✓ |
| Manage issue tracker | | ✓ | ✓ | ✓ | ✓ |
| Manage labels | | ✓ | ✓ | ✓ | ✓ |
...
...
@@ -71,8 +71,8 @@ The following table depicts the various user permission levels in a project.
| Switch visibility level | | | | | ✓ |
| Transfer project to another namespace | | | | | ✓ |
| Remove project | | | | | ✓ |
| Force push to protected branches [^
3
] | | | | | |
| Remove protected branches [^
3
] | | | | | |
| Force push to protected branches [^
4
] | | | | | |
| Remove protected branches [^
4
] | | | | | |
| Remove pages | | | | | ✓ |
## Project features permissions
...
...
@@ -215,13 +215,13 @@ users:
| Run CI job | | ✓ | ✓ | ✓ |
| Clone source and LFS from current project | | ✓ | ✓ | ✓ |
| Clone source and LFS from public projects | | ✓ | ✓ | ✓ |
| Clone source and LFS from internal projects | | ✓ [^
4] | ✓ [^4
] | ✓ |
| Clone source and LFS from private projects | | ✓ [^
5] | ✓ [^5] | ✓ [^5
] |
| Clone source and LFS from internal projects | | ✓ [^
5] | ✓ [^5
] | ✓ |
| Clone source and LFS from private projects | | ✓ [^
6] | ✓ [^6] | ✓ [^6
] |
| Push source and LFS | | | | |
| Pull container images from current project | | ✓ | ✓ | ✓ |
| Pull container images from public projects | | ✓ | ✓ | ✓ |
| Pull container images from internal projects| | ✓ [^
4] | ✓ [^4
] | ✓ |
| Pull container images from private projects | | ✓ [^
5] | ✓ [^5] | ✓ [^5
] |
| Pull container images from internal projects| | ✓ [^
5] | ✓ [^5
] | ✓ |
| Pull container images from private projects | | ✓ [^
6] | ✓ [^6] | ✓ [^6
] |
| Push container images to current project | | ✓ | ✓ | ✓ |
| Push container images to other projects | | | | |
...
...
@@ -243,12 +243,11 @@ with the permissions described on the documentation on [auditor users permission
Auditor users are available in
[
GitLab Enterprise Edition Premium
](
https://about.gitlab.com/gitlab-ee/
)
only.
----
[
^1
]:
Guest
users can only view the confidential issues they created themselves
[
^2
]:
If
**Public pipelines**
is enabled in
**Project Settings > Pipelines**
[
^3
]:
Not
allowed for Guest, Reporter, Developer, Master, or Owner
[
^4
]:
Only
if user is not external one.
[
^5
]:
Only
if user is a member of the project.
[
^1
]:
On
public and internal projects, all users are able to perform this action.
[
^2
]:
Guest
users can only view the confidential issues they created themselves
[
^3
]:
If
**Public pipelines**
is enabled in
**Project Settings > Pipelines**
[
^4
]:
Not
allowed for Guest, Reporter, Developer, Master, or Owner
[
^5
]:
Only
if user is not external one.
[
^6
]:
Only
if user is a member of the project.
[
ce-18994
]:
https://gitlab.com/gitlab-org/gitlab-ce/issues/18994
[
new-mod
]:
project/new_ci_build_permissions_model.md
lib/gitlab/issuables_count_for_state.rb
0 → 100644
View file @
68e9372a
module
Gitlab
# Class for counting and caching the number of issuables per state.
class
IssuablesCountForState
# The name of the RequestStore cache key.
CACHE_KEY
=
:issuables_count_for_state
# The state values that can be safely casted to a Symbol.
STATES
=
%w[opened closed merged all]
.
freeze
# finder - The finder class to use for retrieving the issuables.
def
initialize
(
finder
)
@finder
=
finder
@cache
=
if
RequestStore
.
active?
RequestStore
[
CACHE_KEY
]
||=
initialize_cache
else
initialize_cache
end
end
def
for_state_or_opened
(
state
=
nil
)
self
[
state
||
:opened
]
end
# Returns the count for the given state.
#
# state - The name of the state as either a String or a Symbol.
#
# Returns an Integer.
def
[]
(
state
)
state
=
state
.
to_sym
if
cast_state_to_symbol?
(
state
)
cache_for_finder
[
state
]
||
0
end
private
def
cache_for_finder
@cache
[
@finder
]
end
def
cast_state_to_symbol?
(
state
)
state
.
is_a?
(
String
)
&&
STATES
.
include?
(
state
)
end
def
initialize_cache
Hash
.
new
{
|
hash
,
finder
|
hash
[
finder
]
=
finder
.
count_by_state
}
end
end
end
lib/tasks/gettext.rake
View file @
68e9372a
require
"gettext_i18n_rails/tasks"
require
'simple_po_parser'
namespace
:gettext
do
# Customize list of translatable files
...
...
@@ -23,6 +22,8 @@ namespace :gettext do
desc
'Lint all po files in `locale/'
task
lint: :environment
do
require
'simple_po_parser'
FastGettext
.
silence_errors
files
=
Dir
.
glob
(
Rails
.
root
.
join
(
'locale/*/gitlab.po'
))
...
...
spec/controllers/concerns/issuable_collections_spec.rb
0 → 100644
View file @
68e9372a
require
'spec_helper'
describe
IssuableCollections
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:controller
)
do
klass
=
Class
.
new
do
def
self
.
helper_method
(
name
);
end
include
IssuableCollections
end
controller
=
klass
.
new
allow
(
controller
).
to
receive
(
:params
).
and_return
(
state:
'opened'
)
controller
end
describe
'#redirect_out_of_range'
do
before
do
allow
(
controller
).
to
receive
(
:url_for
)
end
it
'returns true and redirects if the offset is out of range'
do
relation
=
double
(
:relation
,
current_page:
10
)
expect
(
controller
).
to
receive
(
:redirect_to
)
expect
(
controller
.
send
(
:redirect_out_of_range
,
relation
,
2
)).
to
eq
(
true
)
end
it
'returns false if the offset is not out of range'
do
relation
=
double
(
:relation
,
current_page:
1
)
expect
(
controller
).
not_to
receive
(
:redirect_to
)
expect
(
controller
.
send
(
:redirect_out_of_range
,
relation
,
2
)).
to
eq
(
false
)
end
end
describe
'#issues_page_count'
do
it
'returns the number of issue pages'
do
project
=
create
(
:project
,
:public
)
create
(
:issue
,
project:
project
)
finder
=
IssuesFinder
.
new
(
user
)
issues
=
finder
.
execute
allow
(
controller
).
to
receive
(
:issues_finder
)
.
and_return
(
finder
)
expect
(
controller
.
send
(
:issues_page_count
,
issues
)).
to
eq
(
1
)
end
end
describe
'#merge_requests_page_count'
do
it
'returns the number of merge request pages'
do
project
=
create
(
:project
,
:public
)
create
(
:merge_request
,
source_project:
project
,
target_project:
project
)
finder
=
MergeRequestsFinder
.
new
(
user
)
merge_requests
=
finder
.
execute
allow
(
controller
).
to
receive
(
:merge_requests_finder
)
.
and_return
(
finder
)
pages
=
controller
.
send
(
:merge_requests_page_count
,
merge_requests
)
expect
(
pages
).
to
eq
(
1
)
end
end
describe
'#page_count_for_relation'
do
it
'returns the number of pages'
do
relation
=
double
(
:relation
,
limit_value:
20
)
pages
=
controller
.
send
(
:page_count_for_relation
,
relation
,
28
)
expect
(
pages
).
to
eq
(
2
)
end
end
end
spec/finders/issues_finder_spec.rb
View file @
68e9372a
...
...
@@ -15,8 +15,8 @@ describe IssuesFinder do
set
(
:award_emoji3
)
{
create
(
:award_emoji
,
name:
'thumbsdown'
,
user:
user
,
awardable:
issue3
)
}
describe
'#execute'
do
set
(
:closed_issue
)
{
create
(
:issue
,
author:
user2
,
assignees:
[
user2
],
project:
project2
,
state:
'closed'
)
}
set
(
:label_link
)
{
create
(
:label_link
,
label:
label
,
target:
issue2
)
}
let!
(
:closed_issue
)
{
create
(
:issue
,
author:
user2
,
assignees:
[
user2
],
project:
project2
,
state:
'closed'
)
}
let!
(
:label_link
)
{
create
(
:label_link
,
label:
label
,
target:
issue2
)
}
let
(
:search_user
)
{
user
}
let
(
:params
)
{
{}
}
let
(
:issues
)
{
described_class
.
new
(
search_user
,
params
.
reverse_merge
(
scope:
scope
,
state:
'opened'
)).
execute
}
...
...
@@ -347,6 +347,20 @@ describe IssuesFinder do
end
end
describe
'#row_count'
,
:request_store
do
it
'returns the number of rows for the default state'
do
finder
=
described_class
.
new
(
user
)
expect
(
finder
.
row_count
).
to
eq
(
3
)
end
it
'returns the number of rows for a given state'
do
finder
=
described_class
.
new
(
user
,
state:
'closed'
)
expect
(
finder
.
row_count
).
to
be_zero
end
end
describe
'#with_confidentiality_access_check'
do
let
(
:guest
)
{
create
(
:user
)
}
set
(
:authorized_user
)
{
create
(
:user
)
}
...
...
spec/finders/merge_requests_finder_spec.rb
View file @
68e9372a
...
...
@@ -108,4 +108,18 @@ describe MergeRequestsFinder do
end
end
end
describe
'#row_count'
,
:request_store
do
it
'returns the number of rows for the default state'
do
finder
=
described_class
.
new
(
user
)
expect
(
finder
.
row_count
).
to
eq
(
3
)
end
it
'returns the number of rows for a given state'
do
finder
=
described_class
.
new
(
user
,
state:
'closed'
)
expect
(
finder
.
row_count
).
to
eq
(
1
)
end
end
end
spec/javascripts/projects_dropdown/service/projects_service_spec.js
View file @
68e9372a
...
...
@@ -12,21 +12,13 @@ FREQUENT_PROJECTS.MAX_COUNT = 3;
describe
(
'
ProjectsService
'
,
()
=>
{
let
service
;
let
originalGon
;
beforeEach
(()
=>
{
originalGon
=
window
.
gon
;
window
.
gon
=
Object
.
assign
({},
{
api_version
:
currentSession
.
apiVersion
,
});
gon
.
api_version
=
currentSession
.
apiVersion
;
gon
.
current_user_id
=
1
;
service
=
new
ProjectsService
(
currentSession
.
username
);
});
afterEach
(()
=>
{
window
.
gon
=
originalGon
;
});
describe
(
'
contructor
'
,
()
=>
{
it
(
'
should initialize default properties of class
'
,
()
=>
{
expect
(
service
.
isLocalStorageAvailable
).
toBeTruthy
();
...
...
@@ -44,7 +36,7 @@ describe('ProjectsService', () => {
const
queryParams
=
{
simple
:
false
,
per_page
:
20
,
membership
:
fals
e
,
membership
:
tru
e
,
order_by
:
'
last_activity_at
'
,
search
:
searchQuery
,
};
...
...
spec/lib/gitlab/issuables_count_for_state_spec.rb
0 → 100644
View file @
68e9372a
require
'spec_helper'
describe
Gitlab
::
IssuablesCountForState
do
let
(
:finder
)
do
double
(
:finder
,
count_by_state:
{
opened:
2
,
closed:
1
})
end
let
(
:counter
)
{
described_class
.
new
(
finder
)
}
describe
'#for_state_or_opened'
do
it
'returns the number of issuables for the given state'
do
expect
(
counter
.
for_state_or_opened
(
:closed
)).
to
eq
(
1
)
end
it
'returns the number of open issuables when no state is given'
do
expect
(
counter
.
for_state_or_opened
).
to
eq
(
2
)
end
it
'returns the number of open issuables when a nil value is given'
do
expect
(
counter
.
for_state_or_opened
(
nil
)).
to
eq
(
2
)
end
end
describe
'#[]'
do
it
'returns the number of issuables for the given state'
do
expect
(
counter
[
:closed
]).
to
eq
(
1
)
end
it
'casts valid states from Strings to Symbols'
do
expect
(
counter
[
'closed'
]).
to
eq
(
1
)
end
it
'returns 0 when using an invalid state name as a String'
do
expect
(
counter
[
'kittens'
]).
to
be_zero
end
end
end
vendor/gitignore/Global/JetBrains.gitignore
View file @
68e9372a
...
...
@@ -31,7 +31,7 @@ cmake-build-debug/
## Plugin-specific files:
# IntelliJ
/
out/
out/
# mpeltonen/sbt-idea plugin
.idea_modules/
...
...
vendor/gitignore/Haskell.gitignore
View file @
68e9372a
...
...
@@ -18,3 +18,4 @@ cabal.sandbox.config
.stack-work/
cabal.project.local
.HTF/
.ghc.environment.*
vendor/gitignore/Prestashop.gitignore
View file @
68e9372a
...
...
@@ -7,8 +7,10 @@ config/settings.*.php
# The following files are generated by PrestaShop.
admin-dev/autoupgrade/
/cache/
/cache/
*
!/cache/index.php
!/cache/*/
/cache/*/*
!/cache/cachefs/index.php
!/cache/purifier/index.php
!/cache/push/index.php
...
...
vendor/gitignore/Smalltalk.gitignore
View file @
68e9372a
...
...
@@ -13,6 +13,10 @@ SqueakDebug.log
# Monticello package cache
/package-cache
# playground cache
/play-cache
/play-stash
# Metacello-github cache
/github-cache
github-*.zip
vendor/gitignore/Symfony.gitignore
View file @
68e9372a
...
...
@@ -39,3 +39,6 @@
# Backup entities generated with doctrine:generate:entities command
**/Entity/*~
# Embedded web-server pid file
/.web-server-pid
vendor/gitignore/VisualStudio.gitignore
View file @
68e9372a
...
...
@@ -151,7 +151,7 @@ publish/
# Publish Web Output
*.[Pp]ublish.xml
*.azurePubxml
#
TODO: Comment the next line if you want to checkin your web deploy settings
#
Note: Comment the next line if you want to checkin your web deploy settings,
# but database connection strings (with potential passwords) will be unencrypted
*.pubxml
*.publishproj
...
...
vendor/gitlab-ci-yml/Go.gitlab-ci.yml
View file @
68e9372a
image
:
golang:latest
variables
:
# Please edit to your GitLab project
REPO_NAME
:
gitlab.com/namespace/project
# The problem is that to be able to use go get, one needs to put
# the repository in the $GOPATH. So for example if your gitlab domain
# is
mydomainperso.com, and that your repository is repos/projectname
, and
# is
gitlab.com, and that your repository is namespace/project
, and
# the default GOPATH being /go, then you'd need to have your
# repository in /go/src/
mydomainperso.com/repos/projectname
# repository in /go/src/
gitlab.com/namespace/project
# Thus, making a symbolic link corrects this.
before_script
:
-
ln -s /builds /go/src/mydomainperso.com
-
cd /go/src/mydomainperso.com/repos/projectname
-
mkdir -p $GOPATH/src/$REPO_NAME
-
ln -svf $CI_PROJECT_DIR/* $GOPATH/src/$REPO_NAME
-
cd $GOPATH/src/$REPO_NAME
stages
:
-
test
...
...
@@ -17,20 +22,13 @@ stages:
format
:
stage
:
test
script
:
# Add here all the dependencies, or use glide/govendor to get
# them automatically.
# - curl https://glide.sh/get | sh
-
go get github.com/alecthomas/kingpin
-
go tool vet -composites=false -shadow=true *.go
-
go fmt $(go list ./... | grep -v /vendor/)
-
go vet $(go list ./... | grep -v /vendor/)
-
go test -race $(go list ./... | grep -v /vendor/)
compile
:
stage
:
build
script
:
# Add here all the dependencies, or use glide/govendor/...
# to get them automatically.
-
go get github.com/alecthomas/kingpin
# Better put this in a Makefile
-
go build -race -ldflags "-extldflags '-static'" -o mybinary
artifacts
:
paths
:
...
...
vendor/gitlab-ci-yml/Gradle.gitlab-ci.yml
View file @
68e9372a
# This template uses the java:8 docker image because there isn't any
# official Gradle image at this moment
#
# This is the Gradle build system for JVM applications
# https://gradle.org/
# https://github.com/gradle/gradle
image
:
java:8
image
:
gradle:alpine
# Disable the Gradle daemon for Continuous Integration servers as correctness
# is usually a priority over speed in CI environments. Using a fresh
...
...
@@ -13,29 +10,27 @@ image: java:8
variables
:
GRADLE_OPTS
:
"
-Dorg.gradle.daemon=false"
# Make the gradle wrapper executable. This essentially downloads a copy of
# Gradle to build the project with.
# https://docs.gradle.org/current/userguide/gradle_wrapper.html
# It is expected that any modern gradle project has a wrapper
before_script
:
-
chmod +x gradlew
-
export GRADLE_USER_HOME=`pwd`/.gradle
# We redirect the gradle user home using -g so that it caches the
# wrapper and dependencies.
# https://docs.gradle.org/current/userguide/gradle_command_line.html
#
# Unfortunately it also caches the build output so
# cleaning removes reminants of any cached builds.
# The assemble task actually builds the project.
# If it fails here, the tests can't run.
build
:
stage
:
build
script
:
-
./gradlew -g /cache/.gradle clean assemble
allow_failure
:
false
script
:
gradle --build-cache assemble
cache
:
key
:
"
$CI_COMMIT_REF_NAME"
policy
:
push
paths
:
-
build
-
.gradle
# Use the generated build output to run the tests.
test
:
stage
:
test
script
:
-
./gradlew -g /cache/.gradle check
script
:
gradle check
cache
:
key
:
"
$CI_COMMIT_REF_NAME"
policy
:
pull
paths
:
-
build
-
.gradle
vendor/gitlab-ci-yml/Laravel.gitlab-ci.yml
View file @
68e9372a
...
...
@@ -34,6 +34,10 @@ before_script:
# Install php extensions
-
docker-php-ext-install mbstring mcrypt pdo_mysql curl json intl gd xml zip bz2 opcache
# Install & enable Xdebug for code coverage reports
-
pecl install xdebug
-
docker-php-ext-enable xdebug
# Install Composer and project dependencies.
-
curl -sS https://getcomposer.org/installer | php
-
php composer.phar install
...
...
vendor/gitlab-ci-yml/PHP.gitlab-ci.yml
View file @
68e9372a
...
...
@@ -11,6 +11,9 @@ before_script:
-
apt-get install -yqq git libmcrypt-dev libpq-dev libcurl4-gnutls-dev libicu-dev libvpx-dev libjpeg-dev libpng-dev libxpm-dev zlib1g-dev libfreetype6-dev libxml2-dev libexpat1-dev libbz2-dev libgmp3-dev libldap2-dev unixodbc-dev libsqlite3-dev libaspell-dev libsnmp-dev libpcre3-dev libtidy-dev
# Install PHP extensions
-
docker-php-ext-install mbstring mcrypt pdo_pgsql curl json intl gd xml zip bz2 opcache
# Install & enable Xdebug for code coverage reports
-
pecl install xdebug
-
docker-php-ext-enable xdebug
# Install and run Composer
-
curl -sS https://getcomposer.org/installer | php
-
php composer.phar install
...
...
vendor/gitlab-ci-yml/Ruby.gitlab-ci.yml
View file @
68e9372a
# Official language image. Look for the different tagged releases at:
# https://hub.docker.com/r/library/ruby/tags/
image
:
"
ruby:2.
3
"
image
:
"
ruby:2.
4
"
# Pick zero or more services to be used on all builds.
# Only needed when using a docker container to run your tests in.
...
...
@@ -40,9 +40,9 @@ rails:
variables
:
DATABASE_URL
:
"
postgresql://postgres:postgres@postgres:5432/$POSTGRES_DB"
script
:
-
bundle exec rake
db:migrate
-
bundle exec rake
db:seed
-
bundle exec rake
test
-
rails
db:migrate
-
rails
db:seed
-
rails
test
# This deploy job uses a simple deploy flow to Heroku, other providers, e.g. AWS Elastic Beanstalk
# are supported too: https://github.com/travis-ci/dpl
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment