Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
92bc1dda
Commit
92bc1dda
authored
May 18, 2017
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Dryup fetching pipeline_schedule with helper
parent
8c40bbbe
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
6 deletions
+14
-6
lib/api/pipeline_schedules.rb
lib/api/pipeline_schedules.rb
+14
-6
No files found.
lib/api/pipeline_schedules.rb
View file @
92bc1dda
...
@@ -17,8 +17,6 @@ module API
...
@@ -17,8 +17,6 @@ module API
get
':id/pipeline_schedules'
do
get
':id/pipeline_schedules'
do
authorize!
:read_pipeline_schedule
,
user_project
authorize!
:read_pipeline_schedule
,
user_project
pipeline_schedules
=
user_project
.
pipeline_schedules
.
preload
([
:owner
,
:last_pipeline
])
present
paginate
(
pipeline_schedules
),
with:
Entities
::
PipelineSchedule
present
paginate
(
pipeline_schedules
),
with:
Entities
::
PipelineSchedule
end
end
...
@@ -31,7 +29,6 @@ module API
...
@@ -31,7 +29,6 @@ module API
get
':id/pipeline_schedules/:pipeline_schedule_id'
do
get
':id/pipeline_schedules/:pipeline_schedule_id'
do
authorize!
:read_pipeline_schedule
,
user_project
authorize!
:read_pipeline_schedule
,
user_project
pipeline_schedule
=
user_project
.
pipeline_schedules
.
find
(
params
.
delete
(
:pipeline_schedule_id
))
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
present
pipeline_schedule
,
with:
Entities
::
PipelineSchedule
present
pipeline_schedule
,
with:
Entities
::
PipelineSchedule
...
@@ -75,7 +72,6 @@ module API
...
@@ -75,7 +72,6 @@ module API
put
':id/pipeline_schedules/:pipeline_schedule_id'
do
put
':id/pipeline_schedules/:pipeline_schedule_id'
do
authorize!
:create_pipeline_schedule
,
user_project
authorize!
:create_pipeline_schedule
,
user_project
pipeline_schedule
=
user_project
.
pipeline_schedules
.
find
(
params
.
delete
(
:pipeline_schedule_id
))
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
if
pipeline_schedule
.
update
(
declared_params
(
include_missing:
false
))
if
pipeline_schedule
.
update
(
declared_params
(
include_missing:
false
))
...
@@ -94,7 +90,6 @@ module API
...
@@ -94,7 +90,6 @@ module API
post
':id/pipeline_schedules/:pipeline_schedule_id/take_ownership'
do
post
':id/pipeline_schedules/:pipeline_schedule_id/take_ownership'
do
authorize!
:create_pipeline_schedule
,
user_project
authorize!
:create_pipeline_schedule
,
user_project
pipeline_schedule
=
user_project
.
pipeline_schedules
.
find
(
params
.
delete
(
:pipeline_schedule_id
))
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
if
pipeline_schedule
.
own!
(
current_user
)
if
pipeline_schedule
.
own!
(
current_user
)
...
@@ -113,11 +108,24 @@ module API
...
@@ -113,11 +108,24 @@ module API
delete
':id/pipeline_schedules/:pipeline_schedule_id'
do
delete
':id/pipeline_schedules/:pipeline_schedule_id'
do
authorize!
:admin_pipeline_schedule
,
user_project
authorize!
:admin_pipeline_schedule
,
user_project
pipeline_schedule
=
user_project
.
pipeline_schedules
.
find
(
params
.
delete
(
:pipeline_schedule_id
))
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
return
not_found!
(
'PipelineSchedule'
)
unless
pipeline_schedule
present
pipeline_schedule
.
destroy
,
with:
Entities
::
PipelineSchedule
present
pipeline_schedule
.
destroy
,
with:
Entities
::
PipelineSchedule
end
end
end
end
helpers
do
def
pipeline_schedules
@pipeline_schedules
||=
user_project
.
pipeline_schedules
.
preload
([
:owner
,
:last_pipeline
])
end
def
pipeline_schedule
@pipeline_schedule
||=
user_project
.
pipeline_schedules
.
preload
([
:owner
,
:last_pipeline
])
.
find
(
params
.
delete
(
:pipeline_schedule_id
))
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment