Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
9452fd2b
Commit
9452fd2b
authored
Jan 09, 2018
by
David Kuri
Committed by
Phil Hughes
Jan 09, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixing re-ordering of an issue when dragging it to the bottom a long issue list in the board
parent
d2d634a9
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
1 deletion
+18
-1
app/assets/javascripts/boards/components/board_list.js
app/assets/javascripts/boards/components/board_list.js
+1
-1
changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml
...logs/unreleased/36906-reordering-issues-to-the-bottom.yml
+5
-0
spec/javascripts/boards/board_list_spec.js
spec/javascripts/boards/board_list_spec.js
+12
-0
No files found.
app/assets/javascripts/boards/components/board_list.js
View file @
9452fd2b
...
@@ -187,7 +187,7 @@ export default {
...
@@ -187,7 +187,7 @@ export default {
<li
<li
class="board-list-count text-center"
class="board-list-count text-center"
v-if="showCount"
v-if="showCount"
data-id="-1">
data-i
ssue-i
d="-1">
<loading-icon
<loading-icon
v-show="list.loadingMore"
v-show="list.loadingMore"
...
...
changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml
0 → 100644
View file @
9452fd2b
---
title
:
"
Issue
board:
fix
for
dragging
an
issue
to
the
very
bottom
in
long
lists"
merge_request
:
16250
author
:
David Kuri
type
:
fixed
\ No newline at end of file
spec/javascripts/boards/board_list_spec.js
View file @
9452fd2b
...
@@ -154,6 +154,18 @@ describe('Board list component', () => {
...
@@ -154,6 +154,18 @@ describe('Board list component', () => {
});
});
});
});
it
(
'
sets data attribute with invalid id
'
,
(
done
)
=>
{
component
.
showCount
=
true
;
Vue
.
nextTick
(()
=>
{
expect
(
component
.
$el
.
querySelector
(
'
.board-list-count
'
).
getAttribute
(
'
data-issue-id
'
),
).
toBe
(
'
-1
'
);
done
();
});
});
it
(
'
shows how many more issues to load
'
,
(
done
)
=>
{
it
(
'
shows how many more issues to load
'
,
(
done
)
=>
{
component
.
showCount
=
true
;
component
.
showCount
=
true
;
component
.
list
.
issuesSize
=
20
;
component
.
list
.
issuesSize
=
20
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment