Commit c380d766 authored by Jose Ivan Vargas Lopez's avatar Jose Ivan Vargas Lopez Committed by Jose Ivan Vargas

Fixed button capitalisation for Projects in views

parent 7592137f
...@@ -102,7 +102,7 @@ module BlobHelper ...@@ -102,7 +102,7 @@ module BlobHelper
if Gitlab::MarkupHelper.previewable?(filename) if Gitlab::MarkupHelper.previewable?(filename)
'Preview' 'Preview'
else else
'Preview Changes' 'Preview changes'
end end
end end
......
= link_to namespace_project_find_file_path(@project.namespace, @project, @ref), class: 'btn btn-grouped shortcuts-find-file', rel: 'nofollow' do = link_to namespace_project_find_file_path(@project.namespace, @project, @ref), class: 'btn btn-grouped shortcuts-find-file', rel: 'nofollow' do
= icon('search') = icon('search')
%span Find File %span Find file
...@@ -14,5 +14,5 @@ ...@@ -14,5 +14,5 @@
#{time_ago_with_tooltip(event.created_at)} #{time_ago_with_tooltip(event.created_at)}
.pull-right .pull-right
= link_to new_mr_path_from_push_event(event), title: "New Merge Request", class: "btn btn-info btn-sm" do = link_to new_mr_path_from_push_event(event), title: "New merge request", class: "btn btn-info btn-sm" do
Create Merge Request Create merge request
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
-# only show normal/blame view links for text files -# only show normal/blame view links for text files
- if blob_text_viewable?(blob) - if blob_text_viewable?(blob)
- if current_page? namespace_project_blame_path(@project.namespace, @project, @id) - if current_page? namespace_project_blame_path(@project.namespace, @project, @id)
= link_to 'Normal View', namespace_project_blob_path(@project.namespace, @project, @id), = link_to 'Normal view', namespace_project_blob_path(@project.namespace, @project, @id),
class: 'btn btn-sm' class: 'btn btn-sm'
- else - else
= link_to 'Blame', namespace_project_blame_path(@project.namespace, @project, @id), = link_to 'Blame', namespace_project_blame_path(@project.namespace, @project, @id),
......
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
.controls.hidden-xs< .controls.hidden-xs<
- if merge_project && create_mr_button?(@repository.root_ref, branch.name) - if merge_project && create_mr_button?(@repository.root_ref, branch.name)
= link_to create_mr_path(@repository.root_ref, branch.name), class: 'btn btn-default' do = link_to create_mr_path(@repository.root_ref, branch.name), class: 'btn btn-default' do
Merge Request Merge request
- if branch.name != @repository.root_ref - if branch.name != @repository.root_ref
= link_to namespace_project_compare_index_path(@project.namespace, @project, from: @repository.root_ref, to: branch.name), class: "btn btn-default #{'prepend-left-10' unless merge_project}", method: :post, title: "Compare" do = link_to namespace_project_compare_index_path(@project.namespace, @project, from: @repository.root_ref, to: branch.name), class: "btn btn-default #{'prepend-left-10' unless merge_project}", method: :post, title: "Compare" do
......
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
= link_to 'Get started with CI/CD Pipelines', help_page_path('ci/quick_start/README'), class: 'btn btn-info' = link_to 'Get started with CI/CD Pipelines', help_page_path('ci/quick_start/README'), class: 'btn btn-info'
= link_to ci_lint_path, class: 'btn btn-default' do = link_to ci_lint_path, class: 'btn btn-default' do
%span CI Lint %span CI lint
.content-list.builds-content-list .content-list.builds-content-list
= render "table", builds: @builds, project: @project = render "table", builds: @builds, project: @project
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
= icon('comment') = icon('comment')
= @notes_count = @notes_count
= link_to namespace_project_tree_path(@project.namespace, @project, @commit), class: "btn btn-default append-right-10 hidden-xs hidden-sm" do = link_to namespace_project_tree_path(@project.namespace, @project, @commit), class: "btn btn-default append-right-10 hidden-xs hidden-sm" do
Browse Files Browse files
.dropdown.inline .dropdown.inline
%a.btn.btn-default.dropdown-toggle{ data: { toggle: "dropdown" } } %a.btn.btn-default.dropdown-toggle{ data: { toggle: "dropdown" } }
%span Options %span Options
......
...@@ -18,16 +18,16 @@ ...@@ -18,16 +18,16 @@
.block-controls.hidden-xs.hidden-sm .block-controls.hidden-xs.hidden-sm
- if @merge_request.present? - if @merge_request.present?
.control .control
= link_to "View Open Merge Request", namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'btn' = link_to "View open merge request", namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'btn'
- elsif create_mr_button?(@repository.root_ref, @ref) - elsif create_mr_button?(@repository.root_ref, @ref)
.control .control
= link_to "Create Merge Request", create_mr_path(@repository.root_ref, @ref), class: 'btn btn-success' = link_to "Create merge request", create_mr_path(@repository.root_ref, @ref), class: 'btn btn-success'
.control .control
= form_tag(namespace_project_commits_path(@project.namespace, @project, @id), method: :get, class: 'commits-search-form') do = form_tag(namespace_project_commits_path(@project.namespace, @project, @id), method: :get, class: 'commits-search-form') do
= search_field_tag :search, params[:search], { placeholder: 'Filter by commit message', id: 'commits-search', class: 'form-control search-text-input input-short', spellcheck: false } = search_field_tag :search, params[:search], { placeholder: 'Filter by commit message', id: 'commits-search', class: 'form-control search-text-input input-short', spellcheck: false }
.control .control
= link_to namespace_project_commits_path(@project.namespace, @project, @ref, rss_url_options), title: "Commits Feed", class: 'btn' do = link_to namespace_project_commits_path(@project.namespace, @project, @ref, rss_url_options), title: "Commits feed", class: 'btn' do
= icon("rss") = icon("rss")
%div{ id: dom_id(@project) } %div{ id: dom_id(@project) }
......
...@@ -21,6 +21,6 @@ ...@@ -21,6 +21,6 @@
&nbsp; &nbsp;
= button_tag "Compare", class: "btn btn-create commits-compare-btn" = button_tag "Compare", class: "btn btn-create commits-compare-btn"
- if @merge_request.present? - if @merge_request.present?
= link_to "View Open Merge Request", namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'prepend-left-10 btn' = link_to "View open merge request", namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'prepend-left-10 btn'
- elsif create_mr_button? - elsif create_mr_button?
= link_to "Create Merge Request", create_mr_path, class: 'prepend-left-10 btn' = link_to "Create merge request", create_mr_path, class: 'prepend-left-10 btn'
...@@ -22,4 +22,4 @@ ...@@ -22,4 +22,4 @@
%p %p
= link_to new_namespace_project_fork_path(@project.namespace, @project), title: "Fork", class: "btn" do = link_to new_namespace_project_fork_path(@project.namespace, @project), title: "Fork", class: "btn" do
%i.fa.fa-code-fork %i.fa.fa-code-fork
Try to Fork again Try to fork again
...@@ -24,9 +24,9 @@ ...@@ -24,9 +24,9 @@
issue: { assignee_id: issues_finder.assignee.try(:id), issue: { assignee_id: issues_finder.assignee.try(:id),
milestone_id: issues_finder.milestones.first.try(:id) }), milestone_id: issues_finder.milestones.first.try(:id) }),
class: "btn btn-new", class: "btn btn-new",
title: "New Issue", title: "New issue",
id: "new_issue_link" do id: "new_issue_link" do
New Issue New issue
= render 'shared/issuable/search_bar', type: :issues = render 'shared/issuable/search_bar', type: :issues
.issues-holder .issues-holder
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
- if can_remove_source_branch - if can_remove_source_branch
= link_to namespace_project_branch_path(@merge_request.source_project.namespace, @merge_request.source_project, @merge_request.source_branch), remote: true, method: :delete, class: "btn btn-default remove_source_branch" do = link_to namespace_project_branch_path(@merge_request.source_project.namespace, @merge_request.source_project, @merge_request.source_branch), remote: true, method: :delete, class: "btn btn-default remove_source_branch" do
= icon('trash-o') = icon('trash-o')
Remove Source Branch Remove source branch
- if mr_can_be_reverted - if mr_can_be_reverted
= revert_commit_link(@merge_request.merge_commit, namespace_project_merge_request_path(@project.namespace, @project, @merge_request), btn_class: "close") = revert_commit_link(@merge_request.merge_commit, namespace_project_merge_request_path(@project.namespace, @project, @merge_request), btn_class: "close")
- if mr_can_be_cherry_picked - if mr_can_be_cherry_picked
......
...@@ -10,24 +10,24 @@ ...@@ -10,24 +10,24 @@
- if @pipeline && @pipeline.active? - if @pipeline && @pipeline.active?
%span.btn-group %span.btn-group
= button_tag class: "btn btn-info js-merge-when-pipeline-succeeds-button merge-when-pipeline-succeeds" do = button_tag class: "btn btn-info js-merge-when-pipeline-succeeds-button merge-when-pipeline-succeeds" do
Merge When Pipeline Succeeds Merge when pipeline succeeds
- unless @project.only_allow_merge_if_pipeline_succeeds? - unless @project.only_allow_merge_if_pipeline_succeeds?
= button_tag class: "btn btn-info dropdown-toggle", 'data-toggle' => 'dropdown' do = button_tag class: "btn btn-info dropdown-toggle", 'data-toggle' => 'dropdown' do
= icon('caret-down') = icon('caret-down')
%span.sr-only %span.sr-only
Select Merge Moment Select merge moment
%ul.js-merge-dropdown.dropdown-menu.dropdown-menu-right{ role: 'menu' } %ul.js-merge-dropdown.dropdown-menu.dropdown-menu-right{ role: 'menu' }
%li %li
= link_to "#", class: "merge_when_pipeline_succeeds" do = link_to "#", class: "merge_when_pipeline_succeeds" do
= icon('check fw') = icon('check fw')
Merge When Pipeline Succeeds Merge when pipeline succeeds
%li %li
= link_to "#", class: "accept-merge-request" do = link_to "#", class: "accept-merge-request" do
= icon('warning fw') = icon('warning fw')
Merge Immediately Merge immediately
- else - else
= f.button class: "btn btn-grouped js-merge-button accept-merge-request" do = f.button class: "btn btn-grouped js-merge-button accept-merge-request" do
Accept Merge Request Accept merge request
- if @merge_request.force_remove_source_branch? - if @merge_request.force_remove_source_branch?
.accept-control .accept-control
The source branch will be removed. The source branch will be removed.
......
...@@ -26,8 +26,8 @@ ...@@ -26,8 +26,8 @@
- if remove_source_branch_button - if remove_source_branch_button
= link_to merge_namespace_project_merge_request_path(@merge_request.target_project.namespace, @merge_request.target_project, @merge_request, merge_params(@merge_request)), remote: true, method: :post, class: "btn btn-grouped btn-primary btn-sm remove_source_branch" do = link_to merge_namespace_project_merge_request_path(@merge_request.target_project.namespace, @merge_request.target_project, @merge_request, merge_params(@merge_request)), remote: true, method: :post, class: "btn btn-grouped btn-primary btn-sm remove_source_branch" do
= icon('times') = icon('times')
Remove Source Branch When Merged Remove source branch when merged
- if user_can_cancel_automatic_merge - if user_can_cancel_automatic_merge
= link_to cancel_merge_when_pipeline_succeeds_namespace_project_merge_request_path(@merge_request.target_project.namespace, @merge_request.target_project, @merge_request), remote: true, method: :post, class: "btn btn-grouped btn-sm" do = link_to cancel_merge_when_pipeline_succeeds_namespace_project_merge_request_path(@merge_request.target_project.namespace, @merge_request.target_project, @merge_request), remote: true, method: :post, class: "btn btn-grouped btn-sm" do
Cancel Automatic Merge Cancel automatic merge
...@@ -9,8 +9,8 @@ ...@@ -9,8 +9,8 @@
.nav-controls .nav-controls
= render 'shared/milestones_sort_dropdown' = render 'shared/milestones_sort_dropdown'
- if can?(current_user, :admin_milestone, @project) - if can?(current_user, :admin_milestone, @project)
= link_to new_namespace_project_milestone_path(@project.namespace, @project), class: 'btn btn-new', title: 'New Milestone' do = link_to new_namespace_project_milestone_path(@project.namespace, @project), class: 'btn btn-new', title: 'New milestone' do
New Milestone New milestone
.milestones .milestones
%ul.content-list %ul.content-list
......
...@@ -23,9 +23,9 @@ ...@@ -23,9 +23,9 @@
.milestone-buttons .milestone-buttons
- if can?(current_user, :admin_milestone, @project) - if can?(current_user, :admin_milestone, @project)
- if @milestone.active? - if @milestone.active?
= link_to 'Close Milestone', namespace_project_milestone_path(@project.namespace, @project, @milestone, milestone: {state_event: :close }), method: :put, class: "btn btn-close btn-nr btn-grouped" = link_to 'Close milestone', namespace_project_milestone_path(@project.namespace, @project, @milestone, milestone: {state_event: :close }), method: :put, class: "btn btn-close btn-nr btn-grouped"
- else - else
= link_to 'Reopen Milestone', namespace_project_milestone_path(@project.namespace, @project, @milestone, milestone: {state_event: :activate }), method: :put, class: "btn btn-reopen btn-nr btn-grouped" = link_to 'Reopen milestone', namespace_project_milestone_path(@project.namespace, @project, @milestone, milestone: {state_event: :activate }), method: :put, class: "btn btn-reopen btn-nr btn-grouped"
= link_to edit_namespace_project_milestone_path(@project.namespace, @project, @milestone), class: "btn btn-grouped btn-nr" do = link_to edit_namespace_project_milestone_path(@project.namespace, @project, @milestone), class: "btn btn-grouped btn-nr" do
Edit Edit
......
...@@ -9,6 +9,6 @@ ...@@ -9,6 +9,6 @@
.note-form-actions.clearfix .note-form-actions.clearfix
.settings-message.note-edit-warning.js-edit-warning .settings-message.note-edit-warning.js-edit-warning
Finish editing this message first! Finish editing this message first!
= submit_tag 'Save Comment', class: 'btn btn-nr btn-save js-comment-button' = submit_tag 'Save comment', class: 'btn btn-nr btn-save js-comment-button'
%button.btn.btn-nr.btn-cancel.note-edit-cancel{ type: 'button' } %button.btn.btn-nr.btn-cancel.note-edit-cancel{ type: 'button' }
Cancel Cancel
- if (@page && @page.persisted?) - if (@page && @page.persisted?)
- if can?(current_user, :create_wiki, @project) - if can?(current_user, :create_wiki, @project)
= link_to '#modal-new-wiki', class: "add-new-wiki btn btn-new", "data-toggle" => "modal" do = link_to '#modal-new-wiki', class: "add-new-wiki btn btn-new", "data-toggle" => "modal" do
New Page New page
= link_to namespace_project_wiki_history_path(@project.namespace, @project, @page), class: "btn" do = link_to namespace_project_wiki_history_path(@project.namespace, @project, @page), class: "btn" do
Page History Page history
- if can?(current_user, :create_wiki, @project) && @page.latest? - if can?(current_user, :create_wiki, @project) && @page.latest?
= link_to namespace_project_wiki_edit_path(@project.namespace, @project, @page), class: "btn" do = link_to namespace_project_wiki_edit_path(@project.namespace, @project, @page), class: "btn" do
Edit Edit
...@@ -18,4 +18,4 @@ ...@@ -18,4 +18,4 @@
Tip: You can specify the full path for the new file. Tip: You can specify the full path for the new file.
We will automatically create any missing directories. We will automatically create any missing directories.
.form-actions .form-actions
= button_tag 'Create Page', class: 'build-new-wiki btn btn-create' = button_tag 'Create page', class: 'build-new-wiki btn btn-create'
...@@ -22,10 +22,10 @@ ...@@ -22,10 +22,10 @@
.nav-controls .nav-controls
- if can?(current_user, :create_wiki, @project) - if can?(current_user, :create_wiki, @project)
= link_to '#modal-new-wiki', class: "add-new-wiki btn btn-new", "data-toggle" => "modal" do = link_to '#modal-new-wiki', class: "add-new-wiki btn btn-new", "data-toggle" => "modal" do
New Page New page
- if @page.persisted? - if @page.persisted?
= link_to namespace_project_wiki_history_path(@project.namespace, @project, @page), class: "btn" do = link_to namespace_project_wiki_history_path(@project.namespace, @project, @page), class: "btn" do
Page History Page history
- if can?(current_user, :admin_wiki, @project) - if can?(current_user, :admin_wiki, @project)
= link_to namespace_project_wiki_path(@project.namespace, @project, @page), data: { confirm: "Are you sure you want to delete this page?"}, method: :delete, class: "btn btn-danger" do = link_to namespace_project_wiki_path(@project.namespace, @project, @page), data: { confirm: "Are you sure you want to delete this page?"}, method: :delete, class: "btn btn-danger" do
Delete Delete
......
...@@ -29,5 +29,5 @@ ...@@ -29,5 +29,5 @@
- if @label.persisted? - if @label.persisted?
= f.submit 'Save changes', class: 'btn btn-save js-save-button' = f.submit 'Save changes', class: 'btn btn-save js-save-button'
- else - else
= f.submit 'Create Label', class: 'btn btn-create js-save-button' = f.submit 'Create label', class: 'btn btn-create js-save-button'
= link_to 'Cancel', back_path, class: 'btn btn-cancel' = link_to 'Cancel', back_path, class: 'btn btn-cancel'
...@@ -89,7 +89,7 @@ ...@@ -89,7 +89,7 @@
= f.label :enable_ssl_verification do = f.label :enable_ssl_verification do
= f.check_box :enable_ssl_verification = f.check_box :enable_ssl_verification
%strong Enable SSL verification %strong Enable SSL verification
= f.submit "Add Webhook", class: "btn btn-create" = f.submit "Add webhook", class: "btn btn-create"
%hr %hr
%h5.prepend-top-default %h5.prepend-top-default
Webhooks (#{hooks.count}) Webhooks (#{hooks.count})
......
...@@ -12,7 +12,7 @@ class Spinach::Features::ProjectBuildsSummary < Spinach::FeatureSteps ...@@ -12,7 +12,7 @@ class Spinach::Features::ProjectBuildsSummary < Spinach::FeatureSteps
step 'I see button to CI Lint' do step 'I see button to CI Lint' do
page.within('.nav-controls') do page.within('.nav-controls') do
ci_lint_tool_link = page.find_link('CI Lint') ci_lint_tool_link = page.find_link('CI lint')
expect(ci_lint_tool_link[:href]).to eq ci_lint_path expect(ci_lint_tool_link[:href]).to eq ci_lint_path
end end
end end
......
...@@ -13,7 +13,7 @@ class Spinach::Features::ProjectCommits < Spinach::FeatureSteps ...@@ -13,7 +13,7 @@ class Spinach::Features::ProjectCommits < Spinach::FeatureSteps
end end
step 'I click atom feed link' do step 'I click atom feed link' do
click_link "Commits Feed" click_link "Commits feed"
end end
step 'I see commits atom feed' do step 'I see commits atom feed' do
...@@ -110,16 +110,16 @@ class Spinach::Features::ProjectCommits < Spinach::FeatureSteps ...@@ -110,16 +110,16 @@ class Spinach::Features::ProjectCommits < Spinach::FeatureSteps
end end
step 'I see button to create a new merge request' do step 'I see button to create a new merge request' do
expect(page).to have_link 'Create Merge Request' expect(page).to have_link 'Create merge request'
end end
step 'I should not see button to create a new merge request' do step 'I should not see button to create a new merge request' do
expect(page).not_to have_link 'Create Merge Request' expect(page).not_to have_link 'Create merge request'
end end
step 'I should see button to the merge request' do step 'I should see button to the merge request' do
merge_request = MergeRequest.find_by(title: 'Feature') merge_request = MergeRequest.find_by(title: 'Feature')
expect(page).to have_link "View Open Merge Request", href: namespace_project_merge_request_path(@project.namespace, @project, merge_request) expect(page).to have_link "View open merge request", href: namespace_project_merge_request_path(@project.namespace, @project, merge_request)
end end
step 'I see breadcrumb links' do step 'I see breadcrumb links' do
......
...@@ -26,7 +26,7 @@ class Spinach::Features::ProjectDeployKeys < Spinach::FeatureSteps ...@@ -26,7 +26,7 @@ class Spinach::Features::ProjectDeployKeys < Spinach::FeatureSteps
end end
step 'I click \'New Deploy Key\'' do step 'I click \'New Deploy Key\'' do
click_link 'New Deploy Key' click_link 'New deploy key'
end end
step 'I submit new deploy key' do step 'I submit new deploy key' do
......
...@@ -25,14 +25,14 @@ class Spinach::Features::ProjectHooks < Spinach::FeatureSteps ...@@ -25,14 +25,14 @@ class Spinach::Features::ProjectHooks < Spinach::FeatureSteps
step 'I submit new hook' do step 'I submit new hook' do
@url = 'http://example.org/1' @url = 'http://example.org/1'
fill_in "hook_url", with: @url fill_in "hook_url", with: @url
expect { click_button "Add Webhook" }.to change(ProjectHook, :count).by(1) expect { click_button "Add webhook" }.to change(ProjectHook, :count).by(1)
end end
step 'I submit new hook with SSL verification enabled' do step 'I submit new hook with SSL verification enabled' do
@url = 'http://example.org/2' @url = 'http://example.org/2'
fill_in "hook_url", with: @url fill_in "hook_url", with: @url
check "hook_enable_ssl_verification" check "hook_enable_ssl_verification"
expect { click_button "Add Webhook" }.to change(ProjectHook, :count).by(1) expect { click_button "Add webhook" }.to change(ProjectHook, :count).by(1)
end end
step 'I should see newly created hook' do step 'I should see newly created hook' do
......
...@@ -61,7 +61,7 @@ class Spinach::Features::ProjectIssues < Spinach::FeatureSteps ...@@ -61,7 +61,7 @@ class Spinach::Features::ProjectIssues < Spinach::FeatureSteps
expect(page).to have_content "Tweet control" expect(page).to have_content "Tweet control"
end end
step 'I click link "New Issue"' do step 'I click link "New issue"' do
page.has_link?('New Issue') ? click_link('New Issue') : click_link('New issue') page.has_link?('New Issue') ? click_link('New Issue') : click_link('New issue')
end end
......
...@@ -31,19 +31,19 @@ class Spinach::Features::ProjectIssuesLabels < Spinach::FeatureSteps ...@@ -31,19 +31,19 @@ class Spinach::Features::ProjectIssuesLabels < Spinach::FeatureSteps
step 'I submit new label \'support\'' do step 'I submit new label \'support\'' do
fill_in 'Title', with: 'support' fill_in 'Title', with: 'support'
fill_in 'Background color', with: '#F95610' fill_in 'Background color', with: '#F95610'
click_button 'Create Label' click_button 'Create label'
end end
step 'I submit new label \'bug\'' do step 'I submit new label \'bug\'' do
fill_in 'Title', with: 'bug' fill_in 'Title', with: 'bug'
fill_in 'Background color', with: '#F95610' fill_in 'Background color', with: '#F95610'
click_button 'Create Label' click_button 'Create label'
end end
step 'I submit new label with invalid color' do step 'I submit new label with invalid color' do
fill_in 'Title', with: 'support' fill_in 'Title', with: 'support'
fill_in 'Background color', with: '#12' fill_in 'Background color', with: '#12'
click_button 'Create Label' click_button 'Create label'
end end
step 'I should see label label exist error message' do step 'I should see label label exist error message' do
......
...@@ -16,7 +16,7 @@ class Spinach::Features::ProjectIssuesMilestones < Spinach::FeatureSteps ...@@ -16,7 +16,7 @@ class Spinach::Features::ProjectIssuesMilestones < Spinach::FeatureSteps
end end
step 'I click link "New Milestone"' do step 'I click link "New Milestone"' do
click_link "New Milestone" click_link "New milestone"
end end
step 'I submit new milestone "v2.3"' do step 'I submit new milestone "v2.3"' do
......
...@@ -300,10 +300,10 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps ...@@ -300,10 +300,10 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
page.within('.current-note-edit-form', visible: true) do page.within('.current-note-edit-form', visible: true) do
fill_in 'note_note', with: 'Typo, please fix' fill_in 'note_note', with: 'Typo, please fix'
click_button 'Save Comment' click_button 'Save comment'
end end
expect(page).not_to have_button 'Save Comment', disabled: true, visible: true expect(page).not_to have_button 'Save comment', disabled: true, visible: true
end end
end end
...@@ -378,7 +378,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps ...@@ -378,7 +378,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
end end
step 'merge request is mergeable' do step 'merge request is mergeable' do
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
step 'I modify merge commit message' do step 'I modify merge commit message' do
...@@ -392,7 +392,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps ...@@ -392,7 +392,7 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
step 'I accept this merge request' do step 'I accept this merge request' do
page.within '.mr-state-widget' do page.within '.mr-state-widget' do
click_button "Accept Merge Request" click_button "Accept merge request"
end end
end end
......
...@@ -15,15 +15,15 @@ class Spinach::Features::ProjectMergeRequestsAcceptance < Spinach::FeatureSteps ...@@ -15,15 +15,15 @@ class Spinach::Features::ProjectMergeRequestsAcceptance < Spinach::FeatureSteps
end end
step 'I click on Accept Merge Request' do step 'I click on Accept Merge Request' do
click_button('Accept Merge Request') click_button('Accept merge request')
end end
step 'I should see the Remove Source Branch button' do step 'I should see the Remove Source Branch button' do
expect(page).to have_link('Remove Source Branch') expect(page).to have_link('Remove source branch')
end end
step 'I should not see the Remove Source Branch button' do step 'I should not see the Remove Source Branch button' do
expect(page).not_to have_link('Remove Source Branch') expect(page).not_to have_link('Remove source branch')
end end
step 'There is an open Merge Request' do step 'There is an open Merge Request' do
......
...@@ -26,7 +26,7 @@ class Spinach::Features::RevertMergeRequests < Spinach::FeatureSteps ...@@ -26,7 +26,7 @@ class Spinach::Features::RevertMergeRequests < Spinach::FeatureSteps
end end
step 'I click on Accept Merge Request' do step 'I click on Accept Merge Request' do
click_button('Accept Merge Request') click_button('Accept merge request')
end end
step 'I am signed in as a developer of the project' do step 'I am signed in as a developer of the project' do
......
...@@ -9,7 +9,7 @@ class Spinach::Features::ProjectFindFile < Spinach::FeatureSteps ...@@ -9,7 +9,7 @@ class Spinach::Features::ProjectFindFile < Spinach::FeatureSteps
end end
step 'I click Find File button' do step 'I click Find File button' do
click_link 'Find File' click_link 'Find file'
end end
step 'I should see "find file" page' do step 'I should see "find file" page' do
......
...@@ -105,7 +105,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps ...@@ -105,7 +105,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
end end
step 'I click link "Diff"' do step 'I click link "Diff"' do
click_link 'Preview Changes' click_link 'Preview changes'
end end
step 'I click on "Commit changes"' do step 'I click on "Commit changes"' do
......
...@@ -214,7 +214,9 @@ class Spinach::Features::ProjectSourceMarkdownRender < Spinach::FeatureSteps ...@@ -214,7 +214,9 @@ class Spinach::Features::ProjectSourceMarkdownRender < Spinach::FeatureSteps
step 'I add various links to the wiki page' do step 'I add various links to the wiki page' do
fill_in "wiki[content]", with: "[test](test)\n[GitLab API doc](api)\n[Rake tasks](raketasks)\n" fill_in "wiki[content]", with: "[test](test)\n[GitLab API doc](api)\n[Rake tasks](raketasks)\n"
fill_in "wiki[message]", with: "Adding links to wiki" fill_in "wiki[message]", with: "Adding links to wiki"
click_button "Create page" page.within '.wiki-form' do
click_button "Create page"
end
end end
step 'Wiki page should have added links' do step 'Wiki page should have added links' do
...@@ -225,7 +227,9 @@ class Spinach::Features::ProjectSourceMarkdownRender < Spinach::FeatureSteps ...@@ -225,7 +227,9 @@ class Spinach::Features::ProjectSourceMarkdownRender < Spinach::FeatureSteps
step 'I add a header to the wiki page' do step 'I add a header to the wiki page' do
fill_in "wiki[content]", with: "# Wiki header\n" fill_in "wiki[content]", with: "# Wiki header\n"
fill_in "wiki[message]", with: "Add header to wiki" fill_in "wiki[message]", with: "Add header to wiki"
click_button "Create page" page.within '.wiki-form' do
click_button "Create page"
end
end end
step 'Wiki header should have correct id and link' do step 'Wiki header should have correct id and link' do
......
...@@ -16,12 +16,16 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps ...@@ -16,12 +16,16 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps
step 'I create the Wiki Home page' do step 'I create the Wiki Home page' do
fill_in "wiki_content", with: '[link test](test)' fill_in "wiki_content", with: '[link test](test)'
click_on "Create page" page.within '.wiki-form' do
click_on "Create page"
end
end end
step 'I create the Wiki Home page with no content' do step 'I create the Wiki Home page with no content' do
fill_in "wiki_content", with: '' fill_in "wiki_content", with: ''
click_on "Create page" page.within '.wiki-form' do
click_on "Create page"
end
end end
step 'I should see the newly created wiki page' do step 'I should see the newly created wiki page' do
...@@ -29,7 +33,7 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps ...@@ -29,7 +33,7 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps
expect(page).to have_content "link test" expect(page).to have_content "link test"
click_link "link test" click_link "link test"
expect(page).to have_content "Create Page" expect(page).to have_content "Create page"
end end
step 'I have an existing Wiki page' do step 'I have an existing Wiki page' do
...@@ -63,7 +67,7 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps ...@@ -63,7 +67,7 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps
end end
step 'I click the History button' do step 'I click the History button' do
click_on "History" click_on 'Page history'
end end
step 'I should see both revisions' do step 'I should see both revisions' do
...@@ -121,15 +125,19 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps ...@@ -121,15 +125,19 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps
step 'I should see the new wiki page form' do step 'I should see the new wiki page form' do
expect(current_path).to match('wikis/image.jpg') expect(current_path).to match('wikis/image.jpg')
expect(page).to have_content('New Wiki Page') expect(page).to have_content('New Wiki Page')
expect(page).to have_content('Create Page') expect(page).to have_content('Create page')
end end
step 'I create a New page with paths' do step 'I create a New page with paths' do
click_on 'New Page' click_on 'New page'
fill_in 'Page slug', with: 'one/two/three-test' fill_in 'Page slug', with: 'one/two/three-test'
click_on 'Create Page' page.within '#modal-new-wiki' do
click_on 'Create page'
end
fill_in "wiki_content", with: 'wiki content' fill_in "wiki_content", with: 'wiki content'
click_on "Create page" page.within '.wiki-form' do
click_on "Create page"
end
expect(current_path).to include 'one/two/three-test' expect(current_path).to include 'one/two/three-test'
end end
...@@ -154,11 +162,11 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps ...@@ -154,11 +162,11 @@ class Spinach::Features::ProjectWiki < Spinach::FeatureSteps
step 'I view the page history of a Wiki page that has a path' do step 'I view the page history of a Wiki page that has a path' do
click_on 'Three' click_on 'Three'
click_on 'Page History' click_on 'Page history'
end end
step 'I click on Page History' do step 'I click on Page History' do
click_on 'Page History' click_on 'Page history'
end end
step 'I should see the page history' do step 'I should see the page history' do
......
...@@ -141,7 +141,7 @@ module SharedNote ...@@ -141,7 +141,7 @@ module SharedNote
page.within(".current-note-edit-form") do page.within(".current-note-edit-form") do
fill_in 'note[note]', with: '+1 Awesome!' fill_in 'note[note]', with: '+1 Awesome!'
click_button 'Save Comment' click_button 'Save comment'
end end
end end
......
...@@ -19,7 +19,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru ...@@ -19,7 +19,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru
it 'does not allow to merge' do it 'does not allow to merge' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).not_to have_button 'Accept Merge Request' expect(page).not_to have_button 'Accept merge request'
expect(page).to have_content('This merge request has unresolved discussions') expect(page).to have_content('This merge request has unresolved discussions')
end end
end end
...@@ -32,7 +32,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru ...@@ -32,7 +32,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
end end
...@@ -46,7 +46,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru ...@@ -46,7 +46,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru
it 'does not allow to merge' do it 'does not allow to merge' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
...@@ -58,7 +58,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru ...@@ -58,7 +58,7 @@ feature 'Check if mergeable with unresolved discussions', js: true, feature: tru
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
end end
......
...@@ -26,7 +26,7 @@ feature 'Create New Merge Request', feature: true, js: true do ...@@ -26,7 +26,7 @@ feature 'Create New Merge Request', feature: true, js: true do
end end
it 'selects the target branch sha when a tag with the same name exists' do it 'selects the target branch sha when a tag with the same name exists' do
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
click_link 'New merge request' click_link 'New merge request'
......
...@@ -32,7 +32,7 @@ feature 'Merge immediately', :feature, :js do ...@@ -32,7 +32,7 @@ feature 'Merge immediately', :feature, :js do
page.within '.mr-widget-body' do page.within '.mr-widget-body' do
find('.dropdown-toggle').click find('.dropdown-toggle').click
click_link 'Merge Immediately' click_link 'Merge immediately'
expect(find('.js-merge-when-pipeline-succeeds-button')).to have_content('Merge in progress') expect(find('.js-merge-when-pipeline-succeeds-button')).to have_content('Merge in progress')
......
...@@ -28,25 +28,25 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do ...@@ -28,25 +28,25 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do
visit_merge_request(merge_request) visit_merge_request(merge_request)
end end
it 'displays the Merge When Pipeline Succeeds button' do it 'displays the Merge when pipeline succeeds button' do
expect(page).to have_button "Merge When Pipeline Succeeds" expect(page).to have_button "Merge when pipeline succeeds"
end end
describe 'enabling Merge When Pipeline Succeeds' do describe 'enabling Merge when pipeline succeeds' do
shared_examples 'Merge When Pipeline Succeeds activator' do shared_examples 'Merge when pipeline succeeds activator' do
it 'activates the Merge When Pipeline Succeeds feature' do it 'activates the Merge when pipeline succeeds feature' do
click_button "Merge When Pipeline Succeeds" click_button "Merge when pipeline succeeds"
expect(page).to have_content "Set by #{user.name} to be merged automatically when the pipeline succeeds." expect(page).to have_content "Set by #{user.name} to be merged automatically when the pipeline succeeds."
expect(page).to have_content "The source branch will not be removed." expect(page).to have_content "The source branch will not be removed."
expect(page).to have_link "Cancel Automatic Merge" expect(page).to have_link "Cancel automatic merge"
visit_merge_request(merge_request) # Needed to refresh the page visit_merge_request(merge_request) # Needed to refresh the page
expect(page).to have_content /enabled an automatic merge when the pipeline for \h{8} succeeds/i expect(page).to have_content /enabled an automatic merge when the pipeline for \h{8} succeeds/i
end end
end end
context "when enabled immediately" do context "when enabled immediately" do
it_behaves_like 'Merge When Pipeline Succeeds activator' it_behaves_like 'Merge when pipeline succeeds activator'
end end
context 'when enabled after pipeline status changed' do context 'when enabled after pipeline status changed' do
...@@ -60,16 +60,16 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do ...@@ -60,16 +60,16 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do
expect(page).to have_content "Pipeline ##{pipeline.id} running" expect(page).to have_content "Pipeline ##{pipeline.id} running"
end end
it_behaves_like 'Merge When Pipeline Succeeds activator' it_behaves_like 'Merge when pipeline succeeds activator'
end end
context 'when enabled after it was previously canceled' do context 'when enabled after it was previously canceled' do
before do before do
click_button "Merge When Pipeline Succeeds" click_button "Merge when pipeline succeeds"
click_link "Cancel Automatic Merge" click_link "Cancel automatic merge"
end end
it_behaves_like 'Merge When Pipeline Succeeds activator' it_behaves_like 'Merge when pipeline succeeds activator'
end end
context 'when it was enabled and then canceled' do context 'when it was enabled and then canceled' do
...@@ -83,10 +83,10 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do ...@@ -83,10 +83,10 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do
end end
before do before do
click_link "Cancel Automatic Merge" click_link "Cancel automatic merge"
end end
it_behaves_like 'Merge When Pipeline Succeeds activator' it_behaves_like 'Merge when pipeline succeeds activator'
end end
end end
end end
...@@ -110,18 +110,18 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do ...@@ -110,18 +110,18 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do
end end
it 'allows to cancel the automatic merge' do it 'allows to cancel the automatic merge' do
click_link "Cancel Automatic Merge" click_link "Cancel automatic merge"
expect(page).to have_button "Merge When Pipeline Succeeds" expect(page).to have_button "Merge when pipeline succeeds"
visit_merge_request(merge_request) # refresh the page visit_merge_request(merge_request) # refresh the page
expect(page).to have_content "canceled the automatic merge" expect(page).to have_content "canceled the automatic merge"
end end
it "allows the user to remove the source branch" do it "allows the user to remove the source branch" do
expect(page).to have_link "Remove Source Branch When Merged" expect(page).to have_link "Remove source branch when merged"
click_link "Remove Source Branch When Merged" click_link "Remove source branch when merged"
expect(page).to have_content "The source branch will be removed" expect(page).to have_content "The source branch will be removed"
end end
...@@ -141,7 +141,7 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do ...@@ -141,7 +141,7 @@ feature 'Merge When Pipeline Succeeds', :feature, :js do
it "does not allow to enable merge when pipeline succeeds" do it "does not allow to enable merge when pipeline succeeds" do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).not_to have_link 'Merge When Pipeline Succeeds' expect(page).not_to have_link 'Merge when pipeline succeeds'
end end
end end
......
...@@ -14,7 +14,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -14,7 +14,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
...@@ -38,8 +38,8 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -38,8 +38,8 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'does not allow to merge immediately' do it 'does not allow to merge immediately' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Merge When Pipeline Succeeds' expect(page).to have_button 'Merge when pipeline succeeds'
expect(page).not_to have_button 'Select Merge Moment' expect(page).not_to have_button 'Select merge moment'
end end
end end
...@@ -49,7 +49,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -49,7 +49,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'does not allow MR to be merged' do it 'does not allow MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).not_to have_button 'Accept Merge Request' expect(page).not_to have_button 'Accept merge request'
expect(page).to have_content('Please retry the job or push a new commit to fix the failure.') expect(page).to have_content('Please retry the job or push a new commit to fix the failure.')
end end
end end
...@@ -60,7 +60,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -60,7 +60,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'does not allow MR to be merged' do it 'does not allow MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).not_to have_button 'Accept Merge Request' expect(page).not_to have_button 'Accept merge request'
expect(page).to have_content('Please retry the job or push a new commit to fix the failure.') expect(page).to have_content('Please retry the job or push a new commit to fix the failure.')
end end
end end
...@@ -71,7 +71,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -71,7 +71,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
...@@ -81,7 +81,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -81,7 +81,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
end end
...@@ -97,10 +97,10 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -97,10 +97,10 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged immediately', js: true do it 'allows MR to be merged immediately', js: true do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Merge When Pipeline Succeeds' expect(page).to have_button 'Merge when pipeline succeeds'
click_button 'Select Merge Moment' click_button 'Select merge moment'
expect(page).to have_content 'Merge Immediately' expect(page).to have_content 'Merge immediately'
end end
end end
...@@ -110,7 +110,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -110,7 +110,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
...@@ -120,7 +120,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu ...@@ -120,7 +120,7 @@ feature 'Only allow merge requests to be merged if the pipeline succeeds', featu
it 'allows MR to be merged' do it 'allows MR to be merged' do
visit_merge_request(merge_request) visit_merge_request(merge_request)
expect(page).to have_button 'Accept Merge Request' expect(page).to have_button 'Accept merge request'
end end
end end
end end
......
...@@ -145,7 +145,7 @@ describe 'Merge request', :feature, :js do ...@@ -145,7 +145,7 @@ describe 'Merge request', :feature, :js do
before do before do
allow_any_instance_of(Repository).to receive(:merge).and_return(false) allow_any_instance_of(Repository).to receive(:merge).and_return(false)
visit namespace_project_merge_request_path(project.namespace, project, merge_request) visit namespace_project_merge_request_path(project.namespace, project, merge_request)
click_button 'Accept Merge Request' click_button 'Accept merge request'
wait_for_ajax wait_for_ajax
end end
......
...@@ -48,7 +48,7 @@ feature 'Template type dropdown selector', js: true do ...@@ -48,7 +48,7 @@ feature 'Template type dropdown selector', js: true do
context 'user previews changes' do context 'user previews changes' do
before do before do
click_link 'Preview Changes' click_link 'Preview changes'
end end
scenario 'type selector is hidden and shown correctly' do scenario 'type selector is hidden and shown correctly' do
......
require 'spec_helper' require 'spec_helper'
feature 'Merge Request button', feature: true do feature 'Merge Request button', feature: true do
shared_examples 'Merge Request button only shown when allowed' do shared_examples 'Merge request button only shown when allowed' do
let(:user) { create(:user) } let(:user) { create(:user) }
let(:project) { create(:project, :public) } let(:project) { create(:project, :public) }
let(:forked_project) { create(:project, :public, forked_from_project: project) } let(:forked_project) { create(:project, :public, forked_from_project: project) }
context 'not logged in' do context 'not logged in' do
it 'does not show Create Merge Request button' do it 'does not show Create merge request button' do
visit url visit url
within("#content-body") do within("#content-body") do
...@@ -22,7 +22,7 @@ feature 'Merge Request button', feature: true do ...@@ -22,7 +22,7 @@ feature 'Merge Request button', feature: true do
project.team << [user, :developer] project.team << [user, :developer]
end end
it 'shows Create Merge Request button' do it 'shows Create merge request button' do
href = new_namespace_project_merge_request_path(project.namespace, href = new_namespace_project_merge_request_path(project.namespace,
project, project,
merge_request: { source_branch: 'feature', merge_request: { source_branch: 'feature',
...@@ -40,7 +40,7 @@ feature 'Merge Request button', feature: true do ...@@ -40,7 +40,7 @@ feature 'Merge Request button', feature: true do
project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED) project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED)
end end
it 'does not show Create Merge Request button' do it 'does not show Create merge request button' do
visit url visit url
within("#content-body") do within("#content-body") do
...@@ -55,7 +55,7 @@ feature 'Merge Request button', feature: true do ...@@ -55,7 +55,7 @@ feature 'Merge Request button', feature: true do
login_as(user) login_as(user)
end end
it 'does not show Create Merge Request button' do it 'does not show Create merge request button' do
visit url visit url
within("#content-body") do within("#content-body") do
...@@ -66,7 +66,7 @@ feature 'Merge Request button', feature: true do ...@@ -66,7 +66,7 @@ feature 'Merge Request button', feature: true do
context 'on own fork of project' do context 'on own fork of project' do
let(:user) { forked_project.owner } let(:user) { forked_project.owner }
it 'shows Create Merge Request button' do it 'shows Create merge request button' do
href = new_namespace_project_merge_request_path(forked_project.namespace, href = new_namespace_project_merge_request_path(forked_project.namespace,
forked_project, forked_project,
merge_request: { source_branch: 'feature', merge_request: { source_branch: 'feature',
...@@ -83,24 +83,24 @@ feature 'Merge Request button', feature: true do ...@@ -83,24 +83,24 @@ feature 'Merge Request button', feature: true do
end end
context 'on branches page' do context 'on branches page' do
it_behaves_like 'Merge Request button only shown when allowed' do it_behaves_like 'Merge request button only shown when allowed' do
let(:label) { 'Merge Request' } let(:label) { 'Merge request' }
let(:url) { namespace_project_branches_path(project.namespace, project) } let(:url) { namespace_project_branches_path(project.namespace, project) }
let(:fork_url) { namespace_project_branches_path(forked_project.namespace, forked_project) } let(:fork_url) { namespace_project_branches_path(forked_project.namespace, forked_project) }
end end
end end
context 'on compare page' do context 'on compare page' do
it_behaves_like 'Merge Request button only shown when allowed' do it_behaves_like 'Merge request button only shown when allowed' do
let(:label) { 'Create Merge Request' } let(:label) { 'Create merge request' }
let(:url) { namespace_project_compare_path(project.namespace, project, from: 'master', to: 'feature') } let(:url) { namespace_project_compare_path(project.namespace, project, from: 'master', to: 'feature') }
let(:fork_url) { namespace_project_compare_path(forked_project.namespace, forked_project, from: 'master', to: 'feature') } let(:fork_url) { namespace_project_compare_path(forked_project.namespace, forked_project, from: 'master', to: 'feature') }
end end
end end
context 'on commits page' do context 'on commits page' do
it_behaves_like 'Merge Request button only shown when allowed' do it_behaves_like 'Merge request button only shown when allowed' do
let(:label) { 'Create Merge Request' } let(:label) { 'Create merge request' }
let(:url) { namespace_project_commits_path(project.namespace, project, 'feature') } let(:url) { namespace_project_commits_path(project.namespace, project, 'feature') }
let(:fork_url) { namespace_project_commits_path(forked_project.namespace, forked_project, 'feature') } let(:fork_url) { namespace_project_commits_path(forked_project.namespace, forked_project, 'feature') }
end end
......
...@@ -24,12 +24,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t ...@@ -24,12 +24,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t
context "while creating a new wiki page" do context "while creating a new wiki page" do
context "when there are no spaces or hyphens in the page name" do context "when there are no spaces or hyphens in the page name" do
it "rewrites relative links as expected" do it "rewrites relative links as expected" do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'a/b/c/d' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'a/b/c/d'
click_button 'Create page'
end
fill_in :wiki_content, with: wiki_content page.within '.wiki-form' do
click_on "Preview" fill_in :wiki_content, with: wiki_content
click_on "Preview"
end
expect(page).to have_content("regular link") expect(page).to have_content("regular link")
...@@ -42,12 +46,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t ...@@ -42,12 +46,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t
context "when there are spaces in the page name" do context "when there are spaces in the page name" do
it "rewrites relative links as expected" do it "rewrites relative links as expected" do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'a page/b page/c page/d page' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'a page/b page/c page/d page'
click_button 'Create page'
end
fill_in :wiki_content, with: wiki_content page.within '.wiki-form' do
click_on "Preview" fill_in :wiki_content, with: wiki_content
click_on "Preview"
end
expect(page).to have_content("regular link") expect(page).to have_content("regular link")
...@@ -60,12 +68,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t ...@@ -60,12 +68,16 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t
context "when there are hyphens in the page name" do context "when there are hyphens in the page name" do
it "rewrites relative links as expected" do it "rewrites relative links as expected" do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'a-page/b-page/c-page/d-page' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'a-page/b-page/c-page/d-page'
click_button 'Create page'
fill_in :wiki_content, with: wiki_content end
click_on "Preview"
page.within '.wiki-form' do
fill_in :wiki_content, with: wiki_content
click_on "Preview"
end
expect(page).to have_content("regular link") expect(page).to have_content("regular link")
...@@ -79,11 +91,17 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t ...@@ -79,11 +91,17 @@ feature 'Projects > Wiki > User previews markdown changes', feature: true, js: t
context "while editing a wiki page" do context "while editing a wiki page" do
def create_wiki_page(path) def create_wiki_page(path)
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: path
click_button 'Create Page' page.within '#modal-new-wiki' do
fill_in :wiki_content, with: 'content' fill_in :new_wiki_path, with: path
click_on "Create page" click_button 'Create page'
end
page.within '.wiki-form' do
fill_in :wiki_content, with: 'content'
click_on "Create page"
end
end end
context "when there are no spaces or hyphens in the page name" do context "when there are no spaces or hyphens in the page name" do
......
...@@ -21,8 +21,9 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -21,8 +21,9 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
scenario 'directly from the wiki home page' do scenario 'directly from the wiki home page' do
fill_in :wiki_content, with: 'My awesome wiki!' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page' page.within '.wiki-form' do
click_button 'Create page'
end
expect(page).to have_content('Home') expect(page).to have_content('Home')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
expect(page).to have_content('My awesome wiki!') expect(page).to have_content('My awesome wiki!')
...@@ -36,16 +37,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -36,16 +37,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
context 'via the "new wiki page" page' do context 'via the "new wiki page" page' do
scenario 'when the wiki page has a single word name', js: true do scenario 'when the wiki page has a single word name', js: true do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'foo' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'foo'
click_button 'Create page'
end
# Commit message field should have correct value. # Commit message field should have correct value.
expect(page).to have_field('wiki[message]', with: 'Create foo') expect(page).to have_field('wiki[message]', with: 'Create foo')
fill_in :wiki_content, with: 'My awesome wiki!' page.within '.wiki-form' do
click_button 'Create page' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page'
end
expect(page).to have_content('Foo') expect(page).to have_content('Foo')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
...@@ -53,16 +58,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -53,16 +58,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
end end
scenario 'when the wiki page has spaces in the name', js: true do scenario 'when the wiki page has spaces in the name', js: true do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'Spaces in the name' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'Spaces in the name'
click_button 'Create page'
end
# Commit message field should have correct value. # Commit message field should have correct value.
expect(page).to have_field('wiki[message]', with: 'Create spaces in the name') expect(page).to have_field('wiki[message]', with: 'Create spaces in the name')
fill_in :wiki_content, with: 'My awesome wiki!' page.within '.wiki-form' do
click_button 'Create page' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page'
end
expect(page).to have_content('Spaces in the name') expect(page).to have_content('Spaces in the name')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
...@@ -70,16 +79,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -70,16 +79,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
end end
scenario 'when the wiki page has hyphens in the name', js: true do scenario 'when the wiki page has hyphens in the name', js: true do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'hyphens-in-the-name' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'hyphens-in-the-name'
click_button 'Create page'
end
# Commit message field should have correct value. # Commit message field should have correct value.
expect(page).to have_field('wiki[message]', with: 'Create hyphens in the name') expect(page).to have_field('wiki[message]', with: 'Create hyphens in the name')
fill_in :wiki_content, with: 'My awesome wiki!' page.within '.wiki-form' do
click_button 'Create page' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page'
end
expect(page).to have_content('Hyphens in the name') expect(page).to have_content('Hyphens in the name')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
...@@ -99,7 +112,9 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -99,7 +112,9 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
scenario 'directly from the wiki home page' do scenario 'directly from the wiki home page' do
fill_in :wiki_content, with: 'My awesome wiki!' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page' page.within '.wiki-form' do
click_button 'Create page'
end
expect(page).to have_content('Home') expect(page).to have_content('Home')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
...@@ -113,16 +128,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do ...@@ -113,16 +128,20 @@ feature 'Projects > Wiki > User creates wiki page', feature: true do
end end
scenario 'via the "new wiki page" page', js: true do scenario 'via the "new wiki page" page', js: true do
click_link 'New Page' click_link 'New page'
fill_in :new_wiki_path, with: 'foo' page.within '#modal-new-wiki' do
click_button 'Create Page' fill_in :new_wiki_path, with: 'foo'
click_button 'Create page'
end
# Commit message field should have correct value. # Commit message field should have correct value.
expect(page).to have_field('wiki[message]', with: 'Create foo') expect(page).to have_field('wiki[message]', with: 'Create foo')
fill_in :wiki_content, with: 'My awesome wiki!' page.within '.wiki-form' do
click_button 'Create page' fill_in :wiki_content, with: 'My awesome wiki!'
click_button 'Create page'
end
expect(page).to have_content('Foo') expect(page).to have_content('Foo')
expect(page).to have_content("Last edited by #{user.name}") expect(page).to have_content("Last edited by #{user.name}")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment