- 19 Jul, 2017 2 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- 18 Jul, 2017 21 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
Also make sure pipeline would also check against tag as well
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
* upstream/master: (25 commits) Remove unneeded asserts and add tests for inactive RequestStore Rename the methods to make it fit with current name Follow feedback on the merge request Make sure it checks against the tag only when it's a tag Renamed Gitaly services fix transient rspec failure due to Poll.js race condition Refactor variables initialization in dropzone_input.js cache the cache key... avoid #respond_to? in Cache.id_for cache DeclarativePolicy.class_for at the class level Update 9.3-to-9.4.md fix padding on filtered search dropdown. Styles should only apply to li in list Cache Note#notable for commits and fix tests Add changelog entry Update the comments for the new functionality Use RequestStoreWrap for Commit#author Skip dead jobs queue for web hooks and project services Add RequestStoreWrap to cache via RequestStore Don't track cached queries in Gitlab::PerformanceBar::PeekQueryTracker Add changelog entry ...
-
Rémy Coutable authored
Add RequestCache to cache via RequestStore See merge request !12920
-
Lin Jen-Shin authored
-
Grzegorz Bizon authored
Protect manual actions against protected tag too Closes #34927 See merge request !12908
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Sean McGivern authored
Perf: Improve performance of basic ruby ops in DeclarativePolicy See merge request !12922
-
Phil Hughes authored
fix transient rspec failure due to Poll.js race condition Closes #35225 See merge request !12930
-
Lin Jen-Shin authored
-
Sean McGivern authored
Renamed Gitaly services Closes gitaly#379 See merge request !12854
-
Andrew Newdigate authored
-
Sean McGivern authored
Update 9.3-to-9.4.md See merge request !12925
-
Simon Knox authored
don't treat aborted requests as failures, they are often triggered during unload (e.g after clicking a link)
-
Clement Ho authored
Refactor variables initialization in dropzone_input.js Closes #29901 See merge request !12768
-
Brandon Everett authored
-
- 17 Jul, 2017 17 commits
-
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
Andrew Newdigate authored
-
Jacob Schatz authored
Remove coffee-rails gem Closes #34831 See merge request !12715
-
Annabel Dunstone Gray authored
fix padding on filtered search Closes #35177 See merge request !12913
-
Simon Knox authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
We also try to use instance variable to cache the result if RequestStore is not available, so we could keep the same logic, using the same cache key. Also introduce a way to specify method specific cache key
-
Sean McGivern authored
Resolve "Peek performance bar doesn't count cached queries, but shows them" Closes #34940 See merge request !12915
-
Rémy Coutable authored
Resolve "Don't let webhooks jobs go to the dead jobs queue" Closes #31571 See merge request !12918
-
Annabel Dunstone Gray authored
Added sub-nav to new group sidebar settings Closes #35140 See merge request !12907
-
Sean McGivern authored
These jobs may legitimately fail because the endpoint just isn't there any more. We don't want them cluttering up the Sidekiq morgue in that case - it's currently full on GitLab.com.
-
Annabel Dunstone Gray authored
Fixed project members link not staying active Closes gitlab-ee#2942 See merge request !12882
-
Lin Jen-Shin authored
I don't like the idea of `RequestStore` at all, because it's just a global state which shouldn't be used at all. But we have a number of places calling `ProtectedBranch.protected?` and `ProtectedTag.protected?` in a loop for the same user, project, and ref whenever we're checking against if the jobs for a given pipeline is accessible for a given user. This means we're effectively making N queries for the same thing over and over. To properly fix this, we need to change how we check the permission, and that could be a huge work. To solve this quickly, adding a cache layer for the given request would be quite simple to do. We're already doing this in Commit#author, and this is extending that idea and make it generalized.
-