Apply rules only in case if movement is completed.

master/bt5/vifib_base/SkinTemplateItem/portal_skins/vifib_simulation/SimulationMovement_testDeliverySimulationRule.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>Script_magic</string> </key>
+            <value> <int>3</int> </value>
+        </item>
+        <item>
+            <key> <string>_bind_names</string> </key>
+            <value>
+              <object>
+                <klass>
+                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
+                </klass>
+                <tuple/>
+                <state>
+                  <dictionary>
+                    <item>
+                        <key> <string>_asgns</string> </key>
+                        <value>
+                          <dictionary>
+                            <item>
+                                <key> <string>name_container</string> </key>
+                                <value> <string>container</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_context</string> </key>
+                                <value> <string>context</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_m_self</string> </key>
+                                <value> <string>script</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_subpath</string> </key>
+                                <value> <string>traverse_subpath</string> </value>
+                            </item>
+                          </dictionary>
+                        </value>
+                    </item>
+                  </dictionary>
+                </state>
+              </object>
+            </value>
+        </item>
+        <item>
+            <key> <string>_body</string> </key>
+            <value> <string>movement = context\n
+\n
+if movement.getExplanationValue().getPortalType().startswith(\'Purchase\'):\n
+  # Vifib case: Purchase Business Process is minimalistic and does not care about\n
+  # invoice (and deeper parts of tree)\n
+  # But when this rule would get applied, it will try to create 0 simulation movements\n
+  # and code inside of BusinessProcess.py would raise "ValueError: A Business Process can not erase amounts"\n
+  # So just do not apply the rule in such case.\n
+  return False\n
+source_section = movement.getSourceSection()\n
+destination_section = movement.getDestinationSection()\n
+if source_section == destination_section or source_section is None \\\n
+    or destination_section is None:\n
+  return False\n
+\n
+if movement.getSimulationState() in movement.getCausalityValue(portal_type=\'Business Link\').getCompletedStateList():\n
+  return True\n
+\n
+return False\n
+</string> </value>
+        </item>
+        <item>
+            <key> <string>_params</string> </key>
+            <value> <string>rule</string> </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>SimulationMovement_testDeliverySimulationRule</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+</ZopeData>

master/bt5/vifib_base/SkinTemplateItem/portal_skins/vifib_simulation/SimulationMovement_testInvoiceSimulationRule.xml

@@ -65,7 +65,10 @@ if source_section == destination_section or source_section is None \\\n
     or destination_section is None:\n
   return False\n
 \n
-return True\n
+if movement.getSimulationState() in movement.getCausalityValue(portal_type=\'Business Link\').getCompletedStateList():\n
+  return True\n
+\n
+return False\n
 </string> </value>
         </item>
         <item>

master/bt5/vifib_base/SkinTemplateItem/portal_skins/vifib_simulation/SimulationMovement_testInvoiceTransactionSimulationRule.xml

@@ -58,7 +58,10 @@ if delivery_movement is not None and (\n
     and delivery_movement.getPortalType() not in movement.getPortalTaxMovementTypeList()):\n
   return False\n
 \n
-return True\n
+if movement.getSimulationState() in movement.getCausalityValue(portal_type=\'Business Link\').getCompletedStateList():\n
+  return True\n
+\n
+return False\n
 </string> </value>
         </item>
         <item>

master/bt5/vifib_base/SkinTemplateItem/portal_skins/vifib_simulation/SimulationMovement_testPaymentSimulationRule.xml

@@ -56,6 +56,9 @@
 receivable_account_type_list = (\'asset/receivable\',)\n
 payable_account_type_list = (\'liability/payable\',)\n
 \n
+if movement.getSimulationState() not in movement.getCausalityValue(portal_type=\'Business Link\').getCompletedStateList():\n
+  return False\n
+\n
 for account in (movement.getSourceValue(portal_type=\'Account\'),\n
                 movement.getDestinationValue(portal_type=\'Account\')):\n
   if account is not None:\n

master/bt5/vifib_base/bt/revision

-354
+355
\ No newline at end of file